X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FView%2FComponent%2FSubInclude%2FSubRequest.pm;h=75b5d6b4c4470ae893c0def8f80c54f0f7cf9e72;hb=9399de67c73e690611087f7aa359537a7bef4b46;hp=5c8cf7a09b8c56b63618989ae99758d0f1967756;hpb=4e3277560cc20740e2cdb58f4f9cf8eda74c9d73;p=catagits%2FCatalyst-View-Component-SubInclude.git

diff --git a/lib/Catalyst/View/Component/SubInclude/SubRequest.pm b/lib/Catalyst/View/Component/SubInclude/SubRequest.pm
index 5c8cf7a..75b5d6b 100644
--- a/lib/Catalyst/View/Component/SubInclude/SubRequest.pm
+++ b/lib/Catalyst/View/Component/SubInclude/SubRequest.pm
@@ -2,17 +2,20 @@ package Catalyst::View::Component::SubInclude::SubRequest;
 use warnings;
 use strict;
 
+use Carp qw/croak/;
+use namespace::clean qw/croak/;
+
 =head1 NAME
 
 Catalyst::View::Component::SubInclude::SubRequest - Sub-requests plugin for C::V::Component::SubInclude
 
 =head1 VERSION
 
-Version 0.01
+Version 0.07
 
 =cut
 
-our $VERSION = '0.01';
+our $VERSION = '0.07';
 
 =head1 SYNOPSIS
 
@@ -48,17 +51,21 @@ to render the subinclude contents.
 
 It requires L<Catalyst::Plugin::SubRequest>.
 
-=head1 STASH FUNCTION
+=head1 CLASS METHODS
+
+=head2 C<generate_subinclude( $c, $path, @args )>
 
-=head2 C<subinclude( $path, @args )>
+This will make a sub-request call to the action specified by C<$path>. Note that
+C<$path> should be the private action path - translation to the public path is
+handled internally.
 
-This will translate to the following sub-request call:
+So, after path translation, the call will be (roughly) equivalent to:
 
-  $c->sub_request( $path, {}, @args );
+  $c->sub_request( $translated_path, {}, @args );
 
 Notice that the stash will always be empty. This behavior could be configurable
 in the future through an additional switch - for now, this behavior guarantees a
-common interface for plugins.
+common interface for all plugins.
 
 =cut
 
@@ -69,7 +76,15 @@ sub generate_subinclude {
     croak "subincludes through subrequests require Catalyst::Plugin::SubRequest"
         unless $c->can('sub_request');
 
-    $c->sub_request( $path, $stash, @params );
+    my $args  = ref $params[0]  eq 'ARRAY' ? shift @params : [];
+    my $query = ref $params[-1] eq 'HASH'  ?   pop @params : {};
+    
+    my $dispatcher = $c->dispatcher;
+    my ($action) = $dispatcher->_invoke_as_path( $c, $path, $args );
+
+    my $uri = $c->uri_for( $action, $args, @params );
+
+    $c->sub_request( $uri->path, $stash, $query );
 }
 
 =head1 SEE ALSO