X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FUpgrading.pod;h=5aefdd3ec2dcb45d60d2b9677c7f41e6b74d3223;hb=802bf2cb6b22e02039049440985b26d23bbe330b;hp=4d370072c6080290e1ed6970e2b90842de1e246d;hpb=845bfcd2f888e02d8f952088eaeb169fbbae9841;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Upgrading.pod b/lib/Catalyst/Upgrading.pod index 4d37007..5aefdd3 100644 --- a/lib/Catalyst/Upgrading.pod +++ b/lib/Catalyst/Upgrading.pod @@ -1,23 +1,82 @@ =head1 Upgrading to Catalyst 5.80 -Work in progress +Most applications and plugins should run unaltered on Catalyst 5.80. -=head1 Known backwards compatibility breakages. +However as a lot of refactoring work has taken place, and several changes have +been made which could cause incompatibilities. If your application or plugin +is using deprecated code, or relying on side-effects, then you could have +issues upgrding to this release. + +Most issues found with pre-existing components have been easy to solve, and a +complete description of behavior changes which may cause compatibility issues, +or warnings which are now emitted is included below to help if you have problems. -=head2 Catalyst::Plugin::Authentication +If you think you have found an upgrade related issue which is not covered in +this document, then please email the Catalyst list to discuss the problem. -You need at least version FIXME of Catalyst::Plugin::Authentication. +=head1 Known backwards compatibility breakages. -=head2 Moose applications +=head2 Components which inherit from Moose::Object before Catalyst::Component -Moose components for Catalyst 5.70 needed to do +Moose components which say: + package TestApp::Controller::Example; + use Moose; extends qw/Moose::Object Catalyst::Component/; -to be able to use the constructor provided by Moose. In 5.80 -C already inherits from C. Therefor you -shouldn't directly inherit from C yourself, otherwise your -Class' @ISA will not linearise with C3. +to use the constructor provided by Moose, whilst working (if you do some hacks +with the C< BUILDARGS > method), will not work with Catalyst 5.80 as +C inherits from C, and so C< @ISA > fails +to linearise. + +The fix for this is to not inherit directly from C +yourself. Having components which do not inherit their constructor from +C is B, and has never been recommended, +therefore you're on your own if you're using this technique. You'll need +to detect the version of Catalyst your application is running with and deal +with it appropriately. + +You will also see this issue if you do the following: + + package TestApp::Controller::Example; + use Moose; + use base 'Catalyst::Controller'; + +as C< use base > appends to @ISA. + +The correct way to use Moose in a component in a both forward and backwards +compatible way is: + + package TestApp::Controller::Root; + use Moose; + BEGIN { extends 'Catalyst::Component' }; # Or ::Controller, or whatever + +Note that the C< extends > decleration needs to occur in a begin block for +L to operate correctly. You also don't get the L +constructor, and therefore attribute initialization will not work as normally +expected. If you want to use Moose attributes, then they need to be made lazy +to correctly initialize. + +=head3 use Moose in MyApp + +Similar to the above, this will also fail: + + package MyApp; + use Moose; + use Catalyst qw/ + ConfigLoader + /; + __PACKAGE__->setup; + +If you need to use Moose in your application class (e.g. for method modifiers +etc) then the correct technique is: + + package MyApp; + use Moose; + extends 'Catalyst'; + __PACKAGE__->setup(qw/ + ConfigLoader + /); =head2 Anonymous closures installed directly into the symbol table @@ -25,79 +84,147 @@ If you have any code which installs anonymous subroutine references directly into the symbol table, you may encounter breakages. The simplest solution is to use L to name the subroutine. Example: - #Originalcode, likely to break: - my $full_method_name = join('::',$package_name, $method_name); + # Original code, likely to break: + my $full_method_name = join('::', $package_name, $method_name); *$full_method_name = sub { ... }; - #Fixed Code + # Fixed Code use Sub::Name 'subname'; my $full_method_name = join('::',$package_name, $method_name); *$full_method_name = subname $full_method_name, sub { ... }; -Additionally, you can take advantage of Catalyst's use of L and +Additionally, you can take advantage of Catalysts use of L and install the closure using the appropriate metaclass. Example: use Class::MOP; my $metaclass = Moose::Meta::Class->initialize($package_name); $metaclass->add_method($method_name => sub { ... }); -=head2 Components without new methods +=head2 Hooking into application setup -FIXME +To execute code during application startup the following snippet in MyApp.pm +used to work: -=head2 Components without COMPONENT methods + sub setup { + my ($class, @args) = @_; + $class->NEXT::setup(@args); + ... # things to do after the actual setup + } -FIXME +With Catalyst 5.80 this won't work anymore. Due to the fact that Catalyst is +no longer using NEXT.pm for method resolution, this no longer works. The +functionality was only ever originally operational as L remembers what +methods have already been called, and will not call them again. -=head2 __PACKAGE__->mk_accessor('meta'); +Using this now causes infinite recursion between MyApp::setup and +Catalyst::setup, due to other backwards compatibility issues related to how +plugin setup works. Moose method modifiers like C<< before|after|around 'setup +=> sub { ... }; >> also will not operate correctly on the setup method. + +The right way to do it is this: + + after setup_finalize => sub { + ... # things to do after the actual setup + }; + +The setup_finalize hook was introduced as a way to void this issue. + +=head2 Components with a new method which returns false -Won't work due to a limitation of L +Previously, if you had a component which inherited from Catalyst::COMPONENT, +but overrode the new method to return false, then your class' configuration +would be blessed into a hash on your behalf, and this would be returned from +the COMPONENT method. -FIXME +This behaviour makes no sense, and so has been removed. Implementing your own +C< new > method in components is B discouraged, instead, you should +inherit the new method from Catalyst::Component, and use Mooses BUILD +functionality and/or Moose attributes to perform any construction work +necessary for your class. + +=head2 __PACKAGE__->mk_accessor('meta'); + +Won't work due to a limitation of L. This is currently being fixed +inside Moose. =head2 Class::Data::Inheritable side effects -FIXME +Previously, writing to a class data accessor would copy the accessor method +down into your package. -=head2 Extending Catalyst::Request or other classes in an ad-hoc manor using mk_accessor +This behavior has been removed. Whilst the class data is still stored +per-class, it is stored on the metaclass of the class defining the accessor. -FIXME +Therefore anything relying on the side-effect of the accessor being copied down +will be broken. -=head2 require $class was successful but the package is not defined. +The following test demonstrates the problem: -FIXME Warning + { + package BaseClass; + use base qw/Class::Data::Inheritable/; + __PACKAGE__->mk_classdata('foo'); + } -=head2 $c->plugin method + { + package Child; + use base qw/BaseClass/; + } + + BaseClass->foo('base class'); + Child->foo('sub class'); + + use Test::More; + isnt(BaseClass->can('foo'), Child->can('foo')); + +=head2 Extending Catalyst::Request or other classes in an ad-hoc manor using mk_accessors + +Previously, it was possible to add additional accessors to Catalyst::Request +(or other classes) by calling the mk_accessors class method. + +This is no longer supported - users should make a sub-class of the class whos +behavior they would like to change, rather than globally polluting the +Catalyst objects. -Deprecated +=head2 Confused multiple inheritance with Catalyst::Component::COMPONENT -=head2 Components which inherit Catalyst::Component's COMPONENT method, who's new method does not return a true value. +Warning message: + + There is a COMPONENT method resolving after Catalyst::Component + in ${next_package}. -Previously if your new method returned a false value, then your class' configuration would be blessed into a hash on your behalf, -and this would be returned from the COMPONENT method. This is no longer supported. You are not recommended to implement your own new method -in components, instead, you should inherit the new method from Catalyst::Component, and use Moose's BUILD functionality -to perform any construction work necessary for your sub-class. +This means that one of the packages on the right hand side of +Catalyst::Component in your Class' inheritance hierarchy defines a COMPONENT +method. +Previously, Catalyst's COMPONENT method would delegate to the method on the +right hand side, which could then delegate back again with NEXT. This (as it +is insane), is no longer supported, as it makes no sense with C3 method +dispatch order. + +Therefore the correct fix is to re-arrange your class' inheritance hierarchy +so that the COMPONENT method you would like to inherit is the first COMPONENT +method in your @ISA. =head1 WARNINGS =head2 Methods in Catalyst::Dispatcher -The following methods in Catalyst::Dispatcher are likely to change -significantly in the 5.8X release series, and therefore their use is highly -deprecated. +The following methods in Catalyst::Dispatcher are both an implementation detail, +and also likely to change significantly in the 5.8X release series, and therefore +their use is highly deprecated. =over -=item tree +=item tree -=item dispatch_types +=item dispatch_types -=item registered_dispatch_types +=item registered_dispatch_types -=item method_action_class +=item method_action_class -=item action_hash +=item action_hash =item container_hash @@ -110,29 +237,27 @@ The first time one of these methods is called, a warning will be emitted: You should B be calling any of these methods from application code. -Plugins authors and maintainers whos plugins need to call these methods -should email the development list to discuss your use-case, and what a -better API should look like. +Plugins authors and maintainers whos plugins currently call these methods +should change to using the public API, or, if you do not feel the public API +adaquately supports your use-case, please email the development list to +discuss what API features you need so that you can be appropriately supported. + +=head2 require $class was successful but the package is not defined. -=head2 Confused multiple inheritence with Catalyst::Component::COMPONENT +In this version of Catalyst, if a component is loaded from disk, but no +symbols are defined in that component's namespace after it is loaded, this +warning will be issued. -Warning message: +This is to protect against confusing bugs caused by mis-typing package names. - There is a COMPONENT method resolving after Catalyst::Component - in ${next_package}. - -This means that one of the packages on the right hand side of -Catalyst::Component in your Class' inheritance hierarchy defines -a COMPONENT method. +This will become a fatal error in a future version. -Previously, Catalyst's COMPONENT method would delegate to the -method on the right hand side, which could then delegate back again -with NEXT. This (as it is insane), is no longer supported, as it -makes no sense with C3 method dispatch order. +=head2 $c->plugin method -Therefore the correct fix is to re-arrange your class' inheritance -hierarchy so that the COMPONENT method you would like to inherit is -the first COMPONENT method in your @ISA. +Calling the plugin method is deprecated, and calling it at runtime is B. +Instead you are recommended to use L< Catalyst::Model::Adaptor > or similar to +compose the functionality you need outside of the main application namespace. =cut