X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FStats.pm;h=9e2410803393d8fcdc04b6c5101eb4a783db094a;hb=77f23d2a797fdde1e4e8e21c6bdff58639144383;hp=0c3991535e531091921b1a476ee9e35753e34d69;hpb=ac5c933bdd463558e8d621507a53a7b247a9093e;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Stats.pm b/lib/Catalyst/Stats.pm index 0c39915..9e24108 100644 --- a/lib/Catalyst/Stats.pm +++ b/lib/Catalyst/Stats.pm @@ -87,10 +87,6 @@ sub elapsed { sub report { my $self = shift; - # close any remaining open nodes - map { $self->profile(end => $_->getNodeValue->{action}) } - (reverse @{ $self->stack })[1 .. $#{$self->stack}]; - my $t = Text::SimpleTable->new( [ 62, 'Action' ], [ 9, 'Time' ] ); my @results; $self->tree->traverse( @@ -103,8 +99,10 @@ sub report { $stat->{elapsed}, $stat->{action} ? 1 : 0, ); + # Trim down any times >= 10 to avoid ugly Text::Simple line wrapping + my $elapsed = substr(sprintf("%f", $stat->{elapsed}), 0, 8) . "s"; $t->row( ( q{ } x $r[0] ) . $r[1], - defined $r[2] ? sprintf("%fs", $r[2]) : '??'); + defined $r[2] ? $elapsed : '??'); push(@results, \@r); } ); @@ -120,6 +118,52 @@ sub _get_uid { return $visitor->getResult; } +sub accept { + my $self = shift; + $self->{tree}->accept( @_ ); +} + +sub addChild { + my $self = shift; + my $node = $_[ 0 ]; + + my $stat = $node->getNodeValue; + + # do we need to fake $stat->{ t } ? + if( $stat->{ elapsed } ) { + # remove the "s" from elapsed time + $stat->{ elapsed } =~ s{s$}{}; + } + + $self->{tree}->addChild( @_ ); +} + +sub setNodeValue { + my $self = shift; + my $stat = $_[ 0 ]; + + # do we need to fake $stat->{ t } ? + if( $stat->{ elapsed } ) { + # remove the "s" from elapsed time + $stat->{ elapsed } =~ s{s$}{}; + } + + $self->{tree}->setNodeValue( @_ ); +} + +sub getNodeValue { + my $self = shift; + $self->{tree}->getNodeValue( @_ )->{ t }; +} + +sub traverse { + my $self = shift; + $self->{tree}->traverse( @_ ); +} + +no Moose; +__PACKAGE__->meta->make_immutable(); + 1; __END__ @@ -287,14 +331,28 @@ from the previous profiling point. The 'rollup' flag indicates whether the reported time is the rolled up time for the block, or the elapsed time from the previous profiling point. +=head1 COMPATABILITY METHODS + +Some components might expect the stats object to be a regular Tree::Simple object. +We've added some compatability methods to handle this scenario: + +=head2 accept + +=head2 addChild + +=head2 setNodeValue + +=head2 getNodeValue + +=head2 traverse =head1 SEE ALSO -L. +L -=head1 AUTHOR +=head1 AUTHORS -Jon Schutz +Catalyst Contributors, see Catalyst.pm =head1 COPYRIGHT