X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FResponse.pm;h=cd818579615e578d82d6765afd9625165b1d60ca;hb=8738b8fecb20f3761d76a8d7f46660fdae54993a;hp=5f49df75452dcc5ef8d2973324ff60022e4b9280;hpb=be5c8c2413b7b83b99cdae51d094907b0343583d;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Response.pm b/lib/Catalyst/Response.pm index 5f49df7..cd81857 100644 --- a/lib/Catalyst/Response.pm +++ b/lib/Catalyst/Response.pm @@ -43,17 +43,50 @@ has headers => ( required => 1, lazy => 1, ); -has _context => ( - is => 'rw', - weak_ref => 1, - handles => ['write'], - clearer => '_clear_context', -); sub output { shift->body(@_) } sub code { shift->status(@_) } +sub write { + my ( $self, $buffer ) = @_; + + # Finalize headers if someone manually writes output + $self->finalize_headers; + + $buffer = q[] unless defined $buffer; + + my $len = length($buffer); + $self->_writer->write($buffer); + + return $len; +} + +sub finalize_headers { + my ($self) = @_; + + # This is a less-than-pretty hack to avoid breaking the old + # Catalyst::Engine::PSGI. 5.9 Catalyst::Engine sets a response_cb and + # expects us to pass headers to it here, whereas Catalyst::Enngine::PSGI + # just pulls the headers out of $ctx->response in its run method and never + # sets response_cb. So take the lack of a response_cb as a sign that we + # don't need to set the headers. + + return unless $self->_has_response_cb; + + # If we already have a writer, we already did this, so don't do it again + return if $self->_has_writer; + + my @headers; + $self->headers->scan(sub { push @headers, @_ }); + + my $writer = $self->_response_cb->([ $self->status, \@headers ]); + $self->_set_writer($writer); + $self->_clear_response_cb; + + return; +} + =head1 NAME Catalyst::Response - stores output responding to the current client request @@ -213,6 +246,10 @@ Writes $data to the output stream. Prints @data to the output stream, separated by $,. This lets you pass the response object to functions that want to write to an L. +=head2 $self->finalize_headers($c) + +Writes headers to response if not already written + =head2 DEMOLISH Ensures that the response is flushed and closed at the end of the