X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FRequest.pm;h=021bf2431cee439f1922a81a1d389961cedfeb2d;hb=591feafa881b4842124e75fccdf87c76da555e9a;hp=69ddd698e81b3066450ff7b32efe677defd71a30;hpb=f52cae567165a9575c0fd92555b2cebf6f772487;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Request.pm b/lib/Catalyst/Request.pm index 69ddd69..021bf24 100644 --- a/lib/Catalyst/Request.pm +++ b/lib/Catalyst/Request.pm @@ -243,7 +243,7 @@ sub prepare_body { # If previously applied middleware created the HTTP::Body object, then we # just use that one. - if(my $plack_body = $self->env->{'plack.request.http.body'}) { + if(my $plack_body = $self->_has_env ? $self->env->{'plack.request.http.body'} : undef) { $self->_body($plack_body); $self->_body->cleanup(1); return; @@ -439,6 +439,7 @@ Catalyst::Request - provides information about the current client request $req->uri; $req->user; $req->user_agent; + $req->env; See also L, L. @@ -644,9 +645,15 @@ sub param { return keys %{ $self->parameters }; } - if ( @_ == 1 ) { + # If anything in @_ is undef, carp about that, and remove it from + # the list; + + my @params = grep { defined($_) ? 1 : do {carp "You called ->params with an undefined value"; 0} } @_; + + if ( @params == 1 ) { - my $param = shift; + defined(my $param = shift @params) || + carp "You called ->params with an undefined value 2"; unless ( exists $self->parameters->{$param} ) { return wantarray ? () : undef; @@ -663,9 +670,9 @@ sub param { : $self->parameters->{$param}; } } - elsif ( @_ > 1 ) { - my $field = shift; - $self->parameters->{$field} = [@_]; + elsif ( @params > 1 ) { + my $field = shift @params; + $self->parameters->{$field} = [@params]; } } @@ -989,6 +996,9 @@ combined from those in the request and those in the body. If parameters have already been set will clear the parameters and build them again. +=head2 $self->env + +Access to the raw PSGI env. =head2 meta