X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FLog.pm;h=ef085ffb7d2f81e0870e6f3f503f1e3a48ad3d8d;hb=63475445f8f83884792dbc81ab9fdc37ce142088;hp=e70197f68b9a371269c8661347781f0c34c5a14a;hpb=1b526dcc8437ccd8c55e8e313f3fe247b6741969;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Log.pm b/lib/Catalyst/Log.pm old mode 100755 new mode 100644 index e70197f..ef085ff --- a/lib/Catalyst/Log.pm +++ b/lib/Catalyst/Log.pm @@ -4,7 +4,6 @@ use Moose; with 'MooseX::Emulate::Class::Accessor::Fast'; use Data::Dump; -use Moose::Util 'find_meta'; use Carp qw/ cluck /; our %LEVELS = (); # Levels stored as bit field, ergo debug = 1, warn = 2 etc @@ -34,9 +33,8 @@ sub psgienv { { my @levels = qw[ debug info warn error fatal ]; - my $meta = find_meta(__PACKAGE__); my $summed_level = 0; - for ( my $i = $#levels ; $i >= 0 ; $i-- ) { + for my $i ( reverse 0 .. $#levels ) { my $name = $levels[$i]; @@ -46,29 +44,43 @@ sub psgienv { $LEVELS{$name} = $level; $LEVEL_MATCH{$name} = $summed_level; - $meta->add_method($name, sub { + no strict 'refs'; + + *$name = sub { my $self = shift; if ( $self->level & $level ) { $self->_log( $name, @_ ); } - }); + }; - $meta->add_method("is_$name", sub { + *{"is_$name"} = sub { my $self = shift; return $self->level & $level; - });; + }; } } -around new => sub { - my $orig = shift; +sub BUILDARGS { my $class = shift; - my $self = $class->$orig; + my $args; - $self->levels( scalar(@_) ? @_ : keys %LEVELS ); + if (@_ == 1 && ref $_[0] eq 'HASH') { + $args = $_[0]; + } + else { + $args = { + levels => [@_ ? @_ : keys %LEVELS], + }; + } - return $self; + if (delete $args->{levels}) { + my $level = 0; + $level |= $_ + for map $LEVEL_MATCH{$_}, @_ ? @_ : keys %LEVELS; + $args->{level} = $level; + } + return $args; }; sub levels { @@ -141,27 +153,27 @@ sub _send_to_log { if ($self->can('_has_psgi_errors') and $self->_has_psgi_errors) { $self->_psgi_errors->print(@_); } else { + binmode STDERR, ":utf8"; print STDERR @_; } } # 5.7 compat code. # Alias _body to body, add a before modifier to warn.. -my $meta = __PACKAGE__->meta; # Calling meta method here fine as we happen at compile time. -$meta->add_method('body', $meta->get_method('_body')); +*body = \&_body; my %package_hash; # Only warn once per method, per package. # I haven't provided a way to disable them, patches welcome. -$meta->add_before_method_modifier('body', sub { +before body => sub { my $class = blessed(shift); $package_hash{$class}++ || do { warn("Class $class is calling the deprecated method Catalyst::Log->body method,\n" . "this will be removed in Catalyst 5.81"); }; -}); +}; # End 5.70 backwards compatibility hacks. no Moose; -__PACKAGE__->meta->make_immutable(inline_constructor => 0); +__PACKAGE__->meta->make_immutable; 1; @@ -291,19 +303,19 @@ to use Log4Perl or another logger, you should call it like this: =head2 autoflush -When enabled (default), messages are written to the log immediately instead -of queued until the end of the request. +When enabled (default), messages are written to the log immediately instead +of queued until the end of the request. -This option, as well as C, is provided for modules such as -L to be able to programmatically +This option, as well as C, is provided for modules such as +L to be able to programmatically suppress the output of log messages. By turning off C (application-wide -setting) and then setting the C flag within a given request, all log +setting) and then setting the C flag within a given request, all log messages for the given request will be suppressed. C can still be set -independently of turning off C, however. It just means any messages -sent to the log up until that point in the request will obviously still be emitted, +independently of turning off C, however. It just means any messages +sent to the log up until that point in the request will obviously still be emitted, since C means they are written in real-time. -If you need to turn off autoflush you should do it like this (in your main app +If you need to turn off autoflush you should do it like this (in your main app class): after setup_finalize => sub { @@ -334,8 +346,6 @@ will send to STDERR as before. Clears the PSGI environment attributes set by L. -=head2 meta - =head1 SEE ALSO L. @@ -350,7 +360,3 @@ This library is free software. You can redistribute it and/or modify it under the same terms as Perl itself. =cut - -__PACKAGE__->meta->make_immutable; - -1;