X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FLog.pm;h=751b2e43b54ac48dea7130948e2a5cc8003bf528;hb=eaae9a9246b1c213dfd1fdff44f76c5c77562ab3;hp=e1953b23e84c1b1cdd7ab044556701cbf0ef3f55;hpb=4090e3bb3fea1a73ac369250e31584d61428b808;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Log.pm b/lib/Catalyst/Log.pm index e1953b2..751b2e4 100644 --- a/lib/Catalyst/Log.pm +++ b/lib/Catalyst/Log.pm @@ -1,9 +1,13 @@ package Catalyst::Log; use Moose; +with 'MooseX::Emulate::Class::Accessor::Fast'; + use Data::Dump; +use Class::MOP (); -our %LEVELS = (); +our %LEVELS = (); # Levels stored as bit field, ergo debug = 1, warn = 2 etc +our %LEVEL_MATCH = (); # Stored as additive, thus debug = 31, warn = 30 etc has level => (is => 'rw'); has _body => (is => 'rw'); @@ -12,13 +16,17 @@ has abort => (is => 'rw'); { my @levels = qw[ debug info warn error fatal ]; - my $meta = __PACKAGE__->meta; - for ( my $i = 0 ; $i < @levels ; $i++ ) { + my $meta = Class::MOP::get_metaclass_by_name(__PACKAGE__); + my $summed_level = 0; + for ( my $i = $#levels ; $i >= 0 ; $i-- ) { my $name = $levels[$i]; + my $level = 1 << $i; + $summed_level |= $level; $LEVELS{$name} = $level; + $LEVEL_MATCH{$name} = $summed_level; $meta->add_method($name, sub { my $self = shift; @@ -39,7 +47,9 @@ around new => sub { my $orig = shift; my $class = shift; my $self = $class->$orig; + $self->levels( scalar(@_) ? @_ : keys %LEVELS ); + return $self; }; @@ -52,7 +62,7 @@ sub levels { sub enable { my ( $self, @levels ) = @_; my $level = $self->level; - for(map { $LEVELS{$_} } @levels){ + for(map { $LEVEL_MATCH{$_} } @levels){ $level |= $_; } $self->level($level); @@ -98,8 +108,23 @@ sub _send_to_log { print STDERR @_; } +# 5.7 compat code. +# Alias _body to body, add a before modifier to warn.. +my $meta = __PACKAGE__->meta; # Calling meta method here fine as we happen at compile time. +$meta->add_method('body', $meta->get_method('_body')); +my %package_hash; # Only warn once per method, per package. + # I haven't provided a way to disable them, patches welcome. +$meta->add_before_method_modifier('body', sub { + my $class = blessed(shift); + $package_hash{$class}++ || do { + warn("Class $class is calling the deprecated method Catalyst::Log->body method,\n" + . "this will be removed in Catalyst 5.81"); + }; +}); +# End 5.70 backwards compatibility hacks. + no Moose; -__PACKAGE__->meta->make_immutable(); +__PACKAGE__->meta->make_immutable(inline_constructor => 0); 1; @@ -217,8 +242,8 @@ Is the log level active? =head2 abort -Should Catalyst emit logs for this request? Will be reset at the end of -each request. +Should Catalyst emit logs for this request? Will be reset at the end of +each request. *NOTE* This method is not compatible with other log apis, so if you plan to use Log4Perl or another logger, you should call it like this: @@ -239,11 +264,9 @@ over the log output. L. -=head1 AUTHOR +=head1 AUTHORS -Sebastian Riedel, C -Marcus Ramberg, C -Christian Hansen, C +Catalyst Contributors, see Catalyst.pm =head1 COPYRIGHT