X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FIOC%2FContainer.pm;h=b89fd9669ee1e25b15191f6881eec2514239adb6;hb=8c199f8627c2d972d06aa0a98337ff7ba922d9af;hp=8a49438703b648f1ed6cb8ced5a1e2014118bd57;hpb=dcc2a475181033f04a873c85a370842277de44f1;p=catagits%2FCatalyst-Runtime.git

diff --git a/lib/Catalyst/IOC/Container.pm b/lib/Catalyst/IOC/Container.pm
index 8a49438..b89fd96 100644
--- a/lib/Catalyst/IOC/Container.pm
+++ b/lib/Catalyst/IOC/Container.pm
@@ -681,8 +681,11 @@ sub _find_component_regexp {
 # user overrides the container (which is what we want), the sub-container they
 # will use is precisely $type, not 'component'. So for now, I'm returning both
 # services, to decide later what to do.
+# TODO
+# add pod, remove code repetition
 sub get_all_component_services {
-    my ($self, $class) = @_;
+    my $self = shift;
+
     my %components;
     my $components_container = $self->get_sub_container('component');
 
@@ -710,6 +713,8 @@ sub get_all_component_services {
     return lock_hash %components;
 }
 
+# TODO
+# add pod, remove code repetition
 sub get_all_singleton_lifecycle_components {
     my $self = shift;
 
@@ -738,16 +743,12 @@ sub get_all_singleton_lifecycle_components {
     return lock_hash %components;
 }
 
+# TODO
+# remove code repetition
 sub get_all_components {
     my ($self, $class) = @_;
     my %components;
 
-    # FIXME - if we're getting from these containers, we need to either:
-    #   - pass 'ctx' and 'accept_context_args' OR
-    #   - make these params optional
-    # big problem when setting up the dispatcher - this method is called
-    # as $container->get_all_components('MyApp'). What to do with Request
-    # life cycles?
     foreach my $type (qw/model view controller /) {
         my $container = $self->get_sub_container($type);