X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FEngine.pm;h=ff7e5489b7e9685e214ba804b9f8c61716918600;hb=22a5833d436649391dc95877ca33f549308c6c3c;hp=35ab188c9bff35acf05fa07ebd3edadc3b634f90;hpb=eebe046fdd1c0b74d65920dd6df6977f470f64a1;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Engine.pm b/lib/Catalyst/Engine.pm index 35ab188..ff7e548 100644 --- a/lib/Catalyst/Engine.pm +++ b/lib/Catalyst/Engine.pm @@ -11,6 +11,9 @@ use HTTP::Body; use HTTP::Headers; use URI::QueryParam; use Moose::Util::TypeConstraints; +use Plack::Loader; +use Plack::Middleware::Conditional; +use Plack::Middleware::ReverseProxy; use namespace::clean -except => 'meta'; @@ -432,7 +435,7 @@ sub prepare_connection { $request->protocol( $env->{SERVER_PROTOCOL} ); $request->remote_user( $env->{REMOTE_USER} ); $request->method( $env->{REQUEST_METHOD} ); - $request->secure( $env->{'psgi.url_scheme'} eq 'https' ); + $request->secure( $env->{'psgi.url_scheme'} eq 'https' ? 1 : 0 ); return; } @@ -518,7 +521,7 @@ sub prepare_path { # set the request URI my $req_uri = $env->{REQUEST_URI}; $req_uri =~ s/\?.*$//; - my $path = $self->unescape_uri($req_uri); + my $path = $req_uri; $path =~ s{^/+}{}; # Using URI directly is way too slow, so we construct the URLs manually @@ -531,14 +534,10 @@ sub prepare_path { $host .= ":$port"; } - # Escape the path - $path =~ s/([^$URI::uric])/$URI::Escape::escapes{$1}/go; - $path =~ s/\?/%3F/g; # STUPID STUPID SPECIAL CASE - my $query = $env->{QUERY_STRING} ? '?' . $env->{QUERY_STRING} : ''; my $uri = $scheme . '://' . $host . '/' . $path . $query; - $ctx->request->uri( bless \$uri, $uri_class ); + $ctx->request->uri( (bless \$uri, $uri_class)->canonical ); # set the base URI # base must end in a slash @@ -751,9 +750,15 @@ Start the engine. Implemented by the various engine classes. =cut sub run { - my ($self, $app) = @_; + my ($self, $app, $server, @args) = @_; + # FIXME - Do something sensible with the options we're passed + $server->run($self->build_psgi_app($app, @args)); +} - return sub { +sub build_psgi_app { + my ($self, $app, @args) = @_; + + my $psgi_app = sub { my ($env) = @_; return sub { @@ -762,6 +767,18 @@ sub run { $app->handle_request(env => $env); }; }; + + $psgi_app = Plack::Middleware::Conditional->wrap( + $psgi_app, + condition => sub { + my ($env) = @_; + return if $app->config->{ignore_frontend_proxy}; + return $env->{REMOTE_ADDR} eq '127.0.0.1' || $app->config->{using_frontend_proxy}; + }, + builder => sub { Plack::Middleware::ReverseProxy->wrap($_[0]) }, + ); + + return $psgi_app; } =head2 $self->write($c, $buffer)