X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FEngine.pm;h=fa8d9f1c5909684928ecdda7d824ac86e8bb1c7c;hb=b460ad78a952bcaaa8f468d6e578c17002d0645b;hp=4b7fad7a4bf3d4a15bf908e9f2c03e19c761bfb5;hpb=6dc87a0f8301391acfe25ee5bcaad0fe48dad559;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Engine.pm b/lib/Catalyst/Engine.pm index 4b7fad7..fa8d9f1 100644 --- a/lib/Catalyst/Engine.pm +++ b/lib/Catalyst/Engine.pm @@ -9,6 +9,8 @@ use HTML::Entities; use HTTP::Headers; use Memoize; use Time::HiRes qw/gettimeofday tv_interval/; +use Text::ASCIITable; +use Text::ASCIITable::Wrap 'wrap'; use Tree::Simple; use Tree::Simple::Visitor::FindByPath; use Catalyst::Request; @@ -127,15 +129,16 @@ sub execute { my ( $c, $class, $code ) = @_; $class = $c->comp($class) || $class; $c->state(0); + my $callsub = ( caller(1) )[3]; eval { if ( $c->debug ) { my $action = $c->actions->{reverse}->{"$code"}; $action = "/$action" unless $action =~ /\-\>/; + $action = "-> $action" if $callsub =~ /forward$/; my ( $elapsed, @state ) = $c->benchmark( $code, $class, $c, @{ $c->req->args } ); - push @{ $c->{stats} }, - _prettify( $action, sprintf( '%fs', $elapsed ), '' ); + push @{ $c->{stats} }, [ $action, sprintf( '%fs', $elapsed ) ]; $c->state(@state); } else { $c->state( &$code( $class, $c, @{ $c->req->args } ) ) } @@ -161,111 +164,25 @@ sub finalize { $c->finalize_cookies; - if ( my $location = $c->res->redirect ) { + if ( my $location = $c->response->redirect ) { $c->log->debug(qq/Redirecting to "$location"/) if $c->debug; $c->response->header( Location => $location ); - $c->response->status(302); - } - - if ( $c->res->status =~ /^(1\d\d|[23]04)$/ ) { - $c->response->headers->remove_content_headers; - return $c->finalize_headers; - } - - if ( !$c->res->output || $#{ $c->error } >= 0 ) { - $c->res->headers->content_type('text/html'); - my $name = $c->config->{name} || 'Catalyst Application'; - my ( $title, $error, $infos ); - if ( $c->debug ) { - $error = join '
', @{ $c->error }; - $error ||= 'No output'; - $title = $name = "$name on Catalyst $Catalyst::VERSION"; - my $req = encode_entities Dumper $c->req; - my $res = encode_entities Dumper $c->res; - my $stash = encode_entities Dumper $c->stash; - $infos = <<""; -
-Request
-
$req
-Response
-
$res
-Stash
-
$stash
+ $c->response->status(302) if $c->response->status !~ /^3\d\d$/; + } - } - else { - $title = $name; - $error = ''; - $infos = <<""; -
-(en) Please come back later
-(de) Bitte versuchen sie es spaeter nocheinmal
-(nl) Gelieve te komen later terug
-(no) Vennligst prov igjen senere
-(fr) Veuillez revenir plus tard
-(es) Vuelto por favor mas adelante
-(pt) Voltado por favor mais tarde
-(it) Ritornato prego più successivamente
-
+ if ( $#{ $c->error } >= 0 ) { + $c->finalize_error; + } - $name = ''; - } - $c->res->{output} = <<""; - - - $title - - - -
-
$error
-
$infos
-
$name
-
- - + if ( !$c->response->output && $c->response->status !~ /^(1|3)\d\d$/ ) { + $c->finalize_error; + } + if ( $c->response->output && !$c->response->content_length ) { + use bytes; # play safe with a utf8 aware perl + $c->response->content_length( length $c->response->output ); } - $c->res->headers->content_length( length $c->res->output ); + my $status = $c->finalize_headers; $c->finalize_output; return $status; @@ -294,6 +211,109 @@ sub finalize_cookies { } } +=item $c->finalize_error + +Finalize error. + +=cut + +sub finalize_error { + my $c = shift; + + $c->res->headers->content_type('text/html'); + my $name = $c->config->{name} || 'Catalyst Application'; + + my ( $title, $error, $infos ); + if ( $c->debug ) { + $error = join '
', @{ $c->error }; + $error ||= 'No output'; + $title = $name = "$name on Catalyst $Catalyst::VERSION"; + my $req = encode_entities Dumper $c->req; + my $res = encode_entities Dumper $c->res; + my $stash = encode_entities Dumper $c->stash; + $infos = <<""; +
+Request
+
$req
+Response
+
$res
+Stash
+
$stash
+ + } + else { + $title = $name; + $error = ''; + $infos = <<""; +
+(en) Please come back later
+(de) Bitte versuchen sie es spaeter nocheinmal
+(nl) Gelieve te komen later terug
+(no) Vennligst prov igjen senere
+(fr) Veuillez revenir plus tard
+(es) Vuelto por favor mas adelante
+(pt) Voltado por favor mais tarde
+(it) Ritornato prego più successivamente
+
+ + $name = ''; + } + $c->res->output( <<"" ); + + + $title + + + +
+
$error
+
$infos
+
$name
+
+ + + +} + =item $c->finalize_headers Finalize headers. @@ -369,6 +389,7 @@ Get an action in a given namespace. sub get_action { my ( $c, $action, $namespace ) = @_; + return [] unless $action; $namespace ||= ''; if ($namespace) { $namespace = '' if $namespace eq '/'; @@ -440,10 +461,13 @@ sub handler { for my $begin ( @{ $c->get_action( 'begin', $namespace ) } ) { $c->state( $c->execute( @{ $begin->[0] } ) ); } - for my $result ( @{ $c->get_action( $action, $default ) }[-1] ) - { - $c->state( $c->execute( @{ $result->[0] } ) ); - last unless $default; + if ( my $action = $c->req->action ) { + for my $result ( + @{ $c->get_action( $action, $default ) }[-1] ) + { + $c->state( $c->execute( @{ $result->[0] } ) ); + last unless $default; + } } for my $end ( reverse @{ $c->get_action( 'end', $namespace ) } ) { @@ -465,7 +489,16 @@ sub handler { ( $elapsed, $status ) = $class->benchmark($handler); $elapsed = sprintf '%f', $elapsed; my $av = sprintf '%.3f', 1 / $elapsed; - $class->log->info( "Request took $elapsed" . "s ($av/s)", @stats ); + my $t = Text::ASCIITable->new; + $t->setCols( 'Action', 'Time' ); + $t->setColWidth( 'Action', 64, 1 ); + $t->setColWidth( 'Time', 9, 1 ); + + for my $stat (@stats) { + $t->addRow( wrap( $stat->[0], 64 ), wrap( $stat->[1], 9 ) ); + } + $class->log->info( "Request took $elapsed" . "s ($av/s)", + $t->draw ); } else { $status = &$handler } }; @@ -506,9 +539,9 @@ sub prepare { if ( $c->debug ) { my $secs = time - $START || 1; my $av = sprintf '%.3f', $COUNT / $secs; - $c->log->debug('********************************'); + $c->log->debug('**********************************'); $c->log->debug("* Request $COUNT ($av/s) [$$]"); - $c->log->debug('********************************'); + $c->log->debug('**********************************'); $c->res->headers->header( 'X-Catalyst' => $Catalyst::VERSION ); } $c->prepare_request($r); @@ -526,12 +559,15 @@ sub prepare { $c->prepare_parameters; if ( $c->debug && keys %{ $c->req->params } ) { - my @params; + my $t = Text::ASCIITable->new; + $t->setCols( 'Key', 'Value' ); + $t->setColWidth( 'Key', 37, 1 ); + $t->setColWidth( 'Value', 36, 1 ); for my $key ( keys %{ $c->req->params } ) { my $value = $c->req->params->{$key} || ''; - push @params, " $key=$value"; + $t->addRow( wrap( $key, 37 ), wrap( $value, 36 ) ); } - $c->log->debug( 'Parameters are', @params ); + $c->log->debug( 'Parameters are', $t->draw ); } $c->prepare_uploads; return $c; @@ -556,7 +592,8 @@ sub prepare_action { if ($#$result) { my $match = $result->[1]; my @snippets = @{ $result->[2] }; - $c->log->debug(qq/Requested action "$path" matched "$match"/) + $c->log->debug( + qq/Requested action is "$path" and matched "$match"/) if $c->debug; $c->log->debug( 'Snippets are "' . join( ' ', @snippets ) . '"' ) @@ -566,7 +603,7 @@ sub prepare_action { } else { $c->req->action($path); - $c->log->debug(qq/Requested action "$path"/) if $c->debug; + $c->log->debug(qq/Requested action is "$path"/) if $c->debug; } $c->req->match($path); last; @@ -825,38 +862,59 @@ sub setup_components { $self->components->{ ref $comp } = $comp; $self->setup_actions($comp); } - my @comps; - push @comps, " $_" for keys %{ $self->components }; - $self->log->debug( 'Loaded components', @comps ) - if ( @comps && $self->debug ); + my $t = Text::ASCIITable->new({ hide_HeadRow => 1, hide_HeadLine => 1}); + $t->setCols('Class'); + $t->setColWidth( 'Class', 75, 1 ); + $t->addRow( wrap( $_, 75 ) ) for keys %{ $self->components }; + $self->log->debug( 'Loaded components', $t->draw ) + if ( @{ $t->{tbl_rows} } && $self->debug ); my $actions = $self->actions; - my @messages = ('Loaded private actions'); - my $walker = sub { - my ( $walker, $parent, $messages, $prefix ) = @_; + my $privates = Text::ASCIITable->new; + $privates->setCols( 'Private', 'Class', 'Code' ); + $privates->setColWidth( 'Private', 28, 1 ); + $privates->setColWidth( 'Class', 28, 1 ); + $privates->setColWidth( 'Code', 14, 1 ); + my $walker = sub { + my ( $walker, $parent, $prefix ) = @_; $prefix .= $parent->getNodeValue || ''; $prefix .= '/' unless $prefix =~ /\/$/; my $uid = $parent->getUID; for my $action ( keys %{ $actions->{private}->{$uid} } ) { my ( $class, $code ) = @{ $actions->{private}->{$uid}->{$action} }; - push @$messages, _prettify( "$prefix$action", $class, $code ); + $privates->addRow( + wrap( "$prefix$action", 28 ), + wrap( $class, 28 ), + wrap( $code, 14 ) + ); } - $walker->( $walker, $_, $messages, $prefix ) - for $parent->getAllChildren; + $walker->( $walker, $_, $prefix ) for $parent->getAllChildren; }; - $walker->( $walker, $self->tree, \@messages, '' ); - $self->log->debug(@messages) if ( $#messages && $self->debug ); - @messages = ('Loaded plain actions'); + $walker->( $walker, $self->tree, '' ); + $self->log->debug( 'Loaded private actions', $privates->draw ) + if ( @{ $privates->{tbl_rows} } && $self->debug ); + my $publics = Text::ASCIITable->new; + $publics->setCols( 'Public', 'Private' ); + $publics->setColWidth( 'Public', 37, 1 ); + $publics->setColWidth( 'Private', 36, 1 ); + for my $plain ( sort keys %{ $actions->{plain} } ) { my ( $class, $code ) = @{ $actions->{plain}->{$plain} }; - push @messages, _prettify( "/$plain", $class, $code ); - } - $self->log->debug(@messages) if ( $#messages && $self->debug ); - @messages = ('Loaded regex actions'); + $publics->addRow( wrap( "/$plain", 37 ), + wrap( $self->actions->{reverse}->{$code} || $code, 36 ) ); + } + $self->log->debug( 'Loaded public actions', $publics->draw ) + if ( @{ $publics->{tbl_rows} } && $self->debug ); + my $regexes = Text::ASCIITable->new; + $regexes->setCols( 'Regex', 'Private' ); + $regexes->setColWidth( 'Regex', 37, 1 ); + $regexes->setColWidth( 'Private', 36, 1 ); for my $regex ( sort keys %{ $actions->{regex} } ) { my ( $class, $code ) = @{ $actions->{regex}->{$regex} }; - push @messages, _prettify( $regex, $class, $code ); + $regexes->addRow( wrap( $regex, 37 ), + wrap( $self->actions->{reverse}->{$class} || $class, 36 ) ); } - $self->log->debug(@messages) if ( $#messages && $self->debug ); + $self->log->debug( 'Loaded regex actions', $regexes->draw ) + if ( @{ $regexes->{tbl_rows} } && $self->debug ); } =item $c->stash @@ -896,16 +954,6 @@ sub _class2prefix { return $prefix; } -sub _prettify { - my ( $val1, $val2, $val3 ) = @_; - formline -' @<<<<<<<<<<<<<<<<<<<<<<<<<<<<< @<<<<<<<<<<<<<<<<<<<<<<<<<<<< @>>>>>>>>>>>>>> ', - $val1, $val2, $val3; - my $formatted = $^A; - $^A = ''; - return $formatted; -} - =back =head1 AUTHOR