X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FEngine.pm;h=ba606ba95cdc9d8e8b35f396358d30c01dad0dcd;hb=c2fef52fe310a9111756a2878500c6b11e7dbefb;hp=2a1ed8728f64399da17988528f3cbd2e24e90836;hpb=bd822b43dc37efc75451d0f784afb329c173a0d6;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Engine.pm b/lib/Catalyst/Engine.pm index 2a1ed87..ba606ba 100644 --- a/lib/Catalyst/Engine.pm +++ b/lib/Catalyst/Engine.pm @@ -492,7 +492,10 @@ sub prepare_query_parameters { my $env = $c->request->env; if(my $query_obj = $env->{'plack.request.query'}) { - $c->request->query_parameters($query_obj->as_hashref_mixed); + $c->request->query_parameters( + $c->request->_use_hash_multivalue ? + $query_obj->clone : + $query_obj->as_hashref_mixed); return; } @@ -504,10 +507,6 @@ sub prepare_query_parameters { # (yes, index() is faster than a regex :)) if ( index( $query_string, '=' ) < 0 ) { $c->request->query_keywords($self->unescape_uri($query_string)); - $env->{'plack.request.query'} ||= Hash::MultiValue->new( - map { (URI::Escape::uri_unescape($_), '') } - split(/\+/, $query_string, -1)); - return; } @@ -539,8 +538,10 @@ sub prepare_query_parameters { } } - $env->{'plack.request.query'} ||= Hash::MultiValue->from_mixed(\%query); - $c->request->query_parameters( \%query ); + $c->request->query_parameters( + $c->request->_use_hash_multivalue ? + Hash::MultiValue->from_mixed(\%query) : + \%query); } =head2 $self->prepare_read($c) @@ -582,7 +583,6 @@ sub prepare_uploads { my $uploads = $request->_body->upload; my $parameters = $request->parameters; - my @plack_uploads; foreach my $name (keys %$uploads) { my $files = $uploads->{$name}; my @uploads; @@ -597,14 +597,9 @@ sub prepare_uploads { filename => $upload->{filename}, ); push @uploads, $u; - - # Plack compatibility. - my %copy = (%$upload, headers=>$headers); - push @plack_uploads, $name, Plack::Request::Upload->new(%copy); } $request->uploads->{$name} = @uploads > 1 ? \@uploads : $uploads[0]; - # support access to the filename as a normal param my @filenames = map { $_->{filename} } @uploads; # append, if there's already params with this name @@ -620,8 +615,6 @@ sub prepare_uploads { $parameters->{$name} = @filenames > 1 ? \@filenames : $filenames[0]; } } - - $self->env->{'plack.request.upload'} ||= Hash::MultiValue->new(@plack_uploads); } =head2 $self->write($c, $buffer)