X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FEngine.pm;h=969021b5d7d5c067552dee1d7a51eb86964f1253;hb=d41516b29b729ba98759cc98b0ad38a47bad9aa5;hp=d46fb31ff6c5e7e0365c8ec9b9c4d6acc76e8643;hpb=fee92828f66a304afab694e88b0f6c9add49c5c0;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Engine.pm b/lib/Catalyst/Engine.pm index d46fb31..969021b 100644 --- a/lib/Catalyst/Engine.pm +++ b/lib/Catalyst/Engine.pm @@ -357,9 +357,10 @@ sub handler ($$) { # Always expect worst case! my $status = -1; eval { + my @stats = (); my $handler = sub { my $c = $class->prepare($r); - $c->{stats} = []; + $c->{stats} = \@stats; my $action = $c->req->action; my $namespace = ''; $namespace = ( join( '/', @{ $c->req->args } ) || '/' ) @@ -385,9 +386,6 @@ sub handler ($$) { { $c->state( $c->execute( @{ $end->[0] } ) ); } - my @stats = @{ $c->{stats} }; - $c->log->debug( 'Processed', @stats ) - if ( @stats && $c->debug ); } else { my $path = $c->req->path; @@ -404,7 +402,7 @@ sub handler ($$) { ( $elapsed, $status ) = $class->benchmark($handler); $elapsed = sprintf '%f', $elapsed; my $av = sprintf '%.3f', 1 / $elapsed; - $class->log->info( "Request took $elapsed" . "s ($av/s)" ); + $class->log->info( "Request took $elapsed" . "s ($av/s)", @stats ); } else { $status = &$handler } }; @@ -468,9 +466,9 @@ sub prepare { my @params; for my $key ( keys %{ $c->req->params } ) { my $value = $c->req->params->{$key} || ''; - push @params, " $key=$value"; + push @params, " $key=$value"; } - $c->log->debug( 'Parameters', @params ); + $c->log->debug( 'Parameters are', @params ); } $c->prepare_uploads; return $c; @@ -595,7 +593,7 @@ sub execute { my ( $elapsed, @state ) = $c->benchmark( $code, $class, $c, @{ $c->req->args } ); push @{ $c->{stats} }, - _prettify( $action, sprintf( '%fs', $elapsed ), '' ); + _prettify( $action, '', sprintf( '%fs', $elapsed ) ); $c->state(@state); } else { $c->state( &$code( $class, $c, @{ $c->req->args } ) ) } @@ -793,7 +791,7 @@ sub setup_components { $self->setup_actions($comp); } my @comps; - push @comps, " $_" for keys %{ $self->components }; + push @comps, " $_" for keys %{ $self->components }; $self->log->debug( 'Loaded components', @comps ) if ( @comps && $self->debug ); my $actions = $self->actions; @@ -866,7 +864,7 @@ sub _class2prefix { sub _prettify { my ( $val1, $val2, $val3 ) = @_; formline -' @<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< @<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< @>>>>>>>>>>>>>> ', +' @<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< @<<<<<<<<<<<<<<<<<<<<<<<<<<<< @>>>>>>>>>>>>>> ', $val1, $val2, $val3; my $formatted = $^A; $^A = '';