X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FEngine.pm;h=7a98187f01a5a90111a1ff4e3f50a4022bfda13b;hb=913c51dcda37794ec2753f05abb90336c5b4dd46;hp=29a2188489c19bb9614f1e4cc0f2bf6c6de27d11;hpb=4904ee278992db70da965b94627728085b88de54;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Engine.pm b/lib/Catalyst/Engine.pm index 29a2188..7a98187 100644 --- a/lib/Catalyst/Engine.pm +++ b/lib/Catalyst/Engine.pm @@ -14,6 +14,8 @@ use Moose::Util::TypeConstraints; use Plack::Loader; use Plack::Middleware::Conditional; use Plack::Middleware::ReverseProxy; +use Encode (); +use utf8; use namespace::clean -except => 'meta'; @@ -155,6 +157,14 @@ sub finalize_error { $c->res->content_type('text/html; charset=utf-8'); my $name = ref($c)->config->{name} || join(' ', split('::', ref $c)); + + # Prevent Catalyst::Plugin::Unicode::Encoding from running. + # This is a little nasty, but it's the best way to be clean whether or + # not the user has an encoding plugin. + + if ($c->can('encoding')) { + $c->{encoding} = ''; + } my ( $title, $error, $infos ); if ( $c->debug ) { @@ -303,11 +313,12 @@ sub finalize_error { - # Trick IE. Old versions of IE would display their own error page instead # of ours if we'd give it less than 512 bytes. $c->res->{body} .= ( ' ' x 512 ); + $c->res->{body} = Encode::encode("UTF-8", $c->res->{body}); + # Return 500 $c->res->status(500); } @@ -769,13 +780,12 @@ run method on the server passed in.. =cut sub run { - my ($self, $app, @args) = @_; + my ($self, $app, $psgi, @args) = @_; + # FIXME - Do something sensible with the options we're passed my $server = pop @args if blessed $args[-1]; $server ||= Plack::Loader->auto(); # We're not being called from a script, # so auto detect what backend to run on. # This does *NOT* cover mod_perl. - # FIXME - Do something sensible with the options we're passed - my $psgi = $self->build_psgi_app($app, @args); $server->run($psgi); } @@ -801,12 +811,12 @@ sub build_psgi_app { $psgi_app = Plack::Middleware::Conditional->wrap( $psgi_app, + builder => sub { Plack::Middleware::ReverseProxy->wrap($_[0]) }, condition => sub { my ($env) = @_; return if $app->config->{ignore_frontend_proxy}; return $env->{REMOTE_ADDR} eq '127.0.0.1' || $app->config->{using_frontend_proxy}; }, - builder => sub { Plack::Middleware::ReverseProxy->wrap($_[0]) }, ); return $psgi_app;