X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FEngine.pm;h=56e5b1d259676a7fd0c132d7b1abb0c8b17e17b1;hb=08680694151;hp=d48d9a4ef1faf3e29208199fb7047ef4cf31e8da;hpb=8a3dcb987d47c13e0665cb975658df8c88442d7e;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Engine.pm b/lib/Catalyst/Engine.pm index d48d9a4..56e5b1d 100644 --- a/lib/Catalyst/Engine.pm +++ b/lib/Catalyst/Engine.pm @@ -22,25 +22,6 @@ use namespace::clean -except => 'meta'; # Amount of data to read from input on each pass our $CHUNKSIZE = 64 * 1024; -# XXX - this is only here for compat, do not use! -has env => ( is => 'rw', writer => '_set_env' ); -my $WARN_ABOUT_ENV = 0; -around env => sub { - my ($orig, $self, @args) = @_; - if(@args) { - warn "env as a writer is deprecated, you probably need to upgrade Catalyst::Engine::PSGI" - unless $WARN_ABOUT_ENV++; - return $self->_set_env(@args); - } - return $self->$orig; -}; - -# XXX - Only here for Engine::PSGI compat -sub prepare_connection { - my ($self, $ctx) = @_; - $ctx->request->prepare_connection; -} - =head1 NAME Catalyst::Engine - The Catalyst Engine @@ -162,6 +143,11 @@ sub finalize_body { close $body; } else { + + # Case where body was set afgter calling ->write. We'd prefer not to + # support this, but I can see some use cases with the way most of the + # views work. + $self->write($c, $body ); } } @@ -300,6 +286,7 @@ sub finalize_error { (pt) Por favor volte mais tarde (ru) Попробуйте еще раз позже (ua) Спробуйте ще раз пізніше +(it) Per favore riprova più tardi $name = ''; @@ -648,7 +635,6 @@ sub prepare_request { my ($self, $ctx, %args) = @_; $ctx->log->psgienv($args{env}) if $ctx->log->can('psgienv'); $ctx->request->_set_env($args{env}); - $self->_set_env($args{env}); # Nasty back compat! $ctx->response->_set_response_cb($args{response_cb}); }