X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FEngine.pm;h=3879058f3e36351e5edf9234af69b40e06d10c08;hb=10dd68969b311a61e17dd130373909f2c7aaeb93;hp=691bd675e00ba5701cffa665f0fed7b9db0ff5b5;hpb=a2f2cde95194a17fe2401ae58c92b5494bac599f;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Engine.pm b/lib/Catalyst/Engine.pm index 691bd67..3879058 100644 --- a/lib/Catalyst/Engine.pm +++ b/lib/Catalyst/Engine.pm @@ -16,8 +16,6 @@ use Catalyst::Request::Upload; use Catalyst::Response; use Catalyst::Utils; -require Module::Pluggable::Fast; - # For pretty dumps $Data::Dumper::Terse = 1; @@ -418,8 +416,7 @@ sub handler { $t->setColWidth( 'Time', 9, 1 ); for my $stat (@stats) { $t->addRow( $stat->[0], $stat->[1] ) } - $class->log->info( "Request took $elapsed" . "s ($av/s)", - $t->draw ); + $class->log->info( "Request took ${elapsed}s ($av/s)\n" . $t->draw ); } else { $status = &$handler } @@ -521,7 +518,7 @@ sub prepare { my $value = defined($param) ? $param : ''; $t->addRow( $key, $value ); } - $c->log->debug( 'Parameters are', $t->draw ); + $c->log->debug( "Parameters are:\n" . $t->draw ); } return $c; @@ -671,105 +668,6 @@ Returns a C object. my $res = $c->res; -=item $class->setup - -Setup. - - MyApp->setup; - -=cut - -sub setup { - my $self = shift; - - # Initialize our data structure - $self->components( {} ); - - $self->setup_components; - - if ( $self->debug ) { - my $t = Text::ASCIITable->new; - $t->setOptions( 'hide_HeadRow', 1 ); - $t->setOptions( 'hide_HeadLine', 1 ); - $t->setCols('Class'); - $t->setColWidth( 'Class', 75, 1 ); - $t->addRow($_) for sort keys %{ $self->components }; - $self->log->debug( 'Loaded components', $t->draw ) - if ( @{ $t->{tbl_rows} } ); - } - - # Add our self to components, since we are also a component - $self->components->{$self} = $self; - - $self->setup_actions; - - if ( $self->debug ) { - my $name = $self->config->{name} || 'Application'; - $self->log->info("$name powered by Catalyst $Catalyst::VERSION"); - } -} - -=item $class->setup_components - -Setup components. - -=cut - -sub setup_components { - my $self = shift; - - my $callback = sub { - my ( $component, $context ) = @_; - - unless ( $component->isa('Catalyst::Base') ) { - return $component; - } - - my $suffix = Catalyst::Utils::class2classsuffix($component); - my $config = $self->config->{$suffix} || {}; - - my $instance; - - eval { $instance = $component->new( $context, $config ); }; - - if ( my $error = $@ ) { - - chomp $error; - - Catalyst::Exception->throw( - message => qq/Couldn't instantiate component "$component", "$error"/ - ); - } - - return $instance; - }; - - eval { - Module::Pluggable::Fast->import( - name => '_components', - search => [ - "$self\::Controller", "$self\::C", - "$self\::Model", "$self\::M", - "$self\::View", "$self\::V" - ], - callback => $callback - ); - }; - - if ( my $error = $@ ) { - - chomp $error; - - Catalyst::Exception->throw( - message => qq/Couldn't load components "$error"/ - ); - } - - for my $component ( $self->_components($self) ) { - $self->components->{ ref $component || $component } = $component; - } -} - =item $c->state Contains the return value of the last executed action.