X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FEngine.pm;h=2a1ed8728f64399da17988528f3cbd2e24e90836;hb=4491e0cc34b2be2fc485ad01fbbf51b61fed4c22;hp=e63da832612301a21f18d14c9f0547e65b622b53;hpb=4e6e0ab2246dc09edb7e2731547931fa28021829;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Engine.pm b/lib/Catalyst/Engine.pm index e63da83..2a1ed87 100644 --- a/lib/Catalyst/Engine.pm +++ b/lib/Catalyst/Engine.pm @@ -13,6 +13,8 @@ use URI::QueryParam; use Plack::Loader; use Catalyst::EngineLoader; use Encode (); +use Plack::Request::Upload; +use Hash::MultiValue; use utf8; use namespace::clean -except => 'meta'; @@ -487,8 +489,13 @@ process the query string and extract query parameters. sub prepare_query_parameters { my ($self, $c) = @_; - my $env = $c->request->env; + + if(my $query_obj = $env->{'plack.request.query'}) { + $c->request->query_parameters($query_obj->as_hashref_mixed); + return; + } + my $query_string = exists $env->{QUERY_STRING} ? $env->{QUERY_STRING} : ''; @@ -496,7 +503,11 @@ sub prepare_query_parameters { # Check for keywords (no = signs) # (yes, index() is faster than a regex :)) if ( index( $query_string, '=' ) < 0 ) { - $c->request->query_keywords( $self->unescape_uri($query_string) ); + $c->request->query_keywords($self->unescape_uri($query_string)); + $env->{'plack.request.query'} ||= Hash::MultiValue->new( + map { (URI::Escape::uri_unescape($_), '') } + split(/\+/, $query_string, -1)); + return; } @@ -527,6 +538,8 @@ sub prepare_query_parameters { $query{$param} = $value; } } + + $env->{'plack.request.query'} ||= Hash::MultiValue->from_mixed(\%query); $c->request->query_parameters( \%query ); } @@ -569,6 +582,7 @@ sub prepare_uploads { my $uploads = $request->_body->upload; my $parameters = $request->parameters; + my @plack_uploads; foreach my $name (keys %$uploads) { my $files = $uploads->{$name}; my @uploads; @@ -583,9 +597,14 @@ sub prepare_uploads { filename => $upload->{filename}, ); push @uploads, $u; + + # Plack compatibility. + my %copy = (%$upload, headers=>$headers); + push @plack_uploads, $name, Plack::Request::Upload->new(%copy); } $request->uploads->{$name} = @uploads > 1 ? \@uploads : $uploads[0]; + # support access to the filename as a normal param my @filenames = map { $_->{filename} } @uploads; # append, if there's already params with this name @@ -601,6 +620,8 @@ sub prepare_uploads { $parameters->{$name} = @filenames > 1 ? \@filenames : $filenames[0]; } } + + $self->env->{'plack.request.upload'} ||= Hash::MultiValue->new(@plack_uploads); } =head2 $self->write($c, $buffer) @@ -693,7 +714,7 @@ sub build_psgi_app { return sub { my ($respond) = @_; - confess("Did not get a response callback for writer, cannot continiue") unless $respond; + confess("Did not get a response callback for writer, cannot continue") unless $respond; $app->handle_request(env => $env, response_cb => $respond); }; };