X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FEngine%2FCGI.pm;h=fa2e23ed244eae0b773c15e50ec13d0aa7a4b10f;hb=63182b082619eab5ffd56cd03b5825902f42bfdb;hp=d04fea49ecace01f6d13033df65351423b1f1c97;hpb=6f1f968a6bc42bf4a4b50a1ee22d3aaecd801876;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Engine/CGI.pm b/lib/Catalyst/Engine/CGI.pm index d04fea4..fa2e23e 100644 --- a/lib/Catalyst/Engine/CGI.pm +++ b/lib/Catalyst/Engine/CGI.pm @@ -1,13 +1,10 @@ package Catalyst::Engine::CGI; -use MRO::Compat; -use mro 'c3'; use Moose; extends 'Catalyst::Engine'; has env => (is => 'rw'); - -no Moose; +has _header_buf => (is => 'rw', clearer => '_clear_header_buf', predicate => '_has_header_buf'); =head1 NAME @@ -45,8 +42,7 @@ sub finalize_headers { $c->response->header( Status => $c->response->status ); - $self->{_header_buf} - = $c->response->headers->as_string("\015\012") . "\015\012"; + $self->_header_buf($c->response->headers->as_string("\015\012") . "\015\012"); } =head2 $self->prepare_connection($c) @@ -74,7 +70,7 @@ sub prepare_connection { $request->address($ip); } - $request->hostname( $ENV{REMOTE_HOST} ); + $request->hostname( $ENV{REMOTE_HOST} ) if exists $ENV{REMOTE_HOST}; $request->protocol( $ENV{SERVER_PROTOCOL} ); $request->user( $ENV{REMOTE_USER} ); $request->method( $ENV{REQUEST_METHOD} ); @@ -176,14 +172,15 @@ sub prepare_path { =cut -sub prepare_query_parameters { +around prepare_query_parameters => sub { + my $orig = shift; my ( $self, $c ) = @_; local (*ENV) = $self->env || \%ENV; if ( $ENV{QUERY_STRING} ) { - $self->next::method( $c, $ENV{QUERY_STRING} ); + $self->$orig( $c, $ENV{QUERY_STRING} ); } -} +}; =head2 $self->prepare_request($c, (env => \%env)) @@ -203,10 +200,10 @@ Enable autoflush on the output handle for CGI-based engines. =cut -sub prepare_write { +around prepare_write => sub { *STDOUT->autoflush(1); - return shift->next::method(@_); -} + return shift->(@_); +}; =head2 $self->write($c, $buffer) @@ -214,16 +211,17 @@ Writes the buffer to the client. =cut -sub write { +around write => sub { + my $orig = shift; my ( $self, $c, $buffer ) = @_; # Prepend the headers if they have not yet been sent - if ( my $headers = delete $self->{_header_buf} ) { - $buffer = $headers . $buffer; + if ( $self->_has_header_buf ) { + $buffer = $self->_clear_header_buf . $buffer; } - return $self->next::method( $c, $buffer ); -} + return $self->$orig( $c, $buffer ); +}; =head2 $self->read_chunk($c, $buffer, $length) @@ -239,15 +237,11 @@ sub run { shift; shift->handle_request(@_) } =head1 SEE ALSO -L L. +L, L =head1 AUTHORS -Sebastian Riedel, - -Christian Hansen, - -Andy Grundman, +Catalyst Contributors, see Catalyst.pm =head1 COPYRIGHT @@ -255,5 +249,6 @@ This program is free software, you can redistribute it and/or modify it under the same terms as Perl itself. =cut +no Moose; 1;