X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FDispatcher.pm;h=defe7e336413239c37a48ce3e0d73de46c22ced8;hb=be45468751eff3913bbed8a8edc6aa853619adc7;hp=cea54930c3885deed97c01bfd1cbd9e5a37fdeae;hpb=ab9905826d4ed911fefc3c89e6026d2a35d79cba;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Dispatcher.pm b/lib/Catalyst/Dispatcher.pm index cea5493..defe7e3 100644 --- a/lib/Catalyst/Dispatcher.pm +++ b/lib/Catalyst/Dispatcher.pm @@ -2,7 +2,7 @@ package Catalyst::Dispatcher; use Moose; use Class::MOP; -with 'MooseX::Emulate::Class::Accessor::Fast' => { excludes => [ 'BUILD' ] }; +with 'MooseX::Emulate::Class::Accessor::Fast'; use Catalyst::Exception; use Catalyst::Utils; @@ -15,6 +15,7 @@ use Text::SimpleTable; use Tree::Simple; use Tree::Simple::Visitor::FindByPath; +use namespace::clean -except => 'meta'; # Refactoring note: # do these belong as package vars or should we build these via a builder method? @@ -27,7 +28,7 @@ our @PRELOAD = qw/Index Path Regex/; our @POSTLOAD = qw/Default/; # Note - see back-compat methods at end of file. -has _tree => (is => 'rw'); +has _tree => (is => 'rw', builder => '_build__tree'); has _dispatch_types => (is => 'rw', default => sub { [] }, required => 1, lazy => 1); has _registered_dispatch_types => (is => 'rw', default => sub { {} }, required => 1, lazy => 1); has _method_action_class => (is => 'rw', default => 'Catalyst::Action'); @@ -45,8 +46,6 @@ around qw/preload_dispatch_types postload_dispatch_types/ => sub { return $self->$orig(@_); }; -no Moose; - =head1 NAME Catalyst::Dispatcher - The Catalyst Dispatcher @@ -68,13 +67,13 @@ Construct a new dispatcher. =cut -sub BUILD { - my ($self, $params) = @_; +sub _build__tree { + my ($self) = @_; my $container = Catalyst::ActionContainer->new( { part => '/', actions => {} } ); - $self->_tree( Tree::Simple->new( $container, Tree::Simple->ROOT ) ); + return Tree::Simple->new($container, Tree::Simple->ROOT); } =head2 $self->preload_dispatch_types @@ -709,16 +708,15 @@ foreach my $public_method_name (qw/ # I haven't provided a way to disable them, patches welcome. $meta->add_before_method_modifier($public_method_name, sub { my $class = blessed(shift); - $package_hash{$class}++ || do { + $package_hash{$class}++ || do { warn("Class $class is calling the deprecated method Catalyst::Dispatcher::$public_method_name,\n" - . "this will be removed in Catalyst 5.9X"); + . "this will be removed in Catalyst 5.9X\n"); }; }); } } # End 5.70 backwards compatibility hacks. -no Moose; __PACKAGE__->meta->make_immutable; =head2 meta