X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FDispatcher.pm;h=ac641a95dddef741bd62586ff3ed5ec43f80c20e;hb=2e4a6ec399b96865713c7e08c8dcb10dbd7ec5da;hp=35f129fef8f167028df02383cbff5b2caf0ab780;hpb=7101bd1f9d86faa21526f6601dbdb401c679501c;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Dispatcher.pm b/lib/Catalyst/Dispatcher.pm index 35f129f..ac641a9 100644 --- a/lib/Catalyst/Dispatcher.pm +++ b/lib/Catalyst/Dispatcher.pm @@ -17,7 +17,7 @@ use overload '""' => sub { return ref shift }, fallback => 1; __PACKAGE__->mk_accessors( qw/tree dispatch_types registered_dispatch_types - method_action_class action_container_class reserved_actions/ + method_action_class action_container_class/ ); # Preload these action types @@ -26,9 +26,6 @@ our @PRELOAD = qw/Path Regex/; # Postload these action types our @POSTLOAD = qw/Index Default/; -# Reserved action names -our @RESERVED = qw/begin auto default index end/; - =head1 NAME Catalyst::Dispatcher - The Catalyst Dispatcher @@ -41,9 +38,7 @@ See L. =head1 METHODS -=over 4 - -=item $self->detach( $c, $command [, \@arguments ] ) +=head2 $self->detach( $c, $command [, \@arguments ] ) =cut @@ -53,13 +48,12 @@ sub detach { die $Catalyst::DETACH; } -=item $self->dispatch($c) +=head2 $self->dispatch($c) =cut sub dispatch { my ( $self, $c ) = @_; - if ( $c->action ) { $c->forward( join( '/', '', $c->action->namespace, '_DISPATCH' ) ); } @@ -74,7 +68,7 @@ sub dispatch { } } -=item $self->forward( $c, $command [, \@arguments ] ) +=head2 $self->forward( $c, $command [, \@arguments ] ) =cut @@ -172,7 +166,7 @@ qq/Couldn't forward to command "$command". Invalid action or component./; return $c->state; } -=item $self->prepare_action($c) +=head2 $self->prepare_action($c) =cut @@ -207,7 +201,7 @@ sub prepare_action { if ( $c->debug && @args ); } -=item $self->get_action( $action, $namespace ) +=head2 $self->get_action( $action, $namespace ) =cut @@ -226,7 +220,7 @@ sub get_action { } } -=item $self->get_actions( $c, $action, $namespace ) +=head2 $self->get_actions( $c, $action, $namespace ) =cut @@ -241,7 +235,7 @@ sub get_actions { return map { $_->get_action($action) } @match; } -=item $self->get_containers( $namespace ) +=head2 $self->get_containers( $namespace ) =cut @@ -283,7 +277,7 @@ sub get_containers { return map { $_->getNodeValue } @match; } -=item $self->register( $c, $action ) +=head2 $self->register( $c, $action ) =cut @@ -303,18 +297,10 @@ sub register { } } - # Check if action name is reserved - my $reserved = 0; - for my $name ( @{ $self->reserved_actions } ) { - $reserved++ if $action->name eq $name; - } - # Pass the action to our dispatch types so they can register it if reqd. - my $reg = $reserved; - unless ($reserved) { - foreach my $type ( @{ $self->dispatch_types } ) { - $reg++ if $type->register( $c, $action ); - } + my $reg = 0; + foreach my $type ( @{ $self->dispatch_types } ) { + $reg++ if $type->register( $c, $action ); } return unless $reg + $priv; @@ -351,7 +337,7 @@ sub register { $parent->getNodeValue->actions->{ $action->name } = $action; } -=item $self->setup_actions( $class, $component ) +=head2 $self->setup_actions( $class, $component ) =cut @@ -360,7 +346,6 @@ sub setup_actions { $self->dispatch_types( [] ); $self->registered_dispatch_types( {} ); - $self->reserved_actions( \@RESERVED ); $self->method_action_class('Catalyst::Action'); $self->action_container_class('Catalyst::ActionContainer'); @@ -427,8 +412,6 @@ sub setup_actions { $_->list($c) for @{ $self->dispatch_types }; } -=back - =head1 AUTHOR Sebastian Riedel, C