X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FDispatcher.pm;h=a3efc6efbb840fa87e694a350c461e6d067e8deb;hb=c8d9780f82693f5cefced14ecaa5445c0e22b9ca;hp=18ddc4bcb8546a1c4c9444ff52896858a6f6b59f;hpb=5d68b17be4061c87f93f9c53226cb53d4597eff2;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Dispatcher.pm b/lib/Catalyst/Dispatcher.pm index 18ddc4b..a3efc6e 100644 --- a/lib/Catalyst/Dispatcher.pm +++ b/lib/Catalyst/Dispatcher.pm @@ -264,54 +264,43 @@ sub get_action { $inherit ||= 0; if ($namespace) { - $namespace = '' if $namespace eq '/'; + my $parent = $self->tree; - my @results; + my @match; + + if ($namespace ne '/') { - if ($inherit) { - my $result = - $self->actions->{private}->{ $parent->getUID }->{$action}; - push @results, [$result] if $result; my $visitor = Tree::Simple::Visitor::FindByPath->new; + my @path = split('/', $namespace); + $visitor->setSearchPath( @path ); + $parent->accept($visitor); - SEARCH: - for my $part ( split '/', $namespace ) { - $visitor->setSearchPath($part); - $parent->accept($visitor); - my $child = $visitor->getResult; - my $uid = $child->getUID if $child; - my $match = $self->actions->{private}->{$uid}->{$action} - if $uid; - push @results, [$match] if $match; - if ($child) { - $parent = $child; - } - else { - last SEARCH; + if ($inherit) { + + @match = $visitor->getResults; + @match = ($parent) unless @match; + + if (!defined $visitor->getResult) { + my $extra = $path[(scalar @match) - 1]; + last unless $extra; + $visitor->setSearchPath($extra); + $match[-1]->accept($visitor); + push(@match, $visitor->getResult) if defined $visitor->getResult; } + } else { + @match = ($visitor->getResult) if $visitor->getResult; } } - else { - - if ($namespace) { - my $visitor = Tree::Simple::Visitor::FindByPath->new; - $visitor->setSearchPath( split '/', $namespace ); - $parent->accept($visitor); - my $child = $visitor->getResult; - my $uid = $child->getUID if $child; - my $match = $self->actions->{private}->{$uid}->{$action} - if $uid; - push @results, [$match] if $match; - } + @match = ($parent) unless @match; - else { - my $result = - $self->actions->{private}->{ $parent->getUID }->{$action}; - push @results, [$result] if $result; - } + my @results; + foreach my $child (@match) { + my $node = $self->actions->{private}->{$child->getUID}; + next unless $node; + push(@results, [ $node->{$action} ]) if defined $node->{$action}; } return \@results; }