X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FDispatcher.pm;h=7f201c2c64096c78fe39b702cb216630aebaafa7;hb=b2ddf6d7e1ea8f9b281ce5da27ecadf3152e151d;hp=22bb49ff581e958df0a909f8bb3c049f54c1dd68;hpb=9a6ecf4f8186b42c4c86206b20435c60dc03e012;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Dispatcher.pm b/lib/Catalyst/Dispatcher.pm index 22bb49f..7f201c2 100644 --- a/lib/Catalyst/Dispatcher.pm +++ b/lib/Catalyst/Dispatcher.pm @@ -282,6 +282,8 @@ sub prepare_action { unshift @args, $arg; } + s/%([0-9A-Fa-f]{2})/chr(hex($1))/eg for @{$c->req->captures||[]}; + $c->log->debug( 'Path is "' . $c->req->match . '"' ) if ( $c->debug && $c->req->match ); @@ -372,7 +374,8 @@ sub uri_for_action { $captures ||= []; foreach my $dispatch_type ( @{ $self->dispatch_types } ) { my $uri = $dispatch_type->uri_for_action( $action, $captures ); - return $uri if defined($uri); + return( $uri eq '' ? '/' : $uri ) + if defined($uri); } return undef; } @@ -409,7 +412,7 @@ sub register { my $namespace = $action->namespace; my $name = $action->name; - my $container = $self->find_or_create_action_container($namespace); + my $container = $self->_find_or_create_action_container($namespace); # Set the method value $container->add_action($action); @@ -418,7 +421,7 @@ sub register { $self->container_hash->{$namespace} = $container; } -sub find_or_create_action_container { +sub _find_or_create_action_container { my ( $self, $namespace ) = @_; my $tree ||= $self->tree; @@ -460,14 +463,14 @@ sub setup_actions { $self->action_container_class('Catalyst::ActionContainer'); my @classes = - $self->do_load_dispatch_types( @{ $self->preload_dispatch_types } ); + $self->_load_dispatch_types( @{ $self->preload_dispatch_types } ); @{ $self->registered_dispatch_types }{@classes} = (1) x @classes; foreach my $comp ( values %{ $c->components } ) { $comp->register_actions($c) if $comp->can('register_actions'); } - $self->do_load_dispatch_types( @{ $self->postload_dispatch_types } ); + $self->_load_dispatch_types( @{ $self->postload_dispatch_types } ); return unless $c->debug; @@ -497,14 +500,14 @@ sub setup_actions { }; $walker->( $walker, $self->tree, '' ); - $c->log->debug( "Loaded Private actions:\n" . $privates->draw ) - if ($has_private); + $c->log->debug( "Loaded Private actions:\n" . $privates->draw . "\n" ) + if $has_private; # List all public actions $_->list($c) for @{ $self->dispatch_types }; } -sub do_load_dispatch_types { +sub _load_dispatch_types { my ( $self, @types ) = @_; my @loaded;