X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FController.pm;h=a086eb2b54e104dd4a3342fbb82c48a2921634c8;hb=d0e5dfb535fa8c2488caf7895153d9f31622ca62;hp=548b4a1b7dd4400a32ae18ee46ff01c46e3aa2b5;hpb=028255514f179a452404752e5700d35c5edb3860;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Controller.pm b/lib/Catalyst/Controller.pm index 548b4a1..a086eb2 100644 --- a/lib/Catalyst/Controller.pm +++ b/lib/Catalyst/Controller.pm @@ -44,6 +44,8 @@ sub BUILD { $self->_controller_actions($attr_value); } + + =head1 NAME Catalyst::Controller - Catalyst Controller base class @@ -156,7 +158,7 @@ around action_namespace => sub { } } - my $namespace = Catalyst::Utils::class2prefix(ref($self) || $self, $case_s) || ''; + my $namespace = Catalyst::Utils::class2prefix($self->_component_name, $case_s) || ''; $self->$orig($namespace) if ref($self); return $namespace; }; @@ -178,7 +180,7 @@ around path_prefix => sub { sub get_action_methods { my $self = shift; my $meta = find_meta($self); - confess("Metaclass for " + confess("Metaclass " . ref($meta) . " for " . $meta->name . " cannot support register_actions." ) @@ -189,8 +191,8 @@ sub get_action_methods { push( @methods, map { - $meta->get_method($_) - || confess( 'Action "' + $meta->find_method_by_name($_) + || confess( 'Action "' . $_ . '" is not available from controller ' . ( ref $self ) ) @@ -207,10 +209,15 @@ sub register_actions { sub register_action_methods { my ( $self, $c, @methods ) = @_; - my $class = ref $self || $self; + my $class = $self->_component_name; #this is still not correct for some reason. my $namespace = $self->action_namespace($c); + # Uncomment as soon as you fix the tests :) + #if (!blessed($self) && $self eq $c && scalar(@methods)) { + # $c->log->warn("Action methods found defined in your application class, $self. This is deprecated, please move them into a Root controller."); + #} + foreach my $method (@methods) { my $name = $method->name; my $attributes = $method->attributes;