X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FController.pm;h=99c5f296bef0f28d7ccb853f2583799849f5ecd8;hb=1af5d3fcca93b369a6e37bf0a08df85346b91f47;hp=e1d7d04b8fe2b8f7fdbdf627bb8e2343de049fbe;hpb=f0a9b791be61994ae43bd67398fb7eb4d34ea01d;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Controller.pm b/lib/Catalyst/Controller.pm index e1d7d04..99c5f29 100644 --- a/lib/Catalyst/Controller.pm +++ b/lib/Catalyst/Controller.pm @@ -225,7 +225,9 @@ sub register_action_methods { foreach my $method (@methods) { my $name = $method->name; - my $attributes = $method->attributes; + # Horrible hack! All method metaclasses should have an attributes + # method, core Moose bug - see r13354. + my $attributes = $method->can('attributes') ? $method->attributes : []; my $attrs = $self->_parse_attrs( $c, $name, @{ $attributes } ); if ( $attrs->{Private} && ( keys %$attrs > 1 ) ) { $c->log->debug( 'Bad action definition "' @@ -294,11 +296,6 @@ sub _parse_attrs { } } - #I know that the original behavior was to ignore action if actions was set - # but i actually think this may be a little more sane? we can always remove - # the merge behavior quite easily and go back to having actions have - # presedence over action by modifying the keys. i honestly think this is - # superior while mantaining really high degree of compat my $actions; if( ref($self) ) { $actions = $self->_controller_actions; @@ -541,7 +538,7 @@ and registers them with the dispatcher. =head2 $self->action_class(%args) Used when a controller is creating an action to determine the correct base -action class to use. +action class to use. =head2 $self->create_action(%args)