X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FController.pm;h=18c825968deb622fdadddf5e6f947652658e80ca;hb=b354201608d428db344c63dd35de096a62a7a9d3;hp=9d6a3623cc4740866829aa4c958192653c0311fb;hpb=86b3c7aa8196c8ca521e8c173b22e0ee53520f9c;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Controller.pm b/lib/Catalyst/Controller.pm index 9d6a362..18c8259 100644 --- a/lib/Catalyst/Controller.pm +++ b/lib/Catalyst/Controller.pm @@ -1,13 +1,17 @@ package Catalyst::Controller; -#switch to BEGIN { extends qw/ ... /; } ? -use base qw/Catalyst::Component Catalyst::AttrContainer/; use Moose; +use Moose::Util qw/find_meta/; + +use namespace::clean -except => 'meta'; + +# Note - Must be done at compile time due to attributes (::AttrContainer) +BEGIN { extends qw/Catalyst::Component Catalyst::AttrContainer/; } -use Scalar::Util qw/blessed/; use Catalyst::Exception; use Catalyst::Utils; -use Class::Inspector; + +with 'Catalyst::Component::ApplicationAttribute'; has path_prefix => ( @@ -32,10 +36,6 @@ has actions => init_arg => undef, ); -# isa => 'ClassName|Catalyst' ? -has _application => (is => 'rw'); -sub _app{ shift->_application(@_) } - sub BUILD { my ($self, $args) = @_; my $action = delete $args->{action} || {}; @@ -122,15 +122,6 @@ sub _END : Private { return !@{ $c->error }; } -around new => sub { - my $orig = shift; - my $self = shift; - my $app = $_[0]; - my $new = $self->$orig(@_); - $new->_application( $app ); - return $new; -}; - sub action_for { my ( $self, $name ) = @_; my $app = ($self->isa('Catalyst') ? $self : $self->_application); @@ -190,9 +181,8 @@ sub register_actions { my $class = ref $self || $self; #this is still not correct for some reason. my $namespace = $self->action_namespace($c); - my $meta = $self->meta; + my $meta = find_meta($self); my %methods = map { $_->body => $_->name } - grep { $_->package_name ne 'Moose::Object' } #ignore Moose::Object methods $meta->get_all_methods; # Advanced inheritance support for plugins and the like @@ -399,8 +389,6 @@ sub _parse_MyAction_attr { return ( 'ActionClass', $value ); } -no Moose; - __PACKAGE__->meta->make_immutable; 1;