X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FController%2FCGIBin.pm;h=fa061c7093740ba6b9360d64940f1f5fe857d8d9;hb=7a3e5a11ca57aebc997d0902119ffaab1080c9ea;hp=9bce949eec0876e0919ee7493186a6b45942fc37;hpb=5709e6bdaf32ff9891714906eac638eb5c55aa80;p=catagits%2FCatalyst-Controller-WrapCGI.git

diff --git a/lib/Catalyst/Controller/CGIBin.pm b/lib/Catalyst/Controller/CGIBin.pm
index 9bce949..fa061c7 100644
--- a/lib/Catalyst/Controller/CGIBin.pm
+++ b/lib/Catalyst/Controller/CGIBin.pm
@@ -13,7 +13,9 @@ use IPC::Open3;
 use Symbol 'gensym';
 use List::MoreUtils 'any';
 use IO::File ();
-use Carp;
+use File::Temp 'tempfile';
+use File::pushd;
+#use CGI::Compile;
  
 use namespace::clean -except => 'meta';
 
@@ -23,11 +25,11 @@ Catalyst::Controller::CGIBin - Serve CGIs from root/cgi-bin
 
 =head1 VERSION
 
-Version 0.019
+Version 0.024
 
 =cut
 
-our $VERSION = '0.019';
+our $VERSION = '0.024';
 
 =head1 SYNOPSIS
 
@@ -151,27 +153,17 @@ sub register_actions {
 C<< $self->cgi_action($cgi) >>
 
 Takes a path to a CGI from C<root/cgi-bin> such as C<foo/bar.cgi> and returns
-the action name it is registered as. See L</DESCRIPTION> for a discussion on how
-CGI actions are named.
-
-A path such as C<root/cgi-bin/hlagh/bar.cgi> will get the private path
-C<foo/CGI_hlagh__bar_cgi>, for controller Foo, with the C</>s converted to C<__>
-and prepended with C<CGI_>, as well as all non-word characters converted to
-C<_>s. This is because L<Catalyst> action names can't have non-word characters
-in them.
-
-This means that C<foo/bar.cgi> and C<foo__bar.cgi> for example will both map to
-the action C<CGI_foo__bar_cgi> so B<DON'T DO THAT>.
+the action name it is registered as.
 
 =cut
 
 sub cgi_action {
     my ($self, $cgi) = @_;
 
-    my $action_name = 'CGI_' . join '__' => split '/' => $cgi;
-    $action_name    =~ s/\W/_/g;
+    my $action_name = 'CGI_' . $cgi;
+    $action_name =~ s/([^A-Za-z0-9_])/sprintf("_%2x", unpack("C", $1))/eg;
 
-    $action_name
+    return $action_name;
 }
 
 =head2 cgi_path
@@ -208,18 +200,30 @@ L</wrap_perl_cgi>.
 sub is_perl_cgi {
     my ($self, $cgi) = @_;
 
-    my $shebang = IO::File->new($cgi)->getline;
+    my (undef, $tempfile) = tempfile;
 
-    return 0 if $shebang !~ /perl/ && $cgi !~ /\.pl\z/;
+    my $pid = fork;
+    die "Cannot fork: $!" unless defined $pid;
 
-    my $taint_check = $shebang =~ /-T/ ?  '-T' : '';
+    if ($pid) {
+        waitpid $pid, 0;
+        my $errors = IO::File->new($tempfile)->getline;
+        unlink $tempfile;
+        return $errors ? 0 : 1;
+    }
 
+    # child
+    local *NULL;
     open NULL, '>', File::Spec->devnull;
-    my $pid = open3(gensym, '&>NULL', '&>NULL', "$^X $taint_check -c $cgi");
-    close NULL;
-    waitpid $pid, 0;
+    open STDOUT, '>&', \*NULL;
+    open STDERR, '>&', \*NULL;
+    close STDIN;
+
+    eval { $self->wrap_perl_cgi($cgi, '__DUMMY__') };
 
-    $? >> 8 == 0
+    IO::File->new(">$tempfile")->print($@);
+
+    exit;
 }
 
 =head2 wrap_perl_cgi
@@ -245,10 +249,14 @@ sub wrap_perl_cgi {
     my ($self, $cgi, $action_name) = @_;
 
     my $code = slurp $cgi;
+    my $dir  = File::Basename::dirname($cgi);
 
-    $code =~ s/^__DATA__(?:\r?\n|\r\n?)(.*)//ms;
+    $code =~ s/^__DATA__\n(.*)//ms;
     my $data = $1;
 
+    my $orig_exit = \*CORE::GLOBAL::exit;
+    my %orig_sig  = %SIG;
+
     my $coderef = do {
         no warnings;
         # catch exit() and turn it into (effectively) a return
@@ -256,18 +264,23 @@ sub wrap_perl_cgi {
         # overridden CORE::GLOBAL::exit in view
         #
         # set $0 to the name of the cgi file in case it's used there
-        eval ' 
+        my $source = ' 
             my $cgi_exited = "EXIT\n";
             BEGIN { *CORE::GLOBAL::exit = sub (;$) {
                 die [ $cgi_exited, $_[0] || 0 ];
             } }
             package Catalyst::Controller::CGIBin::_CGIs_::'.$action_name.';
-            sub {'
-                . 'local *DATA;'
-                . q{open DATA, '<', \$data;}
-                . qq{local \$0 = "\Q$cgi\E";}
-                . q/my $rv = eval {/
-                . $code
+            sub {'."\n"
+                . 'local *DATA;'."\n"
+                . q{open DATA, '<', \$data;}."\n"
+                . qq{local \$0 = '$cgi';}."\n"
+                . "my \$_dir = File::pushd::pushd '$dir';"."\n"
+                . "CGI::initialize_globals() "."\n"
+                . "    if defined &CGI::initialize_globals;"."\n"
+                . q/my $rv = eval {/."\n"
+                . 'local %SIG;'."\n"
+                . "#line 1 $cgi"."\n"
+                . $code."\n"
                 . q/};/
                 . q{
                     return $rv unless $@;
@@ -279,13 +292,27 @@ sub wrap_perl_cgi {
                     return $rv;
                 }
          . '}';
+         eval $source;
     };
 
-    croak __PACKAGE__ . ": Could not compile $cgi to coderef: $@" if $@;
+    # clean up
+    *CORE::GLOBAL::exit = $orig_exit;
+    %SIG = %orig_sig;
+
+    die "Could not compile $cgi to coderef: $@" if $@;
 
-    $coderef
+    return $coderef;
 }
 
+# Once CGI::Compile is updated, we can use this:
+
+#sub wrap_perl_cgi {
+#    my ($self, $cgi, $action_name) = @_;
+#
+#    return CGI::Compile->compile($cgi,
+#        "Catalyst::Controller::CGIBin::_CGIs_::$action_name");
+#}
+
 =head2 wrap_nonperl_cgi
 
 C<< $self->wrap_nonperl_cgi($path, $action_name) >>
@@ -311,13 +338,7 @@ __PACKAGE__->meta->make_immutable;
 =head1 SEE ALSO
 
 L<Catalyst::Controller::WrapCGI>, L<CatalystX::GlobalContext>,
-L<Catalyst::Controller>, L<CGI>, L<Catalyst>
-
-=head1 AUTHORS
-
-Rafael Kitover, C<< <rkitover at cpan.org> >>
-
-Hans Dieter Pearcey, C<< <hdp at cpan.org> >>
+L<Catalyst::Controller>, L<CGI>, L<CGI::Compile>, L<Catalyst>
 
 =head1 BUGS
 
@@ -351,9 +372,15 @@ L<http://search.cpan.org/dist/Catalyst-Controller-WrapCGI>
 
 =back
 
+=head1 AUTHOR
+
+See L<Catalyst::Controller::WrapCGI/AUTHOR> and
+L<Catalyst::Controller::WrapCGI/CONTRIBUTORS>.
+
 =head1 COPYRIGHT & LICENSE
 
-Copyright (c) 2008 Rafael Kitover
+Copyright (c) 2008-2009 L<Catalyst::Controller::WrapCGI/AUTHOR> and
+L<Catalyst::Controller::WrapCGI/CONTRIBUTORS>.
 
 This program is free software; you can redistribute it and/or modify it
 under the same terms as Perl itself.