X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FComponent.pm;h=fe0ef6fe3e347bf168dbb1561fe708f3657b1840;hb=b39b4848e504f57e74c06ea46059aa56351c2a11;hp=c065664d5d19c77772a20085671de6e5d4eb836c;hpb=4d38cb074da32815d87f1fb9fe7c03b761fdf15a;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Component.pm b/lib/Catalyst/Component.pm index c065664..fe0ef6f 100644 --- a/lib/Catalyst/Component.pm +++ b/lib/Catalyst/Component.pm @@ -60,7 +60,17 @@ component loader with config() support and a process() method placeholder. __PACKAGE__->mk_classdata('_plugins'); __PACKAGE__->mk_classdata('_config'); -has _component_name => ( is => 'ro' ); +has catalyst_component_name => ( is => 'ro' ); # Cannot be required => 1 as context + # class @ISA component - HATE +# Make accessor callable as a class method, as we need to call setup_actions +# on the application class, which we don't have an instance of, ewwwww +# Also, naughty modules like Catalyst::View::JSON try to write to _everything_, +# so spit a warning, ignore that (and try to do the right thing anyway) here.. +around catalyst_component_name => sub { + my ($orig, $self) = (shift, shift); + Carp::cluck("Tried to write to the catalyst_component_name accessor - is your component broken or just mad? (Write ignored - using default value.)") if scalar @_; + blessed($self) ? $self->$orig() || blessed($self) : $self; +}; sub BUILDARGS { my $class = shift; @@ -103,6 +113,8 @@ sub COMPONENT { sub config { my $self = shift; + # Uncomment once sane to do so + #Carp::cluck("config method called on instance") if ref $self; my $config = $self->_config || {}; if (@_) { my $newconfig = { %{@_ > 1 ? {@_} : $_[0]} }; @@ -172,15 +184,6 @@ something like this: return $class->new($app, $args); } -=head2 _component_name - -The name of the component within an application. This is used to -pass the component's name to actions generated (becoming -C<< $action->class >>). This is needed so that the L method can -return an instance of a different class (e.g. a L anonymous class), -(as finding the component name by C<< ref($self) >> will not work correctly in -such cases). - =head2 $c->config =head2 $c->config($hashref)