X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FComponent.pm;h=c895b45e964c800fa99eb147fb56c90d0aabbc57;hb=f04fdedae056296d0fa97fbdcaa85b9811ca6a5b;hp=9926298d2fef92d0c59a8f41a9d4c927786a4b32;hpb=7cd1a42bb51b6004005cbadc304b3bb5849e2a4f;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Component.pm b/lib/Catalyst/Component.pm index 9926298..c895b45 100644 --- a/lib/Catalyst/Component.pm +++ b/lib/Catalyst/Component.pm @@ -5,6 +5,14 @@ use base qw/Class::Accessor::Fast Class::Data::Inheritable/; use NEXT; use Catalyst::Utils; +BEGIN { + if (eval 'require Moose; 1') { + *__HAVE_MOOSE = sub () { 1 }; + } + else { + *__HAVE_MOOSE = sub () { 0 }; + } +} =head1 NAME @@ -54,13 +62,28 @@ __PACKAGE__->mk_classdata($_) for qw/_config _plugins/; sub new { - my ( $self, $c ) = @_; + my ( $class, $c ) = @_; # Temporary fix, some components does not pass context to constructor my $arguments = ( ref( $_[-1] ) eq 'HASH' ) ? $_[-1] : {}; - return $self->NEXT::new( - $self->merge_config_hashes( $self->config, $arguments ) ); + my $config = $class->merge_config_hashes( $class->config, $arguments ); + + my $self = $class->NEXT::new($config); + + if (__HAVE_MOOSE) { + my $meta = Class::MOP::get_metaclass_by_name($class); + if ($meta) { + $self = $meta->new_object( + __INSTANCE__ => $self, + %$config + ); + # May not inherit from Moose::Object at all, so + # call BUILDALL explicitly. + $self->Moose::Object::BUILDALL($config); + } + } + return $self; } sub COMPONENT { @@ -79,7 +102,7 @@ sub COMPONENT { else { my $class = ref $self || $self; my $new = $self->merge_config_hashes( - $self->config, $arguments ); + $self->config, $arguments ); return bless $new, $class; } } @@ -87,15 +110,29 @@ sub COMPONENT { sub config { my $self = shift; - my $config = $self->_config; - unless ($config) { - $self->_config( $config = {} ); - } + my $config_sub = $self->can('_config'); + my $config = $self->$config_sub() || {}; if (@_) { my $newconfig = { %{@_ > 1 ? {@_} : $_[0]} }; $self->_config( $self->merge_config_hashes( $config, $newconfig ) ); + } else { + # this is a bit of a kludge, required to make + # __PACKAGE__->config->{foo} = 'bar'; + # work in a subclass. Calling the Class::Data::Inheritable setter + # will create a new _config method in the current class if it's + # currently inherited from the superclass. So, the can() call will + # return a different subref in that case and that means we know to + # copy and reset the value stored in the class data. + + $self->_config( $config ); + + if ((my $config_sub_now = $self->can('_config')) ne $config_sub) { + + $config = $self->merge_config_hashes( $config, {} ); + $self->$config_sub_now( $config ); + } } return $config; } @@ -173,15 +210,13 @@ calling code in the application rather than the component itself. L, L, L, L. -=head1 AUTHOR +=head1 AUTHORS -Sebastian Riedel, C -Marcus Ramberg, C -Matt S Trout, C +Catalyst Contributors, see Catalyst.pm =head1 COPYRIGHT This program is free software, you can redistribute it and/or modify it under the same terms as Perl itself. -=cut \ No newline at end of file +=cut