X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FComponent.pm;h=80fc8384b39d16427e07a656185387bbe19839de;hb=b354201608d428db344c63dd35de096a62a7a9d3;hp=68dbcdb929bcfb05fbd68975ec74a299e5af8c07;hpb=11b256bcd8803498376b86ce234ceb4ee6614bd9;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Component.pm b/lib/Catalyst/Component.pm index 68dbcdb..80fc838 100644 --- a/lib/Catalyst/Component.pm +++ b/lib/Catalyst/Component.pm @@ -2,8 +2,9 @@ package Catalyst::Component; use Moose; use Class::MOP; -use MooseX::Adopt::Class::Accessor::Fast; +use Class::MOP::Object; use Catalyst::Utils; +use Class::C3::Adopt::NEXT; use MRO::Compat; use mro 'c3'; @@ -57,17 +58,16 @@ component loader with config() support and a process() method placeholder. __PACKAGE__->mk_classdata('_plugins'); __PACKAGE__->mk_classdata('_config'); -around new => sub { - my ( $orig, $self) = @_; - +sub BUILDARGS { + my ($self) = @_; + # Temporary fix, some components does not pass context to constructor my $arguments = ( ref( $_[-1] ) eq 'HASH' ) ? $_[-1] : {}; my $args = $self->merge_config_hashes( $self->config, $arguments ); - $self->$orig( $args ); -}; - -no Moose; + + return $args; +} sub COMPONENT { my ( $self, $c ) = @_; @@ -77,8 +77,10 @@ sub COMPONENT { if( my $next = $self->next::can ){ my $class = blessed $self || $self; my ($next_package) = Class::MOP::get_code_info($next); - warn "There is a COMPONENT method resolving after Catalyst::Component in ${next_package}. This behavior is deprecated and will stop working in future releases."; - return $next->($self, $arguments); + warn "There is a COMPONENT method resolving after Catalyst::Component in ${next_package}.\n"; + warn "This behavior can no longer be supported, and so your application is probably broken.\n"; + warn "Your linearised isa hierarchy is: " . join(', ', mro::get_linear_isa($class)) . "\n"; + warn "Please see perldoc Catalyst::Upgrading for more information about this issue.\n"; } return $self->new($c, $arguments); } @@ -94,11 +96,10 @@ sub config { } else { # this is a bit of a kludge, required to make # __PACKAGE__->config->{foo} = 'bar'; - # work in a subclass. If we don't have the package symbol in the - # current class we know we need to copy up to ours, which calling - # the setter will do for us. - - unless ($self->meta->has_package_symbol('$_config')) { + # work in a subclass. + my $class = blessed($self) || $self; + my $meta = Class::MOP::get_metaclass_by_name($class); + unless ($meta->has_package_symbol('$_config')) { $config = $self->merge_config_hashes( $config, {} ); $self->_config( $config ); @@ -119,6 +120,7 @@ sub process { . " did not override Catalyst::Component::process" ); } +no Moose; __PACKAGE__->meta->make_immutable; 1; @@ -168,7 +170,7 @@ Alias for the method in L. =head2 ACCEPT_CONTEXT($c, @args) -Catalyst components are normally initalized during server startup, either +Catalyst components are normally initialized during server startup, either as a Class or a Instance. However, some components require information about the current request. To do so, they can implement an ACCEPT_CONTEXT method. @@ -182,11 +184,9 @@ calling code in the application rather than the component itself. L, L, L, L. -=head1 AUTHOR +=head1 AUTHORS -Sebastian Riedel, C -Marcus Ramberg, C -Matt S Trout, C +Catalyst Contributors, see Catalyst.pm =head1 COPYRIGHT