X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FComponent.pm;h=68dbcdb929bcfb05fbd68975ec74a299e5af8c07;hb=11b256bcd8803498376b86ce234ceb4ee6614bd9;hp=a66a7c206653aba4d04e5b987d79eda91dd14708;hpb=76aab9932e14205c81eeb31d811d2a131eede4cf;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Component.pm b/lib/Catalyst/Component.pm index a66a7c2..68dbcdb 100644 --- a/lib/Catalyst/Component.pm +++ b/lib/Catalyst/Component.pm @@ -54,7 +54,8 @@ component loader with config() support and a process() method placeholder. =cut -__PACKAGE__->mk_classdata($_) for qw/_config _plugins/; +__PACKAGE__->mk_classdata('_plugins'); +__PACKAGE__->mk_classdata('_config'); around new => sub { my ( $orig, $self) = @_; @@ -84,12 +85,24 @@ sub COMPONENT { sub config { my $self = shift; - my $config = $self->_config ||{}; + my $config = $self->_config || {}; if (@_) { my $newconfig = { %{@_ > 1 ? {@_} : $_[0]} }; $self->_config( $self->merge_config_hashes( $config, $newconfig ) ); + } else { + # this is a bit of a kludge, required to make + # __PACKAGE__->config->{foo} = 'bar'; + # work in a subclass. If we don't have the package symbol in the + # current class we know we need to copy up to ours, which calling + # the setter will do for us. + + unless ($self->meta->has_package_symbol('$_config')) { + + $config = $self->merge_config_hashes( $config, {} ); + $self->_config( $config ); + } } return $config; } @@ -106,6 +119,8 @@ sub process { . " did not override Catalyst::Component::process" ); } + +__PACKAGE__->meta->make_immutable; 1; __END__