X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FClassData.pm;h=3dde73af36f55da543e11861e94ce61df294b748;hb=11ae73780599395627cb18dc95849ddcb0fce2ae;hp=3882ccd4da4eca0bd47fa290468b1445399a1423;hpb=74c89dead3cfd8e95cbe853adbc6fe9eed539f4e;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/ClassData.pm b/lib/Catalyst/ClassData.pm index 3882ccd..3dde73a 100644 --- a/lib/Catalyst/ClassData.pm +++ b/lib/Catalyst/ClassData.pm @@ -29,6 +29,13 @@ sub mk_classdata { return ${$v}; } else { foreach my $super ( $meta->linearized_isa ) { + # If there is a code symbol for this attr in a parent class, + # then copy it into our package. Is this the correct + # fix for C::D::I back-compat? (t0m) + my $parent_symbol = *{"${super}::${attribute}"}{CODE} ? \&{"${super}::${attribute}"} : undef; + if (defined $parent_symbol) { + *{"${pkg}::${attribute}"} = $parent_symbol; + } # tighter version of same after # my $super_meta = Moose::Meta::Class->initialize($super); my $v = ${"${super}::"}{$attribute} ? *{"${super}::${attribute}"}{SCALAR} : undef; @@ -53,7 +60,7 @@ sub mk_classdata { $meta->add_method($alias, $accessor); $meta->add_method($attribute, $accessor); if(defined $immutable_options){ - $meta->make_immutable($immutable_options); + $meta->make_immutable(%{ $immutable_options }); } $class->$attribute($_[2]) if(@_ > 2); return $accessor;