X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FBase.pm;h=789c6ab9f987b41334456a1761e787f5c9e36946;hb=ab2374d3a68f4d44601813f351b38222822b7c39;hp=94a0f9883c9aea15560e54fb46e7b158837b8c07;hpb=6f4e1683d466d0123cc7507b29a55b474ddca594;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst/Base.pm b/lib/Catalyst/Base.pm index 94a0f98..789c6ab 100644 --- a/lib/Catalyst/Base.pm +++ b/lib/Catalyst/Base.pm @@ -2,9 +2,23 @@ package Catalyst::Base; use strict; use base qw/Class::Data::Inheritable Class::Accessor::Fast/; + +use Catalyst::Exception; use NEXT; -__PACKAGE__->mk_classdata('_config'); +__PACKAGE__->mk_classdata($_) for qw/_attr_cache _action_cache _config/; +__PACKAGE__->_attr_cache( {} ); +__PACKAGE__->_action_cache( [] ); + +# note - see attributes(3pm) +sub MODIFY_CODE_ATTRIBUTES { + my ( $class, $code, @attrs ) = @_; + $class->_attr_cache->{$code} = [@attrs]; + push @{ $class->_action_cache }, [ $code, [@attrs] ]; + return (); +} + +sub FETCH_CODE_ATTRIBUTES { $_[0]->_attr_cache->{ $_[1] } || () } =head1 NAME @@ -33,7 +47,6 @@ Catalyst::Base - Catalyst Universal Base Class # Methods can be a request step $c->forward(qw/MyApp::Model::Something forward_to_me/); - MyApp->action( 'index.html' => \&MyApp::Model::Something::forward_to_me ); # Or just methods print $c->comp('MyApp::Model::Something')->test; @@ -58,7 +71,11 @@ component loader with config() support and a process() method placeholder. sub new { my ( $self, $c ) = @_; - return $self->NEXT::new( $self->config ); + + # Temporary fix, some components does not pass context to constructor + my $arguments = ( ref( $_[-1] ) eq 'HASH' ) ? $_[-1] : {}; + + return $self->NEXT::new( { %{ $self->config }, %{ $arguments } } ); } # remember to leave blank lines between the consecutive =item's @@ -75,8 +92,8 @@ sub new { sub config { my $self = shift; $self->_config( {} ) unless $self->_config; - if ( $_[0] ) { - my $config = $_[1] ? {@_} : $_[0]; + if (@_) { + my $config = @_ > 1 ? {@_} : $_[0]; while ( my ( $key, $val ) = each %$config ) { $self->_config->{$key} = $val; } @@ -88,7 +105,16 @@ sub config { =cut -sub process { 1 } +sub process { + + Catalyst::Exception->throw( + message => ( ref $_[0] || $_[0] ) . " did not override Catalyst::Base::process" + ); +} + +=item FETCH_CODE_ATTRIBUTES + +=item MODIFY_CODE_ATTRIBUTES =back @@ -99,6 +125,7 @@ L. =head1 AUTHOR Sebastian Riedel, C +Marcus Ramberg, C =head1 COPYRIGHT