X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FAction%2FSerialize.pm;h=7f782065f3ac49a21a6d77e5374f42c18db75288;hb=351f252f57354a5a0c50e3c931b0addd4f1988ff;hp=313ba802a4a6a2c654a0cb3c4176c03b0bad18a6;hpb=398c5a1bfa52e417d07af96341ec75424dd519ed;p=catagits%2FCatalyst-Action-REST.git diff --git a/lib/Catalyst/Action/Serialize.pm b/lib/Catalyst/Action/Serialize.pm index 313ba80..7f78206 100644 --- a/lib/Catalyst/Action/Serialize.pm +++ b/lib/Catalyst/Action/Serialize.pm @@ -1,79 +1,69 @@ -# -# Catlyst::Action::Serialize.pm -# Created by: Adam Jacob, Marchex, -# -# $Id$ - package Catalyst::Action::Serialize; -use strict; -use warnings; +use Moose; +use namespace::autoclean; -use base 'Catalyst::Action'; +extends 'Catalyst::Action::SerializeBase'; use Module::Pluggable::Object; +use MRO::Compat; + +our $VERSION = '0.98'; +$VERSION = eval $VERSION; -__PACKAGE__->mk_accessors(qw(plugins)); +has _encoders => ( + is => 'ro', + isa => 'HashRef', + default => sub { {} }, +); sub execute { my $self = shift; my ( $controller, $c ) = @_; + $self->maybe::next::method(@_); + return 1 if $c->req->method eq 'HEAD'; - return 1 if length( $c->response->body ); + return 1 if $c->response->has_body; return 1 if scalar @{ $c->error }; - return 1 if $c->response->status =~ /^(?:204|3\d\d)$/; - - # Load the Serialize Classes - unless ( defined( $self->plugins ) ) { - my $mpo = Module::Pluggable::Object->new( - 'require' => 1, - 'search_path' => ['Catalyst::Action::Serialize'], - ); - my @plugins = $mpo->plugins; - $self->plugins( \@plugins ); - } - - # Look up what serializer to use from content_type map - # - # If we don't find one, we use the default - my $content_type = $c->request->content_type; - my $sclass = 'Catalyst::Action::Serialize::'; - my $sarg; - my $map = $controller->serialize->{'map'}; - if ( exists( $map->{$content_type} ) ) { - my $mc; - if ( ref( $map->{$content_type} ) eq "ARRAY" ) { - $mc = $map->{$content_type}->[0]; - $sarg = $map->{$content_type}->[1]; + return 1 if $c->response->status =~ /^(?:204)$/; + + my ( $sclass, $sarg, $content_type ) = + $self->_load_content_plugins( "Catalyst::Action::Serialize", + $controller, $c ); + unless ( defined($sclass) ) { + if ( defined($content_type) ) { + $c->log->info("Could not find a serializer for $content_type"); } else { - $mc = $map->{$content_type}; - } - $sclass .= $mc; - if ( !grep( /^$sclass$/, @{ $self->plugins } ) ) { - die "Cannot find plugin $sclass for $content_type!"; - } - } else { - if ( exists( $controller->serialize->{'default'} ) ) { - $sclass .= $controller->serialize->{'default'}; - } else { - die "I cannot find a default serializer!"; + $c->log->info( + "Could not find a serializer for an empty content-type"); } + return 1; } + $c->log->debug( + "Serializing with $sclass" . ( $sarg ? " [$sarg]" : '' ) ) if $c->debug; - # Go ahead and serialize ourselves - if ( defined($sarg) ) { - $sclass->execute( $controller, $c, $sarg ); - } else { - $sclass->execute( $controller, $c ); - } + $self->_encoders->{$sclass} ||= $sclass->new; + my $sobj = $self->_encoders->{$sclass}; - if ( !$c->response->content_type ) { - $c->response->content_type( $c->request->content_type ); + my $rc; + eval { + if ( defined($sarg) ) { + $rc = $sobj->execute( $controller, $c, $sarg ); + } else { + $rc = $sobj->execute( $controller, $c ); + } + }; + if ($@) { + return $self->_serialize_bad_request( $c, $content_type, $@ ); + } elsif (!$rc) { + return $self->_unsupported_media_type( $c, $content_type ); } return 1; } +__PACKAGE__->meta->make_immutable; + 1; =head1 NAME @@ -85,61 +75,81 @@ Catalyst::Action::Serialize - Serialize Data in a Response package Foo::Controller::Bar; __PACKAGE__->config( - serialize => { - 'default' => 'YAML', - 'stash_key' => 'rest', - 'map' => { - 'text/x-yaml' => 'YAML', - 'text/x-data-dumper' => [ 'Data::Serializer', 'Data::Dumper' ], - }, + 'default' => 'text/x-yaml', + 'stash_key' => 'rest', + 'map' => { + 'text/html' => [ 'View', 'TT', ], + 'text/x-yaml' => 'YAML', + 'text/x-data-dumper' => [ 'Data::Serializer', 'Data::Dumper' ], } ); - sub end : ActionClass('Serialize') {} + sub end :ActionClass('Serialize') {} =head1 DESCRIPTION This action will serialize the body of an HTTP Response. The serializer is -selected by introspecting the requests content-type header. +selected by introspecting the HTTP Requests content-type header. + +It requires that your Catalyst controller is properly configured to set up the +mapping between Content Type's and Serialization classes. + +The specifics of serializing each content-type is implemented as a plugin to +L. + +Typically, you would use this ActionClass on your C method. However, +nothing is stopping you from choosing specific methods to Serialize: -It requires that your Catalyst controller have a "serialize" entry -in it's configuration. + sub foo :Local :ActionClass('Serialize') { + .. populate stash with data .. + } -The specifics of serializing each content-type is implemented as -a plugin to L. +When you use this module, the request class will be changed to +L. =head1 CONFIGURATION -=over 4 +=head2 map -=item default +Takes a hashref, mapping Content-Types to a given serializer plugin. -The default Serialization format. See the next section for -available options. This is used if a requested content-type -is not recognized. +=head2 default -=item stash_key +This is the 'fall-back' Content-Type if none of the requested or acceptable +types is found in the L. It must be an entry in the L. -Where in the stash the data you want serialized lives. +=head2 stash_key -=item map +Specifies the key of the stash entry holding the data that is to be serialized. +So if the value is "rest", we will serialize the data under: -Takes a hashref, mapping Content-Types to a given plugin. + $c->stash->{'rest'} -=back +=head2 content_type_stash_key + +Specifies the key of the stash entry that optionally holds an overriding +Content-Type. If set, and if the specified stash entry has a valid value, +then it takes priority over the requested content types. + +This can be useful if you want to dynamically force a particular content type, +perhaps for debugging. + +=head1 HELPFUL PEOPLE + +Daisuke Maki pointed out that early versions of this Action did not play +well with others, or generally behave in a way that was very consistent +with the rest of Catalyst. =head1 SEE ALSO You likely want to look at L, which implements -a sensible set of defaults for a controller doing REST. +a sensible set of defaults for doing a REST controller. L, L -=head1 AUTHOR - -Adam Jacob , with lots of help from mst and jrockway +=head1 AUTHORS -Marchex, Inc. paid me while I developed this module. (http://www.marchex.com) +See L for authors. =head1 LICENSE