X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst%2FAction%2FDeserialize.pm;h=5be60f3513ff0e35dde87584ee12a4e8df81f252;hb=370367cb80b925e50a4ea1bc759b06d1466f2627;hp=c8c68e64fa546f23a7741c58d0abbc1f99758652;hpb=04eaf27858960701f33ae0a3c7676bf095b81762;p=catagits%2FCatalyst-Action-REST.git diff --git a/lib/Catalyst/Action/Deserialize.pm b/lib/Catalyst/Action/Deserialize.pm index c8c68e6..5be60f3 100644 --- a/lib/Catalyst/Action/Deserialize.pm +++ b/lib/Catalyst/Action/Deserialize.pm @@ -8,9 +8,6 @@ use Module::Pluggable::Object; use MRO::Compat; use Moose::Util::TypeConstraints; -our $VERSION = '0.91'; -$VERSION = eval $VERSION; - has plugins => ( is => 'rw' ); has deserialize_http_methods => ( @@ -35,7 +32,7 @@ sub execute { my $self = shift; my ( $controller, $c ) = @_; - if ( $self->_deserialize_handles_http_method($c->request->method) ) { + if ( !defined($c->req->data) && $self->_deserialize_handles_http_method($c->request->method) ) { my ( $sclass, $sarg, $content_type ) = $self->_load_content_plugins( 'Catalyst::Action::Deserialize', $controller, $c ); @@ -47,9 +44,9 @@ sub execute { $rc = $sclass->execute( $controller, $c ); } if ( $rc eq "0" ) { - return $self->_unsupported_media_type( $c, $content_type ); + return $self->unsupported_media_type( $c, $content_type ); } elsif ( $rc ne "1" ) { - return $self->_serialize_bad_request( $c, $content_type, $rc ); + return $self->serialize_bad_request( $c, $content_type, $rc ); } } @@ -120,6 +117,43 @@ Will work just fine. When you use this module, the request class will be changed to L. +=head1 RFC 7231 Compliance Mode + +To maintain backwards compatibility with the module's original functionality, +where it was assumed the deserialize and serialize content types are the same, +an optional compliance mode can be enabled to break this assumption. + + __PACKAGE__->config( + 'compliance_mode' => 1, + 'default' => 'text/x-yaml', + 'stash_key' => 'rest', + 'map' => { + 'text/x-yaml' => 'YAML', + 'text/x-data-dumper' => [ 'Data::Serializer', 'Data::Dumper' ], + }, + 'deserialize_default => 'application/json', + 'deserialize_map' => { + 'application/json' => 'JSON', + }, + ); + +Three extra keys are added to the controller configuration. compliance_mode, a +boolean to enable the mode. And a parallel set of content type mappings +'deserialize_default' and 'deserialize_map' to mirror the default/map +configuration keys. + +The module will use the default/map keys when negotiating the serializing +content type specified by the client in the Accept header. And will use the +deserialize_default/deserialize_map in conjunction with the Content-Type +header where the client is giving the content type being sent in the request. + +=head1 CUSTOM ERRORS + +For building custom error responses when de-serialization fails, you can create +an ActionRole (and use L to apply it to the +C action) which overrides C and/or C +methods. + =head1 SEE ALSO You likely want to look at L, which implements