X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FApp%2FFatPacker.pm;h=03d28fbf2dd5292f0f4f1ba717bca0b5a6f2d4ea;hb=bb49414d002fe7f1b61e57f961ebb6d1b246814d;hp=c225ac7167058df0dcb8baf7f1610694bf6feb34;hpb=5e1de95d70751d027dc61d599c4e2eb7d437028d;p=p5sagit%2FApp-FatPacker.git

diff --git a/lib/App/FatPacker.pm b/lib/App/FatPacker.pm
index c225ac7..03d28fb 100644
--- a/lib/App/FatPacker.pm
+++ b/lib/App/FatPacker.pm
@@ -4,26 +4,26 @@ use strict;
 use warnings FATAL => 'all';
 use 5.008001;
 use Getopt::Long;
-use Capture::Tiny ();
 use Cwd qw(cwd);
 use File::Find qw(find);
 use File::Spec::Functions qw(
   catdir splitpath splitdir catpath rel2abs abs2rel
 );
+use File::Spec::Unix;
 use File::Copy qw(copy);
 use File::Path qw(mkpath rmtree);
 use B qw(perlstring);
 
-our $VERSION = '0.009006'; # 0.9.6
+our $VERSION = '0.009009'; # 0.9.9
 
 $VERSION = eval $VERSION;
 
 sub call_parser {
   my $self = shift;
-  my ( $args, $options ) = @_;
+  my ($args, $options) = @_;
 
   local *ARGV = [ @{$args} ];
-  $self->{'option_parser'}->getoptions( @{$options} );
+  $self->{option_parser}->getoptions(@$options);
 
   return [ @ARGV ];
 }
@@ -70,21 +70,22 @@ sub script_command_help {
 sub script_command_trace {
   my ($self, $args) = @_;
 
-  $args = $self->call_parser( $args => [
+  $args = $self->call_parser($args => [
     'to=s' => \my $file,
     'to-stderr' => \my $to_stderr,
     'use=s' => \my @additional_use
-  ] );
+  ]);
 
   die "Can't use to and to-stderr on same call" if $file && $to_stderr;
 
   $file ||= 'fatpacker.trace';
+
   if (!$to_stderr and -e $file) {
     unlink $file or die "Couldn't remove old trace file: $!";
   }
   my $arg = do {
     if ($to_stderr) {
-      "=&STDERR"
+      ">&STDERR"
     } elsif ($file) {
       ">>${file}"
     }
@@ -99,39 +100,28 @@ sub script_command_trace {
 
 sub trace {
   my ($self, %opts) = @_;
-  my $use = defined $opts{'use'} ? $opts{'use'} : [];
-  my $args = defined $opts{'args'} ? $opts{'args'} : [];
-  my $output = $opts{'output'};
+
   my $capture;
 
-  # if the user doesn't provide output, they want to actually
-  # capture the output and receive it back
-  if (!$output) {
-    # throw to STDOUT to differ from STDERR
-    $output .= '>&STDOUT';
+  my $output = $opts{output} || do {
+    $capture++; '>&STDOUT'
+  };
 
-    # raise capture flag
-    $capture++;
-  }
+  my $trace_opts = join ',', $output||'>&STDOUT', @{$opts{use}||[]};
 
-  if(@$use) {
-    $output .= "," . join ",", @$use;
-  }
+  local $ENV{PERL5OPT} = '-MApp::FatPacker::Trace='.$trace_opts;
 
-  my $trace_sub = sub {
-     local $ENV{PERL5OPT} = '-MApp::FatPacker::Trace='.$output;
-     system $^X, @$args;
-  };
+  my @args = @{$opts{args}||[]};
 
-  if ($capture) {
-    # capture both STDOUT and STDERR so we could throw away STDERR
-    # STDOUT will contain the trace
-    # STDERR will contain the "syntax OK" statement
-    my ($stdout, $stderr) = Capture::Tiny::capture {$trace_sub->()};
-    return $stdout;
+  if ($output) {
+    # user specified output target, JFDI
+    system $^X, @args;
+    return;
   } else {
-    $trace_sub->();
-   }
+    # no output target specified, slurp
+    open my $out_fh, '-|', $^X, @args;
+    return do { local $/; <$out_fh> };
+  }
 }
 
 sub script_command_packlists_for {
@@ -144,7 +134,9 @@ sub script_command_packlists_for {
 sub packlists_containing {
   my ($self, $targets) = @_;
   my @targets = @$targets;
-  require $_ for @targets;
+  foreach my $t (@targets) {
+    require $t;
+  }
   my @search = grep -d $_, map catdir($_, 'auto'), @INC;
   my %pack_rev;
   my $cwd = cwd;
@@ -201,9 +193,10 @@ sub script_command_file {
     find(sub {
       return unless -f $_;
       !/\.pm$/ and warn "File ${File::Find::name} isn't a .pm file - can't pack this and if you hoped we were going to things may not be what you expected later\n" and return;
-      $files{abs2rel($File::Find::name,$dir)} = do {
+      $files{File::Spec::Unix->abs2rel($File::Find::name,$dir)} = do {
         local (@ARGV, $/) = ($File::Find::name); <>
       };
+      close ARGV;
     }, $dir);
   }
   my $start = stripspace <<'  END_START';
@@ -236,6 +229,8 @@ sub script_command_file {
   print join "\n", $start, @segments, $end;
 }
 
+=encoding UTF-8
+
 =head1 NAME
 
 App::FatPacker - pack your dependencies onto your script file
@@ -263,7 +258,23 @@ Matt S. Trout (mst) <mst@shadowcat.co.uk>
 
 =head2 CONTRIBUTORS
 
-None as yet, though I probably owe lots of people thanks for ideas. Yet
+miyagawa - Tatsuhiko Miyagawa (cpan:MIYAGAWA) <miyagawa@bulknews.net>
+
+tokuhirom - MATSUNO★Tokuhiro (cpan:TOKUHIROM) <tokuhirom@gmail.com>
+
+dg - David Leadbeater (cpan:DGL) <dgl@dgl.cx>
+
+gugod - 劉康民 (cpan:GUGOD) <gugod@cpan.org>
+
+t0m - Tomas Doran (cpan:BOBTFISH) <bobtfish@bobtfish.net>
+
+sawyer - Sawyer X (cpan:XSAWYERX) <xsawyerx@cpan.org>
+
+ether - Karen Etheridge (cpan:ETHER) <ether@cpan.org>
+
+Mithaldu - Christian Walde (cpan:MITHALDU) <walde.christian@googlemail.com>
+
+Many more people are probably owed thanks for ideas. Yet
 another doc nit to fix.
 
 =head1 COPYRIGHT