X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=ext%2Fthreads%2Fshared%2Ft%2Fno_share.t;h=7e5a80fb373d74e6192f57b3cb40259c9382d45c;hb=13c1b20720b7eeca2a0c896ac27f004bc376edb3;hp=519d9cb532fa4fa40d49a60b1e58a8573d270058;hpb=dab065ea9c8b629eb22b219d57901aa33df76f4f;p=p5sagit%2Fp5-mst-13.2.git diff --git a/ext/threads/shared/t/no_share.t b/ext/threads/shared/t/no_share.t index 519d9cb..7e5a80f 100644 --- a/ext/threads/shared/t/no_share.t +++ b/ext/threads/shared/t/no_share.t @@ -1,6 +1,4 @@ - - - +use warnings; BEGIN { # chdir 't' if -d 't'; @@ -17,6 +15,7 @@ BEGIN { sub ok { my ($id, $ok, $name) = @_; + $name = '' unless defined $name; # You have to do it this way or VMS will get confused. print $ok ? "ok $id - $name\n" : "not ok $id - $name\n"; @@ -33,7 +32,7 @@ use threads::shared; use threads; ok(1,1,"loaded"); ok(2,$warnmsg =~ /Warning, threads::shared has already been loaded/, - "threads has warned us"); + "threads has warned us"); my $test = "bar"; share($test); ok(3,$test eq "bar","Test disabled share not interfering"); @@ -42,6 +41,7 @@ threads->create( ok(4,$test eq "bar","Test disabled share after thread"); $test = "baz"; })->join(); -ok(5,$test eq "bar","Test that value hasn't changed in another thread"); +# Value should either remain unchanged or be value set by other thread +ok(5,$test eq "bar" || $test eq 'baz',"Test that value is an expected one"); + -