X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=ext%2FSocket%2FSocket.t;h=ed87e671847a75576b819b84c6cf0ec43dc2e2dd;hb=85e0a142d02334b9703df242ba0bb3d8d109cdd0;hp=20a57a49b738b55bfe3e62fe27998ac4aae8ba6c;hpb=d09712d887062ccb5a1104006dc798bcb5502153;p=p5sagit%2Fp5-mst-13.2.git

diff --git a/ext/Socket/Socket.t b/ext/Socket/Socket.t
index 20a57a4..ed87e67 100755
--- a/ext/Socket/Socket.t
+++ b/ext/Socket/Socket.t
@@ -9,69 +9,99 @@ BEGIN {
 	print "1..0\n";
 	exit 0;
     }
+    $has_alarm = $Config{d_alarm};
 }
 	
 use Socket;
 
-print "1..13\n";
+print "1..16\n";
+
+$alarmed = 0;
+sub arm      { $alarmed = 0; alarm(shift) if $has_alarm }
+sub alarmed  { $alarmed = 1 }
+$SIG{ALRM} = 'alarmed'                    if $has_alarm;
 
 if (socket(T,PF_INET,SOCK_STREAM,6)) {
   print "ok 1\n";
-
+  
+  arm(5);
   if (connect(T,pack_sockaddr_in(7,inet_aton("localhost")))){
+	arm(0);
+
 	print "ok 2\n";
 
 	print "# Connected to " .
 		inet_ntoa((unpack_sockaddr_in(getpeername(T)))[1])."\n";
 
+	arm(5);
 	syswrite(T,"hello",5);
+	arm(0);
+
+	arm(5);
 	$read = sysread(T,$buff,10);	# Connection may be granted, then closed!
+	arm(0);
+
 	while ($read > 0 && length($buff) < 5) {
 	    # adjust for fact that TCP doesn't guarantee size of reads/writes
+	    arm(5);
 	    $read = sysread(T,$buff,10,length($buff));
+	    arm(0);
 	}
 	print(($read == 0 || $buff eq "hello") ? "ok 3\n" : "not ok 3\n");
   }
   else {
-	print "# You're allowed to fail tests 2 and 3 if.\n";
-	print "# The echo service has been disabled.\n";
-	print "# $!\n";
-	print "ok 2\n";
-	print "ok 3\n";
+	print "# You're allowed to fail tests 2 and 3 if\n";
+	print "# the echo service has been disabled.\n";
+	print "# 'Interrupted system call' indicates a hanging echo service.\n";
+	print "# Error: $!\n";
+	print "ok 2 - skipped\n";
+	print "ok 3 - skipped\n";
   }
 }
 else {
-	print "# $!\n";
+	print "# Error: $!\n";
 	print "not ok 1\n";
 }
 
 if( socket(S,PF_INET,SOCK_STREAM,6) ){
   print "ok 4\n";
 
+  arm(5);
   if (connect(S,pack_sockaddr_in(7,INADDR_LOOPBACK))){
+        arm(0);
+
 	print "ok 5\n";
 
 	print "# Connected to " .
 		inet_ntoa((unpack_sockaddr_in(getpeername(S)))[1])."\n";
 
+	arm(5);
 	syswrite(S,"olleh",5);
+	arm(0);
+
+	arm(5);
 	$read = sysread(S,$buff,10);	# Connection may be granted, then closed!
+	arm(0);
+
 	while ($read > 0 && length($buff) < 5) {
 	    # adjust for fact that TCP doesn't guarantee size of reads/writes
+	    arm(5);
 	    $read = sysread(S,$buff,10,length($buff));
+	    arm(0);
 	}
 	print(($read == 0 || $buff eq "olleh") ? "ok 6\n" : "not ok 6\n");
   }
   else {
-	print "# You're allowed to fail tests 5 and 6 if.\n";
-	print "# The echo service has been disabled.\n";
-	print "# $!\n";
-	print "ok 5\n";
-	print "ok 6\n";
+	print "# You're allowed to fail tests 5 and 6 if\n";
+	print "# the echo service has been disabled.\n";
+	print "# 'Interrupted system call' indicates a hanging echo service.\n";
+	print "# Error: $!\n";
+	print "ok 5 - skipped\n";
+	print "ok 6 - skipped\n";
   }
 }
 else {
-	print "# $!\n";
+	print "# Error: $!\n";
 	print "not ok 4\n";
 }
 
@@ -93,11 +123,22 @@ if((inet_ntoa((unpack_sockaddr_in(pack_sockaddr_in(100,inet_aton("10.250.230.10"
 } else {
     print "not ok 9\n"; 
 }
-print ((inet_aton("10.10.10.10") eq v10.10.10.10) ? "ok 10\n" : "not ok 10\n");
-print ((inet_ntoa(v10.10.10.10) eq '10.10.10.10') ? "ok 11\n" : "not ok 11\n");
+print ((inet_ntoa(inet_aton("10.20.30.40")) eq "10.20.30.40") ? "ok 10\n" : "not ok 10\n");
+print ((inet_ntoa(v10.20.30.40) eq "10.20.30.40") ? "ok 11\n" : "not ok 11\n");
 {
     my ($port,$addr) = unpack_sockaddr_in(pack_sockaddr_in(100,v10.10.10.10));
     print (($port == 100) ? "ok 12\n" : "not ok 12\n");
-    print (($addr eq v10.10.10.10) ? "ok 13\n" : "not ok 13\n");
+    print ((inet_ntoa($addr) eq "10.10.10.10") ? "ok 13\n" : "not ok 13\n");
 }
 				     
+eval { inet_ntoa(v10.20.30.400) };
+print (($@ =~ /^Wide character in Socket::inet_ntoa at/) ? "ok 14\n" : "not ok 14\n");
+
+if (sockaddr_family(pack_sockaddr_in(100,inet_aton("10.250.230.10"))) == AF_INET) {
+    print "ok 15\n";
+} else {
+    print "not ok 15\n";
+}
+
+eval { sockaddr_family("") };
+print (($@ =~ /^Bad arg length for Socket::sockaddr_family, length is 0, should be at least \d+/) ? "ok 16\n" : "not ok 16\n");