X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=doop.c;h=dc525d356faa5c3582ffaba7304d05198fc83f62;hb=1a6108908b085da4d14ad0cdf8549f193a6fb877;hp=9583e04ab2a1f6e14e43f29f5b8dc22e925d2e75;hpb=c395bd6cbc645e80f929b5b4e285b43aa4366851;p=p5sagit%2Fp5-mst-13.2.git diff --git a/doop.c b/doop.c index 9583e04..dc525d3 100644 --- a/doop.c +++ b/doop.c @@ -1,7 +1,7 @@ /* doop.c * * Copyright (C) 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, - * 2000, 2001, 2002, 2004, 2005, 2006, by Larry Wall and others + * 2000, 2001, 2002, 2004, 2005, 2006, 2007, by Larry Wall and others * * You may distribute under the terms of either the GNU General Public * License or the Artistic License, as specified in the README file. @@ -215,7 +215,7 @@ S_do_trans_complex(pTHX_ SV * const sv) else { matches++; if (!del) { - ch = (rlen == 0) ? comp : + ch = (rlen == 0) ? (I32)comp : (comp - 0x100 < rlen) ? tbl[comp+1] : tbl[0x100+rlen]; if ((UV)ch != pch) { @@ -307,7 +307,12 @@ S_do_trans_simple_utf8(pTHX_ SV * const sv) const I32 grows = PL_op->op_private & OPpTRANS_GROWS; STRLEN len; - SV* const rv = (SV*)cSVOP->op_sv; + SV* const rv = +#ifdef USE_ITHREADS + PAD_SVl(cPADOP->op_padix); +#else + (SV*)cSVOP->op_sv; +#endif HV* const hv = (HV*)SvRV(rv); SV* const * svp = hv_fetchs(hv, "NONE", FALSE); const UV none = svp ? SvUV(*svp) : 0x7fffffff; @@ -403,7 +408,12 @@ S_do_trans_count_utf8(pTHX_ SV * const sv) I32 matches = 0; STRLEN len; - SV* const rv = (SV*)cSVOP->op_sv; + SV* const rv = +#ifdef USE_ITHREADS + PAD_SVl(cPADOP->op_padix); +#else + (SV*)cSVOP->op_sv; +#endif HV* const hv = (HV*)SvRV(rv); SV* const * const svp = hv_fetchs(hv, "NONE", FALSE); const UV none = svp ? SvUV(*svp) : 0x7fffffff; @@ -447,7 +457,12 @@ S_do_trans_complex_utf8(pTHX_ SV * const sv) const I32 squash = PL_op->op_private & OPpTRANS_SQUASH; const I32 del = PL_op->op_private & OPpTRANS_DELETE; const I32 grows = PL_op->op_private & OPpTRANS_GROWS; - SV * const rv = (SV*)cSVOP->op_sv; + SV* const rv = +#ifdef USE_ITHREADS + PAD_SVl(cPADOP->op_padix); +#else + (SV*)cSVOP->op_sv; +#endif HV * const hv = (HV*)SvRV(rv); SV * const *svp = hv_fetchs(hv, "NONE", FALSE); const UV none = svp ? SvUV(*svp) : 0x7fffffff; @@ -648,7 +663,7 @@ Perl_do_trans(pTHX_ SV *sv) } void -Perl_do_join(pTHX_ register SV *sv, SV *del, register SV **mark, register SV **sp) +Perl_do_join(pTHX_ register SV *sv, SV *delim, register SV **mark, register SV **sp) { dVAR; SV ** const oldmark = mark; @@ -656,7 +671,7 @@ Perl_do_join(pTHX_ register SV *sv, SV *del, register SV **mark, register SV **s register STRLEN len; STRLEN delimlen; - (void) SvPV_const(del, delimlen); /* stringify and get the delimlen */ + (void) SvPV_const(delim, delimlen); /* stringify and get the delimlen */ /* SvCUR assumes it's SvPOK() and woe betide you if it's not. */ mark++; @@ -693,7 +708,7 @@ Perl_do_join(pTHX_ register SV *sv, SV *del, register SV **mark, register SV **s if (delimlen) { for (; items > 0; items--,mark++) { - sv_catsv(sv,del); + sv_catsv(sv,delim); sv_catsv(sv,*mark); } } @@ -726,7 +741,7 @@ UV Perl_do_vecget(pTHX_ SV *sv, I32 offset, I32 size) { dVAR; - STRLEN srclen, len; + STRLEN srclen, len, uoffset, bitoffs = 0; const unsigned char *s = (const unsigned char *) SvPV_const(sv, srclen); UV retnum = 0; @@ -738,118 +753,124 @@ Perl_do_vecget(pTHX_ SV *sv, I32 offset, I32 size) if (SvUTF8(sv)) (void) Perl_sv_utf8_downgrade(aTHX_ sv, TRUE); - offset *= size; /* turn into bit offset */ - len = (offset + size + 7) / 8; /* required number of bytes */ + if (size < 8) { + bitoffs = ((offset%8)*size)%8; + uoffset = offset/(8/size); + } + else if (size > 8) + uoffset = offset*(size/8); + else + uoffset = offset; + + len = uoffset + (bitoffs + size + 7)/8; /* required number of bytes */ if (len > srclen) { if (size <= 8) retnum = 0; else { - offset >>= 3; /* turn into byte offset */ if (size == 16) { - if ((STRLEN)offset >= srclen) + if (uoffset >= srclen) retnum = 0; else - retnum = (UV) s[offset] << 8; + retnum = (UV) s[uoffset] << 8; } else if (size == 32) { - if ((STRLEN)offset >= srclen) + if (uoffset >= srclen) retnum = 0; - else if ((STRLEN)(offset + 1) >= srclen) + else if (uoffset + 1 >= srclen) retnum = - ((UV) s[offset ] << 24); - else if ((STRLEN)(offset + 2) >= srclen) + ((UV) s[uoffset ] << 24); + else if (uoffset + 2 >= srclen) retnum = - ((UV) s[offset ] << 24) + - ((UV) s[offset + 1] << 16); + ((UV) s[uoffset ] << 24) + + ((UV) s[uoffset + 1] << 16); else retnum = - ((UV) s[offset ] << 24) + - ((UV) s[offset + 1] << 16) + - ( s[offset + 2] << 8); + ((UV) s[uoffset ] << 24) + + ((UV) s[uoffset + 1] << 16) + + ( s[uoffset + 2] << 8); } #ifdef UV_IS_QUAD else if (size == 64) { if (ckWARN(WARN_PORTABLE)) Perl_warner(aTHX_ packWARN(WARN_PORTABLE), "Bit vector size > 32 non-portable"); - if (offset >= srclen) + if (uoffset >= srclen) retnum = 0; - else if (offset + 1 >= srclen) + else if (uoffset + 1 >= srclen) retnum = - (UV) s[offset ] << 56; - else if (offset + 2 >= srclen) + (UV) s[uoffset ] << 56; + else if (uoffset + 2 >= srclen) retnum = - ((UV) s[offset ] << 56) + - ((UV) s[offset + 1] << 48); - else if (offset + 3 >= srclen) + ((UV) s[uoffset ] << 56) + + ((UV) s[uoffset + 1] << 48); + else if (uoffset + 3 >= srclen) retnum = - ((UV) s[offset ] << 56) + - ((UV) s[offset + 1] << 48) + - ((UV) s[offset + 2] << 40); - else if (offset + 4 >= srclen) + ((UV) s[uoffset ] << 56) + + ((UV) s[uoffset + 1] << 48) + + ((UV) s[uoffset + 2] << 40); + else if (uoffset + 4 >= srclen) retnum = - ((UV) s[offset ] << 56) + - ((UV) s[offset + 1] << 48) + - ((UV) s[offset + 2] << 40) + - ((UV) s[offset + 3] << 32); - else if (offset + 5 >= srclen) + ((UV) s[uoffset ] << 56) + + ((UV) s[uoffset + 1] << 48) + + ((UV) s[uoffset + 2] << 40) + + ((UV) s[uoffset + 3] << 32); + else if (uoffset + 5 >= srclen) retnum = - ((UV) s[offset ] << 56) + - ((UV) s[offset + 1] << 48) + - ((UV) s[offset + 2] << 40) + - ((UV) s[offset + 3] << 32) + - ( s[offset + 4] << 24); - else if (offset + 6 >= srclen) + ((UV) s[uoffset ] << 56) + + ((UV) s[uoffset + 1] << 48) + + ((UV) s[uoffset + 2] << 40) + + ((UV) s[uoffset + 3] << 32) + + ( s[uoffset + 4] << 24); + else if (uoffset + 6 >= srclen) retnum = - ((UV) s[offset ] << 56) + - ((UV) s[offset + 1] << 48) + - ((UV) s[offset + 2] << 40) + - ((UV) s[offset + 3] << 32) + - ((UV) s[offset + 4] << 24) + - ((UV) s[offset + 5] << 16); + ((UV) s[uoffset ] << 56) + + ((UV) s[uoffset + 1] << 48) + + ((UV) s[uoffset + 2] << 40) + + ((UV) s[uoffset + 3] << 32) + + ((UV) s[uoffset + 4] << 24) + + ((UV) s[uoffset + 5] << 16); else retnum = - ((UV) s[offset ] << 56) + - ((UV) s[offset + 1] << 48) + - ((UV) s[offset + 2] << 40) + - ((UV) s[offset + 3] << 32) + - ((UV) s[offset + 4] << 24) + - ((UV) s[offset + 5] << 16) + - ( s[offset + 6] << 8); + ((UV) s[uoffset ] << 56) + + ((UV) s[uoffset + 1] << 48) + + ((UV) s[uoffset + 2] << 40) + + ((UV) s[uoffset + 3] << 32) + + ((UV) s[uoffset + 4] << 24) + + ((UV) s[uoffset + 5] << 16) + + ( s[uoffset + 6] << 8); } #endif } } else if (size < 8) - retnum = (s[offset >> 3] >> (offset & 7)) & ((1 << size) - 1); + retnum = (s[uoffset] >> bitoffs) & ((1 << size) - 1); else { - offset >>= 3; /* turn into byte offset */ if (size == 8) - retnum = s[offset]; + retnum = s[uoffset]; else if (size == 16) retnum = - ((UV) s[offset] << 8) + - s[offset + 1]; + ((UV) s[uoffset] << 8) + + s[uoffset + 1]; else if (size == 32) retnum = - ((UV) s[offset ] << 24) + - ((UV) s[offset + 1] << 16) + - ( s[offset + 2] << 8) + - s[offset + 3]; + ((UV) s[uoffset ] << 24) + + ((UV) s[uoffset + 1] << 16) + + ( s[uoffset + 2] << 8) + + s[uoffset + 3]; #ifdef UV_IS_QUAD else if (size == 64) { if (ckWARN(WARN_PORTABLE)) Perl_warner(aTHX_ packWARN(WARN_PORTABLE), "Bit vector size > 32 non-portable"); retnum = - ((UV) s[offset ] << 56) + - ((UV) s[offset + 1] << 48) + - ((UV) s[offset + 2] << 40) + - ((UV) s[offset + 3] << 32) + - ((UV) s[offset + 4] << 24) + - ((UV) s[offset + 5] << 16) + - ( s[offset + 6] << 8) + - s[offset + 7]; + ((UV) s[uoffset ] << 56) + + ((UV) s[uoffset + 1] << 48) + + ((UV) s[uoffset + 2] << 40) + + ((UV) s[uoffset + 3] << 32) + + ((UV) s[uoffset + 4] << 24) + + ((UV) s[uoffset + 5] << 16) + + ( s[uoffset + 6] << 8) + + s[uoffset + 7]; } #endif } @@ -865,7 +886,7 @@ void Perl_do_vecset(pTHX_ SV *sv) { dVAR; - register I32 offset; + register I32 offset, bitoffs = 0; register I32 size; register unsigned char *s; register UV lval; @@ -894,8 +915,14 @@ Perl_do_vecset(pTHX_ SV *sv) if (size < 1 || (size & (size-1))) /* size < 1 or not a power of two */ Perl_croak(aTHX_ "Illegal number of bits in vec"); - offset *= size; /* turn into bit offset */ - len = (offset + size + 7) / 8; /* required number of bytes */ + if (size < 8) { + bitoffs = ((offset%8)*size)%8; + offset /= 8/size; + } + else if (size > 8) + offset *= size/8; + + len = offset + (bitoffs + size + 7)/8; /* required number of bytes */ if (len > targlen) { s = (unsigned char*)SvGROW(targ, len + 1); (void)memzero((char *)(s + targlen), len - targlen + 1); @@ -904,14 +931,11 @@ Perl_do_vecset(pTHX_ SV *sv) if (size < 8) { mask = (1 << size) - 1; - size = offset & 7; lval &= mask; - offset >>= 3; /* turn into byte offset */ - s[offset] &= ~(mask << size); - s[offset] |= lval << size; + s[offset] &= ~(mask << bitoffs); + s[offset] |= lval << bitoffs; } else { - offset >>= 3; /* turn into byte offset */ if (size == 8) s[offset ] = (U8)( lval & 0xff); else if (size == 16) { @@ -1169,23 +1193,42 @@ Perl_do_vop(pTHX_ I32 optype, SV *sv, SV *left, SV *right) STRLEN rightlen; register const char *lc; register const char *rc; - register I32 len; - I32 lensave; + register STRLEN len; + STRLEN lensave; const char *lsave; const char *rsave; - const bool left_utf = DO_UTF8(left); - const bool right_utf = DO_UTF8(right); - I32 needlen = 0; + bool left_utf; + bool right_utf; + STRLEN needlen = 0; - if (left_utf && !right_utf) - sv_utf8_upgrade(right); - else if (!left_utf && right_utf) - sv_utf8_upgrade(left); if (sv != left || (optype != OP_BIT_AND && !SvOK(sv) && !SvGMAGICAL(sv))) sv_setpvn(sv, "", 0); /* avoid undef warning on |= and ^= */ lsave = lc = SvPV_nomg_const(left, leftlen); rsave = rc = SvPV_nomg_const(right, rightlen); + + /* This need to come after SvPV to ensure that string overloading has + fired off. */ + + left_utf = DO_UTF8(left); + right_utf = DO_UTF8(right); + + if (left_utf && !right_utf) { + /* Avoid triggering overloading again by using temporaries. + Maybe there should be a variant of sv_utf8_upgrade that takes pvn + */ + right = sv_2mortal(newSVpvn(rsave, rightlen)); + sv_utf8_upgrade(right); + rsave = rc = SvPV_nomg_const(right, rightlen); + right_utf = TRUE; + } + else if (!left_utf && right_utf) { + left = sv_2mortal(newSVpvn(lsave, leftlen)); + sv_utf8_upgrade(left); + lsave = lc = SvPV_nomg_const(left, leftlen); + left_utf = TRUE; + } + len = leftlen < rightlen ? leftlen : rightlen; lensave = len; SvCUR_set(sv, len); @@ -1196,16 +1239,16 @@ Perl_do_vop(pTHX_ I32 optype, SV *sv, SV *left, SV *right) } else if (SvOK(sv) || SvTYPE(sv) > SVt_PVMG) { dc = SvPV_force_nomg_nolen(sv); - if (SvLEN(sv) < (STRLEN)(len + 1)) { - dc = SvGROW(sv, (STRLEN)(len + 1)); + if (SvLEN(sv) < len + 1) { + dc = SvGROW(sv, len + 1); (void)memzero(dc + SvCUR(sv), len - SvCUR(sv) + 1); } if (optype != OP_BIT_AND && (left_utf || right_utf)) dc = SvGROW(sv, leftlen + rightlen + 1); } else { - needlen = ((optype == OP_BIT_AND) - ? len : (leftlen > rightlen ? leftlen : rightlen)); + needlen = optype == OP_BIT_AND + ? len : (leftlen > rightlen ? leftlen : rightlen); Newxz(dc, needlen + 1, char); sv_usepvn_flags(sv, dc, needlen, SV_HAS_TRAILING_NUL); dc = SvPVX(sv); /* sv_usepvn() calls Renew() */ @@ -1285,11 +1328,11 @@ Perl_do_vop(pTHX_ I32 optype, SV *sv, SV *left, SV *right) else #ifdef LIBERAL if (len >= sizeof(long)*4 && - !((long)dc % sizeof(long)) && - !((long)lc % sizeof(long)) && - !((long)rc % sizeof(long))) /* It's almost always aligned... */ + !((unsigned long)dc % sizeof(long)) && + !((unsigned long)lc % sizeof(long)) && + !((unsigned long)rc % sizeof(long))) /* It's almost always aligned... */ { - const I32 remainder = len % (sizeof(long)*4); + const STRLEN remainder = len % (sizeof(long)*4); len /= (sizeof(long)*4); dl = (long*)dc; @@ -1345,7 +1388,7 @@ Perl_do_vop(pTHX_ I32 optype, SV *sv, SV *left, SV *right) *dc++ = *lc++ | *rc++; mop_up: len = lensave; - if (rightlen > (STRLEN)len) + if (rightlen > len) sv_catpvn(sv, rsave + len, rightlen - len); else if (leftlen > (STRLEN)len) sv_catpvn(sv, lsave + len, leftlen - len); @@ -1406,8 +1449,10 @@ Perl_do_kv(pTHX) RETURN; } - if (! SvTIED_mg((SV*)keys, PERL_MAGIC_tied)) + if (! SvTIED_mg((SV*)keys, PERL_MAGIC_tied) ) + { i = HvKEYS(keys); + } else { i = 0; while (hv_iternext(keys)) i++;