X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=TODO;h=a6b6072f3c2b81637fb8c419d2c71af0f5cd581c;hb=c86a46cc54baef2a5738176a70288db5f3f1376f;hp=a1e5226ce12945e355eb1433eb6f70f5f17578a1;hpb=06a66732eb48842ce6bea1259cf4570cc34d99ff;p=gitmo%2FMooseX-Storage.git diff --git a/TODO b/TODO index a1e5226..a6b6072 100644 --- a/TODO +++ b/TODO @@ -2,34 +2,7 @@ :NOTES: --------------------------------------------------------------------- -purely functional means we don't have to reinstantiate Engine each time, -and IMHO there's no need even without big changes. -We can do something like this: - - sub collapse_object { - my $self = shift; - my %storage; - $self->map_attributes(sub { $self->collapse_attribute(\%storage, @_) }); - } - -or we can make collapse_attribute return KVPs (I think that's nicer and more reusable): - - sub collapse_object { - my $self = shift; - return { - $self->map_attributes('collapse_attribute'), - __class__ => $self->object->meta->name, - }; - } - -I 100% agree, the instantiation of Engine was actually a leftover from an -early version, so I can make this more functional without too much trouble. - ---------------------------------------------------------------------- - -I am not going to do this quite yet, I think there might actually still be value to -keeping it the way it is. I want to attempt an engine extension first, before i do this.