X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=TODO;h=6c74e1441d9e0c723ab16e06e2152b78f9eae6a5;hb=5bc06bcbb52291b4fbf751b62db568354c3dd4b9;hp=38b2d1dc4d1cc39543e0970f8d4960315328bb50;hpb=5faa454d2d70f44f01c0cd5cab9861768d303225;p=catagits%2FCatalyst-Runtime.git diff --git a/TODO b/TODO index 38b2d1d..6c74e14 100644 --- a/TODO +++ b/TODO @@ -148,10 +148,13 @@ after BUILD => sub { - + $class->container->get_sub_container('model')->make_single_default; + $class->container->get_sub_container('view')->make_single_default; + locate_components service vs setup_components method + - can we be more lazy? + - should setup_components be a service that things like the ->component lookup + can depend on? + get_components_names_types - locate_components - +# FIXME - t0m, how do you feel about this name? +# also, do you think I should draw it here, or just return the data structure? +sub get_components_names_types { @@ -162,10 +165,11 @@ after BUILD => sub { - my $accept_context_args = $self->param('accept_context_args'); + my $accept_context_args = $params{accept_context_args}; - ^^ This is wrong! The service should be allowed to mangle the accept_context args, no? + ^^ This (may be) wrong! I am thinking the service should be allowed to mangle the + accept_context args, no? Without this change, the user could make a custom service which mangled the param, and use Catalyst/IOC/Service/WithAcceptContext.pm, with this change, that module will always see the - un-mangled version?? + un-mangled version?? However, without this change, shit doesn't work... accept_context_args - where does this come from? @@ -179,3 +183,4 @@ after BUILD => sub { - expand_component_module + - People wrapping locate_components in Catalyst.pm