X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=TODO;h=60c7a7ef61f12bd216bbef9a5e874c37fef088ed;hb=cc9a49cfb7842ecaf1ffc096ba702a3c7355cbb3;hp=da1026daecc0deb01d596b3e9179c37098946b77;hpb=4af15971a8b23e2b255f20813e23eb27994e710d;p=catagits%2FCatalyst-Runtime.git diff --git a/TODO b/TODO index da1026d..60c7a7e 100644 --- a/TODO +++ b/TODO @@ -24,14 +24,17 @@ subclass of Catalyst::Log, no ::Plugin:: needed. See also: Catalyst::Plugin::Log::Dispatch and http://github.com/willert/catalyst-plugin-log4perl-simple/tree -# REFACTORING +## throw away the restarter and allow using the restarters Plack provides -## The horrible hack for plugin setup - replacing it: +## be smarter about how we use PSGI - not every response needs to be delayed + and streaming + +# The horrible hack for plugin setup - replacing it: * Have a look at the Devel::REPL BEFORE_PLUGIN stuff I wonder if what we need is that combined with plugins-as-roles -## App / ctx split: +# App / ctx split: NOTE - these are notes that t0m thought up after doing back compat for catalyst_component_class, may be inaccurate, wrong or missing things @@ -61,22 +64,54 @@ http://github.com/willert/catalyst-plugin-log4perl-simple/tree ##### Things that work: + - the default container loads all components, calls ACCEPT_CONTEXT() when appropriate, and COMPONENT() when appropriate, behaving like current Catalyst does + + - its possible to create a custom container, and override the components you want. Lifecycle, class, dependencies, all overridable. + + - config files are loaded without Catalyst::Plugin::ConfigLoader + + - per request life cycle somewhat works + + - external modules are loaded just using a custom container, much like Catalyst::Model::Adaptor + ##### Things that don't work: + - expand_component_module + + - Some back compat + - wrappers around setup_component, setup_components in Catalyst.pm + - $instance->expand_modules + - search_extra + - Crazy tests for things such as: + sub COMPONENT { + ... + *${appclass}::Model::TopLevel::GENERATED::ACCEPT_CONTEXT = sub { ... }; + ... + } + ##### Need planning, have questions: -### Next steps - planned: + - per request life cycle - - some imports need to get the importing package in Catalyst::IOC + - sugar - we should discuss the syntax with rafl and edenc + - what's missing? - - test values directly instead of serializing them over http in t/lib/TestCustomContainer.pm + - when / when not COMPONENT should be called - - 16:01 < shadowpaste> "t0m" at 217.168.150.38 pasted "more explicit? thoughts?" (13 lines) at http://paste.scsys.co.uk/131520 + - locate_components service vs setup_components method + - can we be more lazy? + - should setup_components be a service that things like the ->component lookup + can depend on? - - make ACCEPT_CONTEXT and COMPONENT optional in Catalyst::IOC::BlockInjection and Catalyst::IOC::ConstructorInjection - - Create COMPONENTSingleton life cycle + - There are a few more FIXMEs, idk if any relevant here + +### Next steps - planned: + + - some imports need to get the importing package in Catalyst::IOC + - done - needs testing - Back compat for Catalyst.pm moved methods (locate_components) + - done - needs testing - Test custom container - writing some tests which verify that the models you think should be @@ -91,7 +126,8 @@ http://github.com/willert/catalyst-plugin-log4perl-simple/tree ### Next steps - less planned: - - Creating service()-like sugar for component + - make ACCEPT_CONTEXT and COMPONENT optional in Catalyst::IOC::BlockInjection and Catalyst::IOC::ConstructorInjection + - Create COMPONENTSingleton life cycle - Test cases for extending the container in an application. - Using the sugar added in the previous item @@ -135,19 +171,3 @@ use Catalyst::IOC; }; 1; - -### To polish off / t0m review - - locate_components service vs setup_components method - - can we be more lazy? - - should setup_components be a service that things like the ->component lookup - can depend on? - -### Known issues - - - Broken $instance->expand_modules() in setup_components and figure - out later how to bring it back - - - expand_component_module - - - People wrapping locate_components in Catalyst.pm