X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=TODO;h=60c7a7ef61f12bd216bbef9a5e874c37fef088ed;hb=8354af27e4f5e77a5e77db228164d3502f5e9b17;hp=d88fce5102ec0817b9fc2b4c860bd30adf0b68ab;hpb=19c64905295c1483ceaa41d0ba498b52bf4fab5e;p=catagits%2FCatalyst-Runtime.git diff --git a/TODO b/TODO index d88fce5..60c7a7e 100644 --- a/TODO +++ b/TODO @@ -24,14 +24,17 @@ subclass of Catalyst::Log, no ::Plugin:: needed. See also: Catalyst::Plugin::Log::Dispatch and http://github.com/willert/catalyst-plugin-log4perl-simple/tree -# REFACTORING +## throw away the restarter and allow using the restarters Plack provides -## The horrible hack for plugin setup - replacing it: +## be smarter about how we use PSGI - not every response needs to be delayed + and streaming + +# The horrible hack for plugin setup - replacing it: * Have a look at the Devel::REPL BEFORE_PLUGIN stuff I wonder if what we need is that combined with plugins-as-roles -## App / ctx split: +# App / ctx split: NOTE - these are notes that t0m thought up after doing back compat for catalyst_component_class, may be inaccurate, wrong or missing things @@ -57,26 +60,114 @@ http://github.com/willert/catalyst-plugin-log4perl-simple/tree ## GSOC -### Next large steps: +### Final steps for GSOC + +##### Things that work: + + - the default container loads all components, calls ACCEPT_CONTEXT() when appropriate, and COMPONENT() when appropriate, behaving like current Catalyst does + + - its possible to create a custom container, and override the components you want. Lifecycle, class, dependencies, all overridable. + + - config files are loaded without Catalyst::Plugin::ConfigLoader + + - per request life cycle somewhat works + + - external modules are loaded just using a custom container, much like Catalyst::Model::Adaptor + +##### Things that don't work: + + - expand_component_module + + - Some back compat + - wrappers around setup_component, setup_components in Catalyst.pm + - $instance->expand_modules + - search_extra + - Crazy tests for things such as: + sub COMPONENT { + ... + *${appclass}::Model::TopLevel::GENERATED::ACCEPT_CONTEXT = sub { ... }; + ... + } + +##### Need planning, have questions: + + - per request life cycle + + - sugar - we should discuss the syntax with rafl and edenc + - what's missing? + + - when / when not COMPONENT should be called + + - locate_components service vs setup_components method + - can we be more lazy? + - should setup_components be a service that things like the ->component lookup + can depend on? + + - There are a few more FIXMEs, idk if any relevant here + +### Next steps - planned: + + - some imports need to get the importing package in Catalyst::IOC + - done - needs testing + + - Back compat for Catalyst.pm moved methods (locate_components) + - done - needs testing + + - Test custom container + - writing some tests which verify that the models you think should be + there are there, and that they received their dependencies as arguments + - i.e. Model::Bar should get params { foo => $model_foo } when being + constructed, etc + - Need to test that if you have a standard component Frotz + and a customized component Fnar, and Fnar depends on Frotz + - And yeah, some tests that the customised components actually work via + $c->model('Foo'), and that COMPONENT is called (or not called) + as appropiate and that ACCEPT_CONTEXT is called (or not) as appropriate - - Moving setup_components etc into the container +### Next steps - less planned: - - This is so that you can just load the container and get models etc from it, - without loading Catalyst. + - make ACCEPT_CONTEXT and COMPONENT optional in Catalyst::IOC::BlockInjection and Catalyst::IOC::ConstructorInjection + - Create COMPONENTSingleton life cycle - - Allowing people to change component lifecycles + - Test cases for extending the container in an application. + - Using the sugar added in the previous item + - Test when Model::Foo depends_on Model::Bar + - Test for component Foo => ( lifecycle => 'Singleton', class => 'My::External::Class', dependencies => { config => depends_on("config") } ) + - Fix ^^ so that you can get your component's namespaced config nicely. - - This is done by being able to use an alternate Service class.. + - Tests for using the container outside of Catalyst + - Custom container which adds some (very simple) services which are initialized from + the application config file (note plain services, not components) + - Depend on (and test) these inside Catalyst + - Test loading container outside Catalyst, and these services working + - Test Catalyst / MyApp is not loaded - I.E. We currently force everything to do Catalyst/IOC/Service/WithAcceptContext.pm, but - things without an ACCEPT_CONTEXT could just not bother, and it would be nice to have - one that cached the object in request scope (i.e. Catalyst::Component::InstancePerContext) - etc. +#### Extending my app, notes - However we need to work out an interface for people to setup / configure this. +Basically try to implement something like this (starting out without the sugar!), and see how it breaks +and what needs to be done to fix it! -### To polish off +##### Eventual syntax - - Document current methods - - + $class->container->get_sub_container('model')->make_single_default; -+ $class->container->get_sub_container('view')->make_single_default; +package MyApp::Container; +use Catalyst::IOC; + + container $self, as { + container model => as { + component Foo => (); # As per default! + component Bar => (dependencies => ['/model/Foo']); # Magic! + component Baz => ( lifecycle => 'InstancePerContext ); + component Quux => ( lifecycle => 'Singleton' ); # ACCEPT_CONTEXT not called + # Catalyst::Model::Adaptor example + conponent Fnar => ( lifecycle => 'Singleton', class => 'My::External::Class', dependencies => { config => depends_on('config')} ); + # ^^ FIXME - gets whole config, not Model::Foo + # There should be a 'nice' way to get the 'standard' config + }; + # Note - implementation of BB may need to be changed to support making sure existing + # services actually get overridden. not sure how the default container behaves when doing that + # above code would build the constructor injection as it currently does, + # defaulting to the class name in the right namespace as declared by the surrounding container + # as well as adding using the catalyst-specific service class + }; + +1;