X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=TODO;h=0ced7bf8707987d3c824ef16c5d83aedcda7f721;hb=2bf1bef68ac04b7458dc9084d591582421fb3725;hp=2c5f967e57a2ac95d0cf998c030d6306d3f4ab78;hpb=f8d5957c64993bac51c97f6b18d6bf0d6fad3f45;p=catagits%2FCatalyst-Runtime.git diff --git a/TODO b/TODO index 2c5f967..0ced7bf 100644 --- a/TODO +++ b/TODO @@ -57,34 +57,6 @@ http://github.com/willert/catalyst-plugin-log4perl-simple/tree ## GSOC -### Next large steps, planned: - -For all components that have been discovered, in whatever way, we create a service: - - that's a catalyst component service - - which is basically just a constructor injection - - except the constructor name is COMPONENT - - and we're "implicitly" passing along some constructor args - - Lifecycle => Singleton - - - Fix B::B so that Service::WithParametrs' parameters attribute has a builder - - Fix ConstructorInjection so that default parameters are supplied (for accept_context_args) - - Fix ConstructorInjection's 'suffix' - should be called 'config_key' or something, and - should be an attribute on the service (as it never changes), rather than a parameter - to the service - - - We make a 'components' sub container in the main container. - - This gets the ConstructorInjection COMPONENT services, as model_Foo. - - Lifecycle of these services is Singleton - - This simplifies the code for MyApp->components, as it need only list one sub-container - - - We create a second service (depending on the first one) for ACCEPT_CONTEXT - - This has a custom service which calls ACCEPT_CONTEXT when the instance is fetched - - Not Singleton lifecycle - - Note - ACCEPT_CONTEXT can be called on app values - if you have a Model::Foo, with an ACCEPT_CONTEXT - and you call MyApp->model('Foo') then ACCEPT_CONTEXT gets invoked with a $c of 'MyApp' (this is not\ - the normal case, but we need to preserve for compat) - ### Next steps - less planned: - Creating service()-like sugar for component @@ -92,7 +64,15 @@ For all components that have been discovered, in whatever way, we create a servi - Test cases for extending the container in an application. - Using the sugar added in the previous item - Test when Model::Foo depends_on Model::Bar + - Test for component Foo => ( lifecycle => 'Singleton', class => 'My::External::Class', dependencies => { config => depends_on("config") } ) + - Fix ^^ so that you can get your component's namespaced config nicely. + - Tests for using the container outside of Catalyst + - Custom container which adds some (very simple) services which are initialized from + the application config file (note plain services, not components) + - Depend on (and test) these inside Catalyst + - Test loading container outside Catalyst, and these services working + - Test Catalyst / MyApp is not loaded #### Extending my app, notes @@ -104,12 +84,16 @@ and what needs to be done to fix it! package MyApp::Container; use Catalyst::IOC; - container $self, as { + container $self, as { container model => as { component Foo => (); # As per default! component Bar => (dependencies => ['/model/Foo']); # Magic! component Baz => ( lifecycle => 'InstancePerContext ); component Quux => ( lifecycle => 'Singleton' ); # ACCEPT_CONTEXT not called + # Catalyst::Model::Adaptor example + conponent Fnar => ( lifecycle => 'Singleton', class => 'My::External::Class', dependencies => { config => depends_on('config')} ); + # ^^ FIXME - gets whole config, not Model::Foo + # There should be a 'nice' way to get the 'standard' config }; # Note - implementation of BB may need to be changed to support making sure existing # services actually get overridden. not sure how the default container behaves when doing that @@ -145,10 +129,11 @@ after BUILD => sub { ### To polish off / t0m review - +Same as L, but for controllers. The difference is - +that there is no ACCEPT_CONTEXT for controllers. - ^^ This is wrong!! - + locate_components service vs setup_components method + - can we be more lazy? + - should setup_components be a service that things like the ->component lookup + can depend on? + - my $accept_context_args = $self->param('accept_context_args'); + my $accept_context_args = $params{accept_context_args}; ^^ This (may be) wrong! I am thinking the service should be allowed to mangle the