X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=Size.xs;h=654ff39ae5da72840ad67739c73e48b969036345;hb=6ec51ae0066a3ae0165701ef644f20b01af516f3;hp=69cd815e95c70706987c813faa40817cc3cc705a;hpb=e9716740608f4872c590a9120187210c04c2778c;p=p5sagit%2FDevel-Size.git

diff --git a/Size.xs b/Size.xs
index 69cd815..654ff39 100644
--- a/Size.xs
+++ b/Size.xs
@@ -1,8 +1,18 @@
+#define PERL_NO_GET_CONTEXT
+
 #include "EXTERN.h"
 #include "perl.h"
 #include "XSUB.h"
 #include "ppport.h"
 
+/* Not yet in ppport.h */
+#ifndef CvISXSUB
+#  define CvISXSUB(cv)  (CvXSUB(cv) ? TRUE : FALSE)
+#endif
+#ifndef SvRV_const
+#  define SvRV_const(rv) SvRV(rv)
+#endif
+
 #ifdef _MSC_VER 
 /* "structured exception" handling is a Microsoft extension to C and C++.
    It's *not* C++ exception handling - C++ exception handling can't capture
@@ -20,27 +30,38 @@
 # define __attribute__(x)
 #endif
 
-static int regex_whine;
-static int fm_whine;
-static int dangle_whine = 0;
-
 #if 0 && defined(DEBUGGING)
 #define dbg_printf(x) printf x
 #else
 #define dbg_printf(x)
 #endif
 
-#define TAG //printf( "# %s(%d)\n", __FILE__, __LINE__ )
+#define TAG /* printf( "# %s(%d)\n", __FILE__, __LINE__ ) */
 #define carp puts
 
-#define ALIGN_BITS  ( sizeof(void*) >> 1 )
-#define BIT_BITS    3
-#define BYTE_BITS   14
-#define SLOT_BITS   ( sizeof( void*) * 8 ) - ( ALIGN_BITS + BIT_BITS + BYTE_BITS )
-#define BYTES_PER_SLOT  1 << BYTE_BITS
-#define TRACKING_SLOTS  8192 // max. 8192 for 4GB/32-bit machine
+/* The idea is to have a tree structure to store 1 bit per possible pointer
+   address. The lowest 16 bits are stored in a block of 8092 bytes.
+   The blocks are in a 256-way tree, indexed by the reset of the pointer.
+   This can cope with 32 and 64 bit pointers, and any address space layout,
+   without excessive memory needs. The assumption is that your CPU cache
+   works :-) (And that we're not going to bust it)  */
 
-typedef char* TRACKING[ TRACKING_SLOTS ];
+#define ALIGN_BITS  ( sizeof(void*) >> 1 )
+#define BYTE_BITS    3
+#define LEAF_BITS   (16 - BYTE_BITS)
+#define LEAF_MASK   0x1FFF
+
+struct state {
+    UV total_size;
+    bool regex_whine;
+    bool fm_whine;
+    bool dangle_whine;
+    bool go_yell;
+    /* My hunch (not measured) is that for most architectures pointers will
+       start with 0 bits, hence the start of this array will be hot, and the
+       end unused. So put the flags next to the hot end.  */
+    void *tracking[256];
+};
 
 /* 
     Checks to see if thing is in the bitstring. 
@@ -48,57 +69,99 @@ typedef char* TRACKING[ TRACKING_SLOTS ];
     notes thing in the segmented bitstring.
  */
 static bool
-check_new(TRACKING *tv, const void *const p) {
-    unsigned long slot =  (unsigned long)p >> (SLOT_BITS + BIT_BITS + ALIGN_BITS);
-    unsigned int  byte = ((unsigned long)p >> (ALIGN_BITS + BIT_BITS)) & 0x00003fffU;
-    unsigned int  bit  = ((unsigned long)p >> ALIGN_BITS) & 0x00000007U;
-    unsigned int  nop  =  (unsigned long)p & 0x3U;
-    
-    assert(tv);
+check_new(struct state *st, const void *const p) {
+    unsigned int bits = 8 * sizeof(void*);
+    const size_t raw_p = PTR2nat(p);
+    /* This effectively rotates the value right by the number of low always-0
+       bits in an aligned pointer. The assmption is that most (if not all)
+       pointers are aligned, and these will be in the same chain of nodes
+       (and hence hot in the cache) but we can still deal with any unaligned
+       pointers.  */
+    const size_t cooked_p
+	= (raw_p >> ALIGN_BITS) | (raw_p << (bits - BYTE_BITS));
+    const U8 this_bit = 1 << (cooked_p & 0x7);
+    U8 **leaf_p;
+    U8 *leaf;
+    unsigned int i;
+    void **tv_p = (void **) (st->tracking);
+
     if (NULL == p) return FALSE;
     TRY_TO_CATCH_SEGV { 
         const char c = *(const char *)p;
     }
     CAUGHT_EXCEPTION {
-        if( dangle_whine ) 
+        if (st->dangle_whine) 
             warn( "Devel::Size: Encountered invalid pointer: %p\n", p );
         return FALSE;
     }
-    dbg_printf((
-        "address: %p slot: %p byte: %4x bit: %4x nop:%x\n",
-        p, slot, byte, bit, nop
-    ));
     TAG;    
-    if( slot >= TRACKING_SLOTS ) {
-        die( "Devel::Size: Please rebuild D::S with TRACKING_SLOTS > %u\n", slot );
-    }
-    TAG;    
-    if( (*tv)[ slot ] == NULL ) {
-        Newz( 0xfc0ff, (*tv)[ slot ], BYTES_PER_SLOT, char );
-    }
-    TAG;    
-    if( (*tv)[ slot ][ byte ] & ( 1 << bit ) ) {
-        return FALSE;
-    }
-    TAG;    
-    (*tv)[ slot ][ byte ] |= ( 1 << bit );
+
+    bits -= 8;
+    /* bits now 24 (32 bit pointers) or 56 (64 bit pointers) */
+
+    /* First level is always present.  */
+    do {
+	i = (unsigned int)((cooked_p >> bits) & 0xFF);
+	if (!tv_p[i])
+	    Newxz(tv_p[i], 256, void *);
+	tv_p = (void **)(tv_p[i]);
+	bits -= 8;
+    } while (bits > LEAF_BITS + BYTE_BITS);
+    /* bits now 16 always */
+#if !defined(MULTIPLICITY) || PERL_VERSION > 8 || (PERL_VERSION == 8 && PERL_SUBVERSION > 8)
+    /* 5.8.8 and early have an assert() macro that uses Perl_croak, hence needs
+       a my_perl under multiplicity  */
+    assert(bits == 16);
+#endif
+    leaf_p = (U8 **)tv_p;
+    i = (unsigned int)((cooked_p >> bits) & 0xFF);
+    if (!leaf_p[i])
+	Newxz(leaf_p[i], 1 << LEAF_BITS, U8);
+    leaf = leaf_p[i];
+
     TAG;    
+
+    i = (unsigned int)((cooked_p >> BYTE_BITS) & LEAF_MASK);
+
+    if(leaf[i] & this_bit)
+	return FALSE;
+
+    leaf[i] |= this_bit;
     return TRUE;
 }
 
 static void
-free_tracking(TRACKING *tv)
+free_tracking_at(void **tv, int level)
 {
-  int i;
-  /* Clean up after ourselves */
-  for( i = 0; i < TRACKING_SLOTS; ++i ) {
-    if( (*tv)[ i ] )
-        Safefree( (*tv)[ i ] );
-  }
-  Safefree( tv );    
+    int i = 255;
+
+    if (--level) {
+	/* Nodes */
+	do {
+	    if (tv[i]) {
+		free_tracking_at(tv[i], level);
+		Safefree(tv[i]);
+	    }
+	} while (i--);
+    } else {
+	/* Leaves */
+	do {
+	    if (tv[i])
+		Safefree(tv[i]);
+	} while (i--);
+    }
 }
 
-UV thing_size(const SV *const, TRACKING *);
+static void
+free_state(struct state *st)
+{
+    const int top_level = (sizeof(void *) * 8 - LEAF_BITS - BYTE_BITS) / 8;
+    free_tracking_at((void **)st->tracking, top_level);
+    Safefree(st);
+}
+
+static bool sv_size(pTHX_ struct state *, const SV *const, bool recurse);
+
 typedef enum {
     OPc_NULL,   /* 0 */
     OPc_BASEOP, /* 1 */
@@ -232,179 +295,139 @@ cc_opclass(const OP * const o)
 #define NV double
 #endif
 
-static int go_yell = 1;
-
 /* Figure out how much magic is attached to the SV and return the
    size */
-IV magic_size(const SV * const thing, TRACKING *tv) {
-  IV total_size = 0;
+static void
+magic_size(const SV * const thing, struct state *st) {
   MAGIC *magic_pointer;
 
   /* Is there any? */
   if (!SvMAGIC(thing)) {
     /* No, bail */
-    return 0;
+    return;
   }
 
   /* Get the base magic pointer */
   magic_pointer = SvMAGIC(thing);
 
   /* Have we seen the magic pointer? */
-  while (magic_pointer && check_new(tv, magic_pointer)) {
-    total_size += sizeof(MAGIC);
+  while (check_new(st, magic_pointer)) {
+    st->total_size += sizeof(MAGIC);
 
     TRY_TO_CATCH_SEGV {
         /* Have we seen the magic vtable? */
-        if (magic_pointer->mg_virtual &&
-        check_new(tv, magic_pointer->mg_virtual)) {
-          total_size += sizeof(MGVTBL);
+        if (check_new(st, magic_pointer->mg_virtual)) {
+          st->total_size += sizeof(MGVTBL);
         }
 
-        /* Get the next in the chain */ // ?try
+        /* Get the next in the chain */
         magic_pointer = magic_pointer->mg_moremagic;
     }
     CAUGHT_EXCEPTION { 
-        if( dangle_whine ) 
+        if (st->dangle_whine) 
             warn( "Devel::Size: Encountered bad magic at: %p\n", magic_pointer );
     }
   }
-  return total_size;
 }
 
-UV regex_size(const REGEXP * const baseregex, TRACKING *tv) {
-  UV total_size = 0;
+static void
+check_new_and_strlen(struct state *st, const char *const p) {
+    if(check_new(st, p))
+	st->total_size += 1 + strlen(p);
+}
 
-  total_size += sizeof(REGEXP);
+static void
+regex_size(const REGEXP * const baseregex, struct state *st) {
+    if(!check_new(st, baseregex))
+	return;
+  st->total_size += sizeof(REGEXP);
 #if (PERL_VERSION < 11)     
   /* Note the size of the paren offset thing */
-  total_size += sizeof(I32) * baseregex->nparens * 2;
-  total_size += strlen(baseregex->precomp);
+  st->total_size += sizeof(I32) * baseregex->nparens * 2;
+  st->total_size += strlen(baseregex->precomp);
 #else
-  total_size += sizeof(struct regexp);
-  total_size += sizeof(I32) * SvANY(baseregex)->nparens * 2;
-  /*total_size += strlen(SvANY(baseregex)->subbeg);*/
+  st->total_size += sizeof(struct regexp);
+  st->total_size += sizeof(I32) * SvANY(baseregex)->nparens * 2;
+  /*st->total_size += strlen(SvANY(baseregex)->subbeg);*/
 #endif
-  if (go_yell && !regex_whine) {
+  if (st->go_yell && !st->regex_whine) {
     carp("Devel::Size: Calculated sizes for compiled regexes are incompatible, and probably always will be");
-    regex_whine = 1;
+    st->regex_whine = 1;
   }
-
-  return total_size;
 }
 
-UV op_size(const OP * const baseop, TRACKING *tv) {
-  UV total_size = 0;
-  TRY_TO_CATCH_SEGV {
-      TAG;
-      if (check_new(tv, baseop->op_next)) {
-           total_size += op_size(baseop->op_next, tv);
-      }
-      TAG;
-      switch (cc_opclass(baseop)) {
-      case OPc_BASEOP: TAG;
-        total_size += sizeof(struct op);
-        TAG;break;
-      case OPc_UNOP: TAG;
-        total_size += sizeof(struct unop);
-        if (check_new(tv, cUNOPx(baseop)->op_first)) {
-          total_size += op_size(cUNOPx(baseop)->op_first, tv);
-        }
-        TAG;break;
-      case OPc_BINOP: TAG;
-        total_size += sizeof(struct binop);
-        if (check_new(tv, cBINOPx(baseop)->op_first)) {
-          total_size += op_size(cBINOPx(baseop)->op_first, tv);
-        }  
-        if (check_new(tv, cBINOPx(baseop)->op_last)) {
-          total_size += op_size(cBINOPx(baseop)->op_last, tv);
-        }
-        TAG;break;
-      case OPc_LOGOP: TAG;
-        total_size += sizeof(struct logop);
-        if (check_new(tv, cLOGOPx(baseop)->op_first)) {
-          total_size += op_size(cBINOPx(baseop)->op_first, tv);
-        }  
-        if (check_new(tv, cLOGOPx(baseop)->op_other)) {
-          total_size += op_size(cLOGOPx(baseop)->op_other, tv);
-        }
-        TAG;break;
-      case OPc_LISTOP: TAG;
-        total_size += sizeof(struct listop);
-        if (check_new(tv, cLISTOPx(baseop)->op_first)) {
-          total_size += op_size(cLISTOPx(baseop)->op_first, tv);
-        }  
-        if (check_new(tv, cLISTOPx(baseop)->op_last)) {
-          total_size += op_size(cLISTOPx(baseop)->op_last, tv);
-        }
-        TAG;break;
-      case OPc_PMOP: TAG;
-        total_size += sizeof(struct pmop);
-        if (check_new(tv, cPMOPx(baseop)->op_first)) {
-          total_size += op_size(cPMOPx(baseop)->op_first, tv);
-        }  
-        if (check_new(tv, cPMOPx(baseop)->op_last)) {
-          total_size += op_size(cPMOPx(baseop)->op_last, tv);
-        }
+static void
+op_size(pTHX_ const OP * const baseop, struct state *st)
+{
+    TRY_TO_CATCH_SEGV {
+	TAG;
+	if(!check_new(st, baseop))
+	    return;
+	TAG;
+	op_size(aTHX_ baseop->op_next, st);
+	TAG;
+	switch (cc_opclass(baseop)) {
+	case OPc_BASEOP: TAG;
+	    st->total_size += sizeof(struct op);
+	    TAG;break;
+	case OPc_UNOP: TAG;
+	    st->total_size += sizeof(struct unop);
+	    op_size(aTHX_ cUNOPx(baseop)->op_first, st);
+	    TAG;break;
+	case OPc_BINOP: TAG;
+	    st->total_size += sizeof(struct binop);
+	    op_size(aTHX_ cBINOPx(baseop)->op_first, st);
+	    op_size(aTHX_ cBINOPx(baseop)->op_last, st);
+	    TAG;break;
+	case OPc_LOGOP: TAG;
+	    st->total_size += sizeof(struct logop);
+	    op_size(aTHX_ cBINOPx(baseop)->op_first, st);
+	    op_size(aTHX_ cLOGOPx(baseop)->op_other, st);
+	    TAG;break;
+	case OPc_LISTOP: TAG;
+	    st->total_size += sizeof(struct listop);
+	    op_size(aTHX_ cLISTOPx(baseop)->op_first, st);
+	    op_size(aTHX_ cLISTOPx(baseop)->op_last, st);
+	    TAG;break;
+	case OPc_PMOP: TAG;
+	    st->total_size += sizeof(struct pmop);
+	    op_size(aTHX_ cPMOPx(baseop)->op_first, st);
+	    op_size(aTHX_ cPMOPx(baseop)->op_last, st);
 #if PERL_VERSION < 9 || (PERL_VERSION == 9 && PERL_SUBVERSION < 5)
-        if (check_new(tv, cPMOPx(baseop)->op_pmreplroot)) {
-          total_size += op_size(cPMOPx(baseop)->op_pmreplroot, tv);
-        }
-        if (check_new(tv, cPMOPx(baseop)->op_pmreplstart)) {
-          total_size += op_size(cPMOPx(baseop)->op_pmreplstart, tv);
-        }
-        if (check_new(tv, cPMOPx(baseop)->op_pmnext)) {
-          total_size += op_size((OP *)cPMOPx(baseop)->op_pmnext, tv);
-        }
+	    op_size(aTHX_ cPMOPx(baseop)->op_pmreplroot, st);
+	    op_size(aTHX_ cPMOPx(baseop)->op_pmreplstart, st);
+	    op_size(aTHX_ (OP *)cPMOPx(baseop)->op_pmnext, st);
 #endif
-        /* This is defined away in perl 5.8.x, but it is in there for
-           5.6.x */
+	    /* This is defined away in perl 5.8.x, but it is in there for
+	       5.6.x */
 #ifdef PM_GETRE
-        if (check_new(tv, PM_GETRE((cPMOPx(baseop))))) {
-          total_size += regex_size(PM_GETRE(cPMOPx(baseop)), tv);
-        }
+	    regex_size(PM_GETRE(cPMOPx(baseop)), st);
 #else
-        if (check_new(tv, cPMOPx(baseop)->op_pmregexp)) {
-          total_size += regex_size(cPMOPx(baseop)->op_pmregexp, tv);
-        }
+	    regex_size(cPMOPx(baseop)->op_pmregexp, st);
 #endif
-        TAG;break;
-      case OPc_SVOP: TAG;
-        total_size += sizeof(struct pmop);
-        if (check_new(tv, cSVOPx(baseop)->op_sv)) {
-          total_size += thing_size(cSVOPx(baseop)->op_sv, tv);
-        }
-        TAG;break;
+	    TAG;break;
+	case OPc_SVOP: TAG;
+	    st->total_size += sizeof(struct pmop);
+	    sv_size(aTHX_ st, cSVOPx(baseop)->op_sv, TRUE);
+	    TAG;break;
       case OPc_PADOP: TAG;
-        total_size += sizeof(struct padop);
-        TAG;break;
-      case OPc_PVOP: TAG;
-        if (check_new(tv, cPVOPx(baseop)->op_pv)) {
-          total_size += strlen(cPVOPx(baseop)->op_pv);
-        }
-      case OPc_LOOP: TAG;
-        total_size += sizeof(struct loop);
-        if (check_new(tv, cLOOPx(baseop)->op_first)) {
-          total_size += op_size(cLOOPx(baseop)->op_first, tv);
-        }  
-        if (check_new(tv, cLOOPx(baseop)->op_last)) {
-          total_size += op_size(cLOOPx(baseop)->op_last, tv);
-        }
-        if (check_new(tv, cLOOPx(baseop)->op_redoop)) {
-          total_size += op_size(cLOOPx(baseop)->op_redoop, tv);
-        }  
-        if (check_new(tv, cLOOPx(baseop)->op_nextop)) {
-          total_size += op_size(cLOOPx(baseop)->op_nextop, tv);
-        }
-        if (check_new(tv, cLOOPx(baseop)->op_lastop)) {
-          total_size += op_size(cLOOPx(baseop)->op_lastop, tv);
-        }  
-
-        TAG;break;
-      case OPc_COP: TAG;
+	  st->total_size += sizeof(struct padop);
+	  TAG;break;
+	case OPc_PVOP: TAG;
+	    check_new_and_strlen(st, cPVOPx(baseop)->op_pv);
+	case OPc_LOOP: TAG;
+	    st->total_size += sizeof(struct loop);
+	    op_size(aTHX_ cLOOPx(baseop)->op_first, st);
+	    op_size(aTHX_ cLOOPx(baseop)->op_last, st);
+	    op_size(aTHX_ cLOOPx(baseop)->op_redoop, st);
+	    op_size(aTHX_ cLOOPx(baseop)->op_nextop, st);
+	    op_size(aTHX_ cLOOPx(baseop)->op_lastop, st);
+	    TAG;break;
+	case OPc_COP: TAG;
         {
           COP *basecop;
           basecop = (COP *)baseop;
-          total_size += sizeof(struct cop);
+          st->total_size += sizeof(struct cop);
 
           /* Change 33656 by nicholas@mouse-mill on 2008/04/07 11:29:51
           Eliminate cop_label from struct cop by storing a label as the first
@@ -414,24 +437,14 @@ UV op_size(const OP * const baseop, TRACKING *tv) {
           before 5.11 @33656, but later than 5.10, producing slightly too
           small memory sizes on these Perls. */
 #if (PERL_VERSION < 11)
-          if (check_new(tv, basecop->cop_label)) {
-        total_size += strlen(basecop->cop_label);
-          }
+          check_new_and_strlen(st, basecop->cop_label);
 #endif
 #ifdef USE_ITHREADS
-          if (check_new(tv, basecop->cop_file)) {
-        total_size += strlen(basecop->cop_file);
-          }
-          if (check_new(tv, basecop->cop_stashpv)) {
-        total_size += strlen(basecop->cop_stashpv);
-          }
+          check_new_and_strlen(st, basecop->cop_file);
+          check_new_and_strlen(st, basecop->cop_stashpv);
 #else
-          if (check_new(tv, basecop->cop_stash)) {
-        total_size += thing_size((SV *)basecop->cop_stash, tv);
-          }
-          if (check_new(tv, basecop->cop_filegv)) {
-        total_size += thing_size((SV *)basecop->cop_filegv, tv);
-          }
+	  sv_size(aTHX_ st, (SV *)basecop->cop_stash, TRUE);
+	  sv_size(aTHX_ st, (SV *)basecop->cop_filegv, TRUE);
 #endif
 
         }
@@ -441,19 +454,24 @@ UV op_size(const OP * const baseop, TRACKING *tv) {
       }
   }
   CAUGHT_EXCEPTION {
-      if( dangle_whine ) 
+      if (st->dangle_whine) 
           warn( "Devel::Size: Encountered dangling pointer in opcode at: %p\n", baseop );
   }
-  return total_size;
 }
 
 #if PERL_VERSION > 9 || (PERL_VERSION == 9 && PERL_SUBVERSION > 2)
 #  define NEW_HEAD_LAYOUT
 #endif
 
-UV thing_size(const SV * const orig_thing, TRACKING *tv) {
+static bool
+sv_size(pTHX_ struct state *const st, const SV * const orig_thing,
+	const bool recurse) {
   const SV *thing = orig_thing;
-  UV total_size = sizeof(SV);
+
+  if(!check_new(st, thing))
+      return FALSE;
+
+  st->total_size += sizeof(SV);
 
   switch (SvTYPE(thing)) {
     /* Is it undef? */
@@ -464,126 +482,120 @@ UV thing_size(const SV * const orig_thing, TRACKING *tv) {
   case SVt_IV: TAG;
 #ifndef NEW_HEAD_LAYOUT
 #  ifdef PURIFY
-    total_size += sizeof(sizeof(XPVIV));
+    st->total_size += sizeof(sizeof(XPVIV));
 #  else
-    total_size += sizeof(IV);
+    st->total_size += sizeof(IV);
 #  endif
 #endif
+    if(recurse && SvROK(thing))
+	sv_size(aTHX_ st, SvRV_const(thing), TRUE);
     TAG;break;
     /* Is it a float? Like the int, it depends on purify */
   case SVt_NV: TAG;
 #ifdef PURIFY
-    total_size += sizeof(sizeof(XPVNV));
+    st->total_size += sizeof(sizeof(XPVNV));
 #else
-    total_size += sizeof(NV);
+    st->total_size += sizeof(NV);
 #endif
     TAG;break;
 #if (PERL_VERSION < 11)     
     /* Is it a reference? */
   case SVt_RV: TAG;
 #ifndef NEW_HEAD_LAYOUT
-    total_size += sizeof(XRV);
+    st->total_size += sizeof(XRV);
 #endif
+    if(recurse && SvROK(thing))
+	sv_size(aTHX_ st, SvRV_const(thing), TRUE);
     TAG;break;
 #endif
     /* How about a plain string? In which case we need to add in how
        much has been allocated */
   case SVt_PV: TAG;
-    total_size += sizeof(XPV);
-#if (PERL_VERSION < 11)
-    total_size += SvROK(thing) ? thing_size( SvRV(thing), tv) : SvLEN(thing);
-#else
-    total_size += SvLEN(thing);
-#endif
+    st->total_size += sizeof(XPV);
+    if(recurse && SvROK(thing))
+	sv_size(aTHX_ st, SvRV_const(thing), TRUE);
+    else
+	st->total_size += SvLEN(thing);
     TAG;break;
     /* A string with an integer part? */
   case SVt_PVIV: TAG;
-    total_size += sizeof(XPVIV);
-#if (PERL_VERSION < 11)
-    total_size += SvROK(thing) ? thing_size( SvRV(thing), tv) : SvLEN(thing);
-#else
-    total_size += SvLEN(thing);
-#endif
+    st->total_size += sizeof(XPVIV);
+    if(recurse && SvROK(thing))
+	sv_size(aTHX_ st, SvRV_const(thing), TRUE);
+    else
+	st->total_size += SvLEN(thing);
     if(SvOOK(thing)) {
-        total_size += SvIVX(thing);
+        st->total_size += SvIVX(thing);
     }
     TAG;break;
     /* A scalar/string/reference with a float part? */
   case SVt_PVNV: TAG;
-    total_size += sizeof(XPVNV);
-#if (PERL_VERSION < 11)
-    total_size += SvROK(thing) ? thing_size( SvRV(thing), tv) : SvLEN(thing);
-#else
-    total_size += SvLEN(thing);
-#endif
+    st->total_size += sizeof(XPVNV);
+    if(recurse && SvROK(thing))
+	sv_size(aTHX_ st, SvRV_const(thing), TRUE);
+    else
+	st->total_size += SvLEN(thing);
     TAG;break;
   case SVt_PVMG: TAG;
-    total_size += sizeof(XPVMG);
-#if (PERL_VERSION < 11)
-    total_size += SvROK(thing) ? thing_size( SvRV(thing), tv) : SvLEN(thing);
-#else
-    total_size += SvLEN(thing);
-#endif
-    total_size += magic_size(thing, tv);
+    st->total_size += sizeof(XPVMG);
+    if(recurse && SvROK(thing))
+	sv_size(aTHX_ st, SvRV_const(thing), TRUE);
+    else
+	st->total_size += SvLEN(thing);
+    magic_size(thing, st);
     TAG;break;
 #if PERL_VERSION <= 8
   case SVt_PVBM: TAG;
-    total_size += sizeof(XPVBM);
-#if (PERL_VERSION < 11)
-    total_size += SvROK(thing) ? thing_size( SvRV(thing), tv) : SvLEN(thing);
-#else
-    total_size += SvLEN(thing);
-#endif
-    total_size += magic_size(thing, tv);
+    st->total_size += sizeof(XPVBM);
+    if(recurse && SvROK(thing))
+	sv_size(aTHX_ st, SvRV_const(thing), TRUE);
+    else
+	st->total_size += SvLEN(thing);
+    magic_size(thing, st);
     TAG;break;
 #endif
   case SVt_PVLV: TAG;
-    total_size += sizeof(XPVLV);
-#if (PERL_VERSION < 11)
-    total_size += SvROK(thing) ? thing_size( SvRV(thing), tv) : SvLEN(thing);
-#else
-    total_size += SvLEN(thing);
-#endif
-    total_size += magic_size(thing, tv);
+    st->total_size += sizeof(XPVLV);
+    if(recurse && SvROK(thing))
+	sv_size(aTHX_ st, SvRV_const(thing), TRUE);
+    else
+	st->total_size += SvLEN(thing);
+    magic_size(thing, st);
     TAG;break;
     /* How much space is dedicated to the array? Not counting the
        elements in the array, mind, just the array itself */
   case SVt_PVAV: TAG;
-    total_size += sizeof(XPVAV);
+    st->total_size += sizeof(XPVAV);
     /* Is there anything in the array? */
     if (AvMAX(thing) != -1) {
       /* an array with 10 slots has AvMax() set to 9 - te 2007-04-22 */
-      total_size += sizeof(SV *) * (AvMAX(thing) + 1);
-      dbg_printf(("total_size: %li AvMAX: %li av_len: $i\n", total_size, AvMAX(thing), av_len((AV*)thing)));
+      st->total_size += sizeof(SV *) * (AvMAX(thing) + 1);
+      dbg_printf(("total_size: %li AvMAX: %li av_len: $i\n", st->total_size, AvMAX(thing), av_len((AV*)thing)));
     }
     /* Add in the bits on the other side of the beginning */
 
     dbg_printf(("total_size %li, sizeof(SV *) %li, AvARRAY(thing) %li, AvALLOC(thing)%li , sizeof(ptr) %li \n", 
-    total_size, sizeof(SV*), AvARRAY(thing), AvALLOC(thing), sizeof( thing )));
+    st->total_size, sizeof(SV*), AvARRAY(thing), AvALLOC(thing), sizeof( thing )));
 
     /* under Perl 5.8.8 64bit threading, AvARRAY(thing) was a pointer while AvALLOC was 0,
        resulting in grossly overstated sized for arrays. Technically, this shouldn't happen... */
     if (AvALLOC(thing) != 0) {
-      total_size += (sizeof(SV *) * (AvARRAY(thing) - AvALLOC(thing)));
+      st->total_size += (sizeof(SV *) * (AvARRAY(thing) - AvALLOC(thing)));
       }
 #if (PERL_VERSION < 9)
     /* Is there something hanging off the arylen element?
        Post 5.9.something this is stored in magic, so will be found there,
        and Perl_av_arylen_p() takes a non-const AV*, hence compilers rightly
        complain about AvARYLEN() passing thing to it.  */
-    if (AvARYLEN(thing)) {
-      if (check_new(tv, AvARYLEN(thing))) {
-    total_size += thing_size(AvARYLEN(thing), tv);
-      }
-    }
+    sv_size(aTHX_ st, AvARYLEN(thing), TRUE);
 #endif
-    total_size += magic_size(thing, tv);
+    magic_size(thing, st);
     TAG;break;
   case SVt_PVHV: TAG;
     /* First the base struct */
-    total_size += sizeof(XPVHV);
+    st->total_size += sizeof(XPVHV);
     /* Now the array of buckets */
-    total_size += (sizeof(HE *) * (HvMAX(thing) + 1));
+    st->total_size += (sizeof(HE *) * (HvMAX(thing) + 1));
     /* Now walk the bucket chain */
     if (HvARRAY(thing)) {
       HE *cur_entry;
@@ -591,132 +603,84 @@ UV thing_size(const SV * const orig_thing, TRACKING *tv) {
       for (cur_bucket = 0; cur_bucket <= HvMAX(thing); cur_bucket++) {
         cur_entry = *(HvARRAY(thing) + cur_bucket);
         while (cur_entry) {
-          total_size += sizeof(HE);
+          st->total_size += sizeof(HE);
           if (cur_entry->hent_hek) {
             /* Hash keys can be shared. Have we seen this before? */
-            if (check_new(tv, cur_entry->hent_hek)) {
-              total_size += HEK_BASESIZE + cur_entry->hent_hek->hek_len + 2;
+            if (check_new(st, cur_entry->hent_hek)) {
+              st->total_size += HEK_BASESIZE + cur_entry->hent_hek->hek_len + 2;
             }
           }
           cur_entry = cur_entry->hent_next;
         }
       }
     }
-    total_size += magic_size(thing, tv);
+    magic_size(thing, st);
     TAG;break;
   case SVt_PVCV: TAG;
-    total_size += sizeof(XPVCV);
-    total_size += magic_size(thing, tv);
-
-    total_size += ((XPVIO *) SvANY(thing))->xpv_len;
-    if (check_new(tv, CvSTASH(thing))) {
-      total_size += thing_size((SV *)CvSTASH(thing), tv);
-    }
-    if (check_new(tv, SvSTASH(thing))) {
-      total_size += thing_size( (SV *)SvSTASH(thing), tv);
-    }
-    if (check_new(tv, CvGV(thing))) {
-      total_size += thing_size((SV *)CvGV(thing), tv);
-    }
-    if (check_new(tv, CvPADLIST(thing))) {
-      total_size += thing_size((SV *)CvPADLIST(thing), tv);
-    }
-    if (check_new(tv, CvOUTSIDE(thing))) {
-      total_size += thing_size((SV *)CvOUTSIDE(thing), tv);
-    }
-    if (check_new(tv, CvSTART(thing))) {
-      total_size += op_size(CvSTART(thing), tv);
-    }
-    if (check_new(tv, CvROOT(thing))) {
-      total_size += op_size(CvROOT(thing), tv);
+    st->total_size += sizeof(XPVCV);
+    magic_size(thing, st);
+
+    st->total_size += ((XPVIO *) SvANY(thing))->xpv_len;
+    sv_size(aTHX_ st, (SV *)CvSTASH(thing), TRUE);
+    sv_size(aTHX_ st, (SV *)SvSTASH(thing), TRUE);
+    sv_size(aTHX_ st, (SV *)CvGV(thing), TRUE);
+    sv_size(aTHX_ st, (SV *)CvPADLIST(thing), TRUE);
+    sv_size(aTHX_ st, (SV *)CvOUTSIDE(thing), TRUE);
+    if (CvISXSUB(thing)) {
+	sv_size(aTHX_ st, cv_const_sv((CV *)thing), TRUE);
+    } else {
+	op_size(aTHX_ CvSTART(thing), st);
+	op_size(aTHX_ CvROOT(thing), st);
     }
 
     TAG;break;
   case SVt_PVGV: TAG;
-    total_size += magic_size(thing, tv);
-    total_size += sizeof(XPVGV);
-    total_size += GvNAMELEN(thing);
+    magic_size(thing, st);
+    st->total_size += sizeof(XPVGV);
+    st->total_size += GvNAMELEN(thing);
 #ifdef GvFILE
     /* Is there a file? */
-    if (GvFILE(thing)) {
-      if (check_new(tv, GvFILE(thing))) {
-    total_size += strlen(GvFILE(thing));
-      }
-    }
+    check_new_and_strlen(st, GvFILE(thing));
 #endif
     /* Is there something hanging off the glob? */
     if (GvGP(thing)) {
-      if (check_new(tv, GvGP(thing))) {
-    total_size += sizeof(GP);
-    {
-      SV *generic_thing;
-      if ((generic_thing = (SV *)(GvGP(thing)->gp_sv))) {
-        total_size += thing_size(generic_thing, tv);
-      }
-      if ((generic_thing = (SV *)(GvGP(thing)->gp_form))) {
-        total_size += thing_size(generic_thing, tv);
-      }
-      if ((generic_thing = (SV *)(GvGP(thing)->gp_av))) {
-        total_size += thing_size(generic_thing, tv);
-      }
-      if ((generic_thing = (SV *)(GvGP(thing)->gp_hv))) {
-        total_size += thing_size(generic_thing, tv);
-      }
-      if ((generic_thing = (SV *)(GvGP(thing)->gp_egv))) {
-        total_size += thing_size(generic_thing, tv);
-      }
-      if ((generic_thing = (SV *)(GvGP(thing)->gp_cv))) {
-        total_size += thing_size(generic_thing, tv);
-      }
-    }
+      if (check_new(st, GvGP(thing))) {
+	  st->total_size += sizeof(GP);
+	  sv_size(aTHX_ st, (SV *)(GvGP(thing)->gp_sv), TRUE);
+	  sv_size(aTHX_ st, (SV *)(GvGP(thing)->gp_form), TRUE);
+	  sv_size(aTHX_ st, (SV *)(GvGP(thing)->gp_av), TRUE);
+	  sv_size(aTHX_ st, (SV *)(GvGP(thing)->gp_hv), TRUE);
+	  sv_size(aTHX_ st, (SV *)(GvGP(thing)->gp_egv), TRUE);
+	  sv_size(aTHX_ st, (SV *)(GvGP(thing)->gp_cv), TRUE);
       }
     }
     TAG;break;
   case SVt_PVFM: TAG;
-    total_size += sizeof(XPVFM);
-    total_size += magic_size(thing, tv);
-    total_size += ((XPVIO *) SvANY(thing))->xpv_len;
-    if (check_new(tv, CvPADLIST(thing))) {
-      total_size += thing_size((SV *)CvPADLIST(thing), tv);
-    }
-    if (check_new(tv, CvOUTSIDE(thing))) {
-      total_size += thing_size((SV *)CvOUTSIDE(thing), tv);
-    }
+    st->total_size += sizeof(XPVFM);
+    magic_size(thing, st);
+    st->total_size += ((XPVIO *) SvANY(thing))->xpv_len;
+    sv_size(aTHX_ st, (SV *)CvPADLIST(thing), TRUE);
+    sv_size(aTHX_ st, (SV *)CvOUTSIDE(thing), TRUE);
 
-    if (go_yell && !fm_whine) {
+    if (st->go_yell && !st->fm_whine) {
       carp("Devel::Size: Calculated sizes for FMs are incomplete");
-      fm_whine = 1;
+      st->fm_whine = 1;
     }
     TAG;break;
   case SVt_PVIO: TAG;
-    total_size += sizeof(XPVIO);
-    total_size += magic_size(thing, tv);
-    if (check_new(tv, (SvPVX_const(thing)))) {
-      total_size += ((XPVIO *) SvANY(thing))->xpv_cur;
+    st->total_size += sizeof(XPVIO);
+    magic_size(thing, st);
+    if (check_new(st, (SvPVX_const(thing)))) {
+      st->total_size += ((XPVIO *) SvANY(thing))->xpv_cur;
     }
     /* Some embedded char pointers */
-    if (check_new(tv, ((XPVIO *) SvANY(thing))->xio_top_name)) {
-      total_size += strlen(((XPVIO *) SvANY(thing))->xio_top_name);
-    }
-    if (check_new(tv, ((XPVIO *) SvANY(thing))->xio_fmt_name)) {
-      total_size += strlen(((XPVIO *) SvANY(thing))->xio_fmt_name);
-    }
-    if (check_new(tv, ((XPVIO *) SvANY(thing))->xio_bottom_name)) {
-      total_size += strlen(((XPVIO *) SvANY(thing))->xio_bottom_name);
-    }
+    check_new_and_strlen(st, ((XPVIO *) SvANY(thing))->xio_top_name);
+    check_new_and_strlen(st, ((XPVIO *) SvANY(thing))->xio_fmt_name);
+    check_new_and_strlen(st, ((XPVIO *) SvANY(thing))->xio_bottom_name);
     /* Throw the GVs on the list to be walked if they're not-null */
-    if (((XPVIO *) SvANY(thing))->xio_top_gv) {
-      total_size += thing_size((SV *)((XPVIO *) SvANY(thing))->xio_top_gv, 
-                   tv);
-    }
-    if (((XPVIO *) SvANY(thing))->xio_bottom_gv) {
-      total_size += thing_size((SV *)((XPVIO *) SvANY(thing))->xio_bottom_gv, 
-                   tv);
-    }
-    if (((XPVIO *) SvANY(thing))->xio_fmt_gv) {
-      total_size += thing_size((SV *)((XPVIO *) SvANY(thing))->xio_fmt_gv, 
-                   tv);
-    }
+    sv_size(aTHX_ st, (SV *)((XPVIO *) SvANY(thing))->xio_top_gv, TRUE);
+    sv_size(aTHX_ st, (SV *)((XPVIO *) SvANY(thing))->xio_bottom_gv, TRUE);
+    sv_size(aTHX_ st, (SV *)((XPVIO *) SvANY(thing))->xio_fmt_gv, TRUE);
 
     /* Only go trotting through the IO structures if they're really
        trottable. If USE_PERLIO is defined we can do this. If
@@ -729,36 +693,39 @@ UV thing_size(const SV * const orig_thing, TRACKING *tv) {
   default:
     warn("Devel::Size: Unknown variable type: %d encountered\n", SvTYPE(thing) );
   }
-  return total_size;
+  return TRUE;
+}
+
+static struct state *
+new_state(pTHX)
+{
+    SV *warn_flag;
+    struct state *st;
+    Newxz(st, 1, struct state);
+    st->go_yell = TRUE;
+    if (NULL != (warn_flag = perl_get_sv("Devel::Size::warn", FALSE))) {
+	st->dangle_whine = st->go_yell = SvIV(warn_flag) ? TRUE : FALSE;
+    }
+    if (NULL != (warn_flag = perl_get_sv("Devel::Size::dangle", FALSE))) {
+	st->dangle_whine = SvIV(warn_flag) ? TRUE : FALSE;
+    }
+    check_new(st, &PL_sv_undef);
+    check_new(st, &PL_sv_no);
+    check_new(st, &PL_sv_yes);
+    return st;
 }
 
 MODULE = Devel::Size        PACKAGE = Devel::Size       
 
 PROTOTYPES: DISABLE
 
-IV
+UV
 size(orig_thing)
      SV *orig_thing
 CODE:
 {
   SV *thing = orig_thing;
-  /* Hash to track our seen pointers */
-  //HV *tracking_hash = newHV();
-  SV *warn_flag;
-  TRACKING *tv;
-  Newz( 0xfc0ff, tv, 1, TRACKING );
-
-  /* Check warning status */
-  go_yell = 0;
-  regex_whine = 0;
-  fm_whine = 0;
-
-  if (NULL != (warn_flag = perl_get_sv("Devel::Size::warn", FALSE))) {
-    dangle_whine = go_yell = SvIV(warn_flag);
-  }
-  if (NULL != (warn_flag = perl_get_sv("Devel::Size::dangle", FALSE))) {
-    dangle_whine = SvIV(warn_flag);
-  }
+  struct state *st = new_state(aTHX);
   
   /* If they passed us a reference then dereference it. This is the
      only way we can check the sizes of arrays and hashes */
@@ -772,53 +739,34 @@ CODE:
   }
 #endif
 
-  RETVAL = thing_size(thing, tv);
-  free_tracking(tv);
+  sv_size(aTHX_ st, thing, FALSE);
+  RETVAL = st->total_size;
+  free_state(st);
 }
 OUTPUT:
   RETVAL
 
 
-IV
+UV
 total_size(orig_thing)
        SV *orig_thing
 CODE:
 {
   SV *thing = orig_thing;
-  /* Hash to track our seen pointers */
-  //HV *tracking_hash;
-  TRACKING *tv;
   /* Array with things we still need to do */
   AV *pending_array;
   IV size = 0;
-  SV *warn_flag;
+  struct state *st = new_state(aTHX);
 
   /* Size starts at zero */
   RETVAL = 0;
 
-  /* Check warning status */
-  go_yell = 0;
-  regex_whine = 0;
-  fm_whine = 0;
-
-  if (NULL != (warn_flag = perl_get_sv("Devel::Size::warn", FALSE))) {
-    dangle_whine = go_yell = SvIV(warn_flag);
-  }
-  if (NULL != (warn_flag = perl_get_sv("Devel::Size::dangle", FALSE))) {
-    dangle_whine = SvIV(warn_flag);
-  }
-
-  /* init these after the go_yell above */
-  //tracking_hash = newHV();
-  Newz( 0xfc0ff, tv, 1, TRACKING );
   pending_array = newAV();
 
-  /* We cannot push HV/AV directly, only the RV. So deref it
-     later (see below for "*** dereference later") and adjust here for
-     the miscalculation.
+  /* If they passed us a reference then dereference it.
      This is the only way we can check the sizes of arrays and hashes. */
   if (SvROK(thing)) {
-      RETVAL -= thing_size(thing, NULL);
+      thing = SvRV(thing);
   } 
 
   /* Put it on the pending array */
@@ -828,11 +776,8 @@ CODE:
   while (av_len(pending_array) >= 0) {
     thing = av_pop(pending_array);
     /* Process it if we've not seen it */
-    if (check_new(tv, thing)) {
+    if (sv_size(aTHX_ st, thing, TRUE)) {
       dbg_printf(("# Found type %i at %p\n", SvTYPE(thing), thing));
-      /* Is it valid? */
-      if (thing) {
-    /* Yes, it is. So let's check the type */
     switch (SvTYPE(thing)) {
     /* fix for bug #24846 (Does not correctly recurse into references in a PVNV-type scalar) */
     case SVt_PVNV: TAG;
@@ -841,8 +786,6 @@ CODE:
         av_push(pending_array, SvRV(thing));
         } 
       TAG;break;
-
-    /* this is the "*** dereference later" part - see above */
 #if (PERL_VERSION < 11)
         case SVt_RV: TAG;
 #else
@@ -913,11 +856,7 @@ CODE:
       TAG;break;
     default:
       TAG;break;
-    }
       }
-      
-      size = thing_size(thing, tv);
-      RETVAL += size;
     } else {
     /* check_new() returned false: */
 #ifdef DEVEL_SIZE_DEBUGGING
@@ -927,7 +866,8 @@ CODE:
     }
   } /* end while */
 
-  free_tracking(tv);
+  RETVAL = st->total_size;
+  free_state(st);
   SvREFCNT_dec(pending_array);
 }
 OUTPUT: