X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=Porting%2Fp4desc;h=0bf79da2e004b2df741c73b17cd2a382f796aca8;hb=1aeab75ab913b2442f1de7300d375422255ad122;hp=7bac3eb1f2d8455e96fa5a92b8c8731a2f0c5908;hpb=95470547e854df745a1dec3565d4ef1ed8634342;p=p5sagit%2Fp5-mst-13.2.git

diff --git a/Porting/p4desc b/Porting/p4desc
index 7bac3eb..0bf79da 100755
--- a/Porting/p4desc
+++ b/Porting/p4desc
@@ -3,7 +3,7 @@
 #
 # Munge "p4 describe ..." output to include new files.
 #
-# Gurusamy Sarathy <gsar@umich.edu>
+# Gurusamy Sarathy <gsar@activestate.com>
 #
 
 use vars qw($thisfile $change $file $fnum $h $v $p4port @addfiles);
@@ -65,7 +65,7 @@ my $cur = m|^Affected files| ... m|^Differences|;
 
 # while we are within range
 if ($cur) {
-    if (m|^\.\.\. (//depot/.+?#\d+) add$|) {
+    if (m{^\.\.\. (//depot/.+?#\d+) (add|branch)$}) {
 	my $newfile = $1;
 	push @addfiles, $newfile;
 	warn "$newfile add, revision != 1!\n" unless $newfile =~ /#1$/;
@@ -90,9 +90,9 @@ sub newfiles {
     my $addfile;
     my $ret = "";
     for $addfile (@addfiles) {
-	my $type = `p4 -p $p4port files $addfile`;
+	my $type = `p4 -p $p4port files '$addfile'`;
 	if ($?) {
-	    warn "$0: `p4 -p $p4port print $addfile` failed, status[$?]\n";
+	    warn "$0: `p4 -p $p4port print '$addfile'` failed, status[$?]\n";
 	    next;
 	}
 	$type =~ m|^//.*\((.+)\)$| or next;
@@ -101,9 +101,9 @@ sub newfiles {
 	    $ret .= "\n==== $addfile ($type) ====\n\n";
 	    next;
 	}
-	my @new = `p4 -p $p4port print $addfile`;
+	my @new = `p4 -p $p4port print '$addfile'`;
 	if ($?) {
-	    die "$0: `p4 -p $p4port print $addfile` failed, status[$?]\n";
+	    die "$0: `p4 -p $p4port print '$addfile'` failed, status[$?]\n";
 	}
 	my $desc = shift @new;		# discard initial description
 	$ret .= "\n==== $addfile ($type) ====\n\n";
@@ -111,6 +111,7 @@ sub newfiles {
 	$lines = "" if @new < 2;
 	$ret .= "\@\@ -0,0 +1$lines \@\@\n";
 	$ret .= join("+","",@new);
+	$ret .= "\n\\ No newline at end of file\n" if $ret !~ /\n$/;
     }
     @addfiles = ();
     return $ret;