X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=Porting%2Fcore-cpan-diff;h=8e3feeb09f3534639feb92cee89bdc57c84f2229;hb=a22f28a4268aa03ce2bafaf594271b8ff764a5f8;hp=b4a5c3502fec8e3a7d38f0b8462cbf99b85d0605;hpb=8c814d1a540c5a07adc0648dc9d2b879bab3d772;p=p5sagit%2Fp5-mst-13.2.git diff --git a/Porting/core-cpan-diff b/Porting/core-cpan-diff index b4a5c35..8e3feeb 100755 --- a/Porting/core-cpan-diff +++ b/Porting/core-cpan-diff @@ -156,7 +156,7 @@ sub run { do_crosscheck($outfh, $cache_dir, $force, \@modules); } else { - do_compare(\@modules, $outfh, $cache_dir, $verbose, $use_diff, + do_compare(\@modules, $outfh, $output_file, $cache_dir, $verbose, $use_diff, $reverse, $diff_opts); } } @@ -166,7 +166,7 @@ sub run { # compare a list of modules against their CPAN equivalents sub do_compare { - my ($modules, $outfh, $cache_dir, $verbose, + my ($modules, $outfh, $output_file, $cache_dir, $verbose, $use_diff, $reverse, $diff_opts) = @_; @@ -190,6 +190,7 @@ sub do_compare { my %seen_dist; for my $module (@$modules) { + warn "Processing $module ...\n" if defined $output_file; print $outfh "\n$module\n" unless $use_diff; my $m = $Maintainers::Modules{$module} @@ -363,12 +364,13 @@ sub do_crosscheck { warn "WARNING: $file:$.: line doesn't have three fields (skipping)\n"; next; } - $modules{$f[0]} = $f[2]; - my $distro = $f[2]; - $distro =~ s{^.*/}{}; + $distro =~ s{^[A-Z]/[A-Z]{2}/}{}; # strip leading A/AB/ + $modules{$f[0]} = $distro; + + (my $short_distro = $distro) =~ s{^.*/}{}; - $distros{distro_base($distro)}{$distro} = 1; + $distros{distro_base($short_distro)}{$distro} = 1; } for my $module (@$modules) { @@ -380,23 +382,19 @@ sub do_crosscheck { next; } - - # given an try like + # given an entry like # Foo::Bar 1.23 foo-bar-1.23.tar.gz, # first compare the module name against Foo::Bar, and failing that, # against foo-bar my $pdist = $m->{DISTRIBUTION}; die "ERROR: $module has no DISTRIBUTION entry\n" unless defined $pdist; - $pdist =~ s{^.*/}{}; my $cdist = $modules{$module}; + (my $short_pdist = $pdist) =~ s{^.*/}{}; - if (defined $cdist) { - $cdist =~ s{^.*/}{}; - } - else { - my $d = $distros{distro_base($pdist)}; + unless (defined $cdist) { + my $d = $distros{distro_base($short_pdist)}; unless (defined $d) { print $outfh "\n$module: Can't determine current CPAN entry\n"; next; @@ -434,7 +432,7 @@ sub get_map { my $ext; for (@$perl_files) { - if (m{^(ext/[^/]+/)}) { + if (m{^((?:ext|cpan)/[^/]+/)}) { if (defined $ext and $ext ne $1) { # more than one ext/$ext/ undef $ext;