X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=Porting%2Fcheck83.pl;h=5851d9ffb63246cb1a5b288fcbf8445265bbbd15;hb=c727eafaa06ca49aa032ce478f9a6e09bd19fda2;hp=51b2b11b8a20096dfb5e9d342333f62f46298d5c;hpb=8c284f99fe2ca8105343599e3b9e2f250ac27804;p=p5sagit%2Fp5-mst-13.2.git

diff --git a/Porting/check83.pl b/Porting/check83.pl
index 51b2b11..5851d9f 100644
--- a/Porting/check83.pl
+++ b/Porting/check83.pl
@@ -1,12 +1,34 @@
-#!/usr/local/bin/perl
+#!/usr/bin/perl
 
-# Check whether there are naming conflicts when names are truncated
-# to the DOSish case-ignoring 8.3 format
+# Check whether there are naming conflicts when names are truncated to
+# the DOSish case-ignoring 8.3 format, plus other portability no-nos.
+
+# The "8.3 rule" is loose: "if reducing the directory entry names
+# within one directory to lowercase and 8.3-truncated causes
+# conflicts, that's a bad thing".  So the rule is NOT the strict
+# "no filename shall be longer than eight and a suffix if present
+# not longer than three".
+
+# TODO: this doesn't actually check for *directory entries*, what this
+# does is to check for *MANIFEST entries*, which are only files, not
+# directories.  In other words, a 8.3 conflict between a directory
+# "abcdefghx" and a file "abcdefghy" wouldn't be noticed-- or even for
+# a directory "abcdefgh" and a file "abcdefghy".
 
 sub eight_dot_three {
     my ($dir, $base, $ext) = ($_[0] =~ m!^(?:(.+)/)?([^/.]+)(?:\.([^/.]+))?$!);
+    my $file = $base . defined $ext ? ".$ext" : "";
     $base = substr($base, 0, 8);
     $ext  = substr($ext,  0, 3) if defined $ext;
+    if ($dir =~ /\./)  {
+	warn "$dir: directory name contains '.'\n";
+    }
+    if ($file =~ /[^A-Za-z0-9\._-]/) {
+	warn "$file: filename contains non-portable characters\n";
+    }
+    if (length $file > 30) {
+	warn "$file: filename longer than 30 characters\n"; # make up a limit
+    }
     if (defined $dir) {
 	return ($dir, defined $ext ? "$dir/$base.$ext" : "$dir/$base");
     } else {