X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=Name.xs;h=c2c9b3c0f0cd7fea5ec744902c0e0f062f83652c;hb=master;hp=20c9b7162fc92320da79b94b062f64dafc6c8ab5;hpb=24f50a799301562be9f7b22ce606fec869727e73;p=p5sagit%2FSub-Name.git

diff --git a/Name.xs b/Name.xs
index 20c9b71..c2c9b3c 100644
--- a/Name.xs
+++ b/Name.xs
@@ -7,6 +7,12 @@
 #include "EXTERN.h"
 #include "perl.h"
 #include "XSUB.h"
+#define NEED_sv_2pv_flags
+#define NEED_newSVpvn_flags
+#define NEED_gv_fetchpvn_flags
+#define NEED_sv_catpvn_flags
+#define NEED_croak_xs_usage
+#include "ppport.h"
 
 static MGVTBL subname_vtbl;
 
@@ -18,6 +24,37 @@ static MGVTBL subname_vtbl;
 #define SvMAGIC_set(sv, val) (SvMAGIC(sv) = (val))
 #endif
 
+#ifndef Newxz
+#define Newxz(ptr, num, type)	Newz(0, ptr, num, type)
+#endif
+
+#ifndef HvNAMELEN_get
+#define HvNAMELEN_get(stash) strlen(HvNAME(stash))
+#endif
+
+#ifndef HvNAMEUTF8
+#define HvNAMEUTF8(stash) 0
+#endif
+
+#ifndef GvNAMEUTF8
+#ifdef GvNAME_HEK
+#define GvNAMEUTF8(gv) HEK_UTF8(GvNAME_HEK(gv))
+#else
+#define GvNAMEUTF8(gv) 0
+#endif
+#endif
+
+#ifndef SV_CATUTF8
+#define SV_CATUTF8 0
+#endif
+
+#ifndef SV_CATBYTES
+#define SV_CATBYTES 0
+#endif
+
+#ifndef sv_catpvn_flags
+#define sv_catpvn_flags(b,n,l,f) sv_catpvn(b,n,l)
+#endif
 
 MODULE = Sub::Name  PACKAGE = Sub::Name
 
@@ -25,14 +62,19 @@ PROTOTYPES: DISABLE
 
 void
 subname(name, sub)
-	char *name
+	SV *name
 	SV *sub
     PREINIT:
 	CV *cv = NULL;
 	GV *gv;
 	HV *stash = CopSTASH(PL_curcop);
-	char *s, *end = NULL;
+	const char *s, *end = NULL, *begin = NULL;
 	MAGIC *mg;
+	STRLEN namelen;
+	const char* nameptr = SvPV(name, namelen);
+	int utf8flag = SvUTF8(name);
+	int quotes_seen = 0;
+	bool need_subst = FALSE;
     PPCODE:
 	if (!SvROK(sub) && SvGMAGICAL(sub))
 		mg_get(sub);
@@ -45,31 +87,84 @@ subname(name, sub)
 	else if (PL_op->op_private & HINT_STRICT_REFS)
 		croak("Can't use string (\"%.32s\") as %s ref while \"strict refs\" in use",
 		      SvPV_nolen(sub), "a subroutine");
-	else if ((gv = gv_fetchpv(SvPV_nolen(sub), FALSE, SVt_PVCV)))
+	else if ((gv = gv_fetchsv(sub, FALSE, SVt_PVCV)))
 		cv = GvCVu(gv);
 	if (!cv)
 		croak("Undefined subroutine %s", SvPV_nolen(sub));
 	if (SvTYPE(cv) != SVt_PVCV && SvTYPE(cv) != SVt_PVFM)
 		croak("Not a subroutine reference");
-	for (s = name; *s++; ) {
-		if (*s == ':' && s[-1] == ':')
-			end = ++s;
-		else if (*s && s[-1] == '\'')
-			end = s;
+
+	for (s = nameptr; s <= nameptr + namelen; s++) {
+		if (s > nameptr && *s == ':' && s[-1] == ':') {
+			end = s - 1;
+			begin = ++s;
+			if (quotes_seen)
+				need_subst = TRUE;
+		}
+		else if (s > nameptr && *s != '\0' && s[-1] == '\'') {
+			end = s - 1;
+			begin = s;
+			if (quotes_seen++)
+				need_subst = TRUE;
+		}
 	}
 	s--;
-        if (end) {
-		stash = GvHV(gv_fetchpv(savepvn(name, end - name), TRUE, SVt_PVHV));
-                name = end;
-        }
+	if (end) {
+		SV* tmp;
+		if (need_subst) {
+			STRLEN length = end - nameptr + quotes_seen - (*end == '\'' ? 1 : 0);
+			char* left;
+			int i, j;
+			tmp = sv_2mortal(newSV(length));
+			left = SvPVX(tmp);
+			for (i = 0, j = 0; j < end - nameptr; ++i, ++j) {
+				if (nameptr[j] == '\'') {
+					left[i] = ':';
+					left[++i] = ':';
+				}
+				else {
+					left[i] = nameptr[j];
+				}
+			}
+			stash = gv_stashpvn(left, length, GV_ADD | utf8flag);
+		}
+		else
+			stash = gv_stashpvn(nameptr, end - nameptr, GV_ADD | utf8flag);
+		nameptr = begin;
+		namelen -= begin - nameptr;
+	}
+
+	/* under debugger, provide information about sub location */
+	if (PL_DBsub && CvGV(cv)) {
+		HV* DBsub = GvHV(PL_DBsub);
+		HE* old_data;
+
+		GV* oldgv = CvGV(cv);
+		HV* oldhv = GvSTASH(oldgv);
+		SV* old_full_name = sv_2mortal(newSVpvn_flags(HvNAME(oldhv), HvNAMELEN_get(oldhv), HvNAMEUTF8(oldhv) ? SVf_UTF8 : 0));
+		sv_catpvn(old_full_name, "::", 2);
+		sv_catpvn_flags(old_full_name, GvNAME(oldgv), GvNAMELEN(oldgv), GvNAMEUTF8(oldgv) ? SV_CATUTF8 : SV_CATBYTES);
+
+		old_data = hv_fetch_ent(DBsub, old_full_name, 0, 0);
+
+		if (old_data && HeVAL(old_data)) {
+			SV* new_full_name = sv_2mortal(newSVpvn_flags(HvNAME(stash), HvNAMELEN_get(stash), HvNAMEUTF8(stash) ? SVf_UTF8 : 0));
+			sv_catpvn(new_full_name, "::", 2);
+			sv_catpvn_flags(new_full_name, nameptr, s - nameptr, utf8flag ? SV_CATUTF8 : SV_CATBYTES);
+			SvREFCNT_inc(HeVAL(old_data));
+			if (hv_store_ent(DBsub, new_full_name, HeVAL(old_data), 0) != NULL)
+				SvREFCNT_inc(HeVAL(old_data));
+		}
+	}
+
 	gv = (GV *) newSV(0);
-	gv_init(gv, stash, name, s - name, TRUE);
+	gv_init_pvn(gv, stash, nameptr, s - nameptr, GV_ADDMULTI | utf8flag);
 
 	mg = SvMAGIC(cv);
 	while (mg && mg->mg_virtual != &subname_vtbl)
 		mg = mg->mg_moremagic;
 	if (!mg) {
-		Newz(702, mg, 1, MAGIC);
+		Newxz(mg, 1, MAGIC);
 		mg->mg_moremagic = SvMAGIC(cv);
 		mg->mg_type = PERL_MAGIC_ext;
 		mg->mg_virtual = &subname_vtbl;