Re: [PATCH] Re: Speeding up method lookups

[p5sagit/p5-mst-13.2.git] / xsutils.c

diff --git a/xsutils.c b/xsutils.c
index f9d5e0d..7b21574 100644 (file)
--- a/xsutils.c
+++ b/xsutils.c
@@ -23,7 +23,7 @@ void XS_attributes_bootstrap(pTHXo_ CV *cv);
  *
  * The various bootstrap definitions can take care of doing
  * package-specific newXS() calls.  Since the layout of the
- * bundled lib/*.pm files is in a version-specific directory,
+ * bundled *.pm files is in a version-specific directory,
  * version checks in these bootstrap calls are optional.
  */
 
@@ -48,7 +48,7 @@ modify_SV_attributes(pTHXo_ SV *sv, SV **retlist, SV **attrlist, int numattrs)
 
     for (nret = 0 ; numattrs && (attr = *attrlist++); numattrs--) {
        name = SvPV(attr, len);
-       if (negated = (*name == '-')) {
+       if ((negated = (*name == '-')) || (*name == '+')) {
            name++;
            len--;
        }
@@ -87,6 +87,34 @@ modify_SV_attributes(pTHXo_ SV *sv, SV **retlist, SV **attrlist, int numattrs)
                }
                break;
            }
+          case SVt_IV:
+          case SVt_NV:
+          case SVt_PV:
+          case SVt_PVIV:
+          case SVt_PVNV:
+          case SVt_PVAV:
+          case SVt_PVHV:
+           switch ((int)len) {
+              case 8:
+               switch (*name) {
+                  case 'r':
+                    if (strEQ(name, "readonly")) {
+                       if (negated)
+                           SvREADONLY_off(sv);
+                       else
+                           SvREADONLY_on(sv);
+                        if (SvTYPE(sv) == SVt_PVAV && SvMAGIC(sv)
+                            && mg_find(sv, 'I')) { /* @ISA */
+                            if (negated)
+                                PL_hints &= ~HINT_CT_MRESOLVE;
+                            else
+                                PL_hints |= HINT_CT_MRESOLVE;
+                        }
+                       continue;
+                    }
+                    break;
+                }
+            }
            break;
        default:
            /* nothing, yet */
@@ -253,11 +281,9 @@ usage:
 
     rv = ST(0);
     ST(0) = TARG;
-    if (!SvOK(rv)) {
-       ST(0) = &PL_sv_no;
-       XSRETURN(1);
-    }
-    if (!SvROK(rv))
+    if (SvGMAGICAL(rv))
+       mg_get(rv);
+    if (!(SvOK(rv) && SvROK(rv)))
        goto usage;
     sv = SvRV(rv);
     sv_setpv(TARG, sv_reftype(sv, 0));
@@ -271,7 +297,6 @@ usage:
 XS(XS_attributes__warn_reserved)
 {
     dXSARGS;
-    SV *rv, *sv;
 #ifdef dXSTARGET
     dXSTARGET;
 #else