}
}
- if(predicate_calls(attr, "should_coerce")){
+ if(predicate_calls(attr, "should_coerce") && predicate_calls(tc, "has_coercion")){
flags |= MOUSEf_ATTR_SHOULD_COERCE;
}
return value;
}
+static void
+mouse_check_isa_does_does(pTHX_ SV* const klass, SV* const name, SV* const isa, SV* const does){
+ STRLEN len;
+ const char* const pv = SvPV_const(isa, len); /* need strigify */
+ bool does_ok;
+ dSP;
+
+ ENTER;
+ SAVETMPS;
+
+ SAVESPTR(ERRSV);
+ ERRSV = sv_newmortal();
+
+ PUSHMARK(SP);
+ EXTEND(SP, 2);
+ mPUSHp(pv, len);
+ PUSHs(does);
+ PUTBACK;
+
+ call_method("does", G_EVAL | G_SCALAR);
+
+ SPAGAIN;
+ does_ok = sv_true(POPs);
+ PUTBACK;
+
+ FREETMPS;
+ LEAVE;
+
+ if(!does_ok){
+ mouse_throw_error(klass, NULL,
+ "Cannot have both an isa option and a does option"
+ "because '%"SVf"' does not do '%"SVf"' on attribute (%"SVf")",
+ isa, does, name
+ );
+ }
+}
+
MODULE = Mouse::Meta::Attribute PACKAGE = Mouse::Meta::Attribute
PROTOTYPES: DISABLE
INSTALL_SIMPLE_READER_WITH_KEY(Attribute, should_auto_deref, auto_deref);
INSTALL_SIMPLE_READER_WITH_KEY(Attribute, should_coerce, coerce);
INSTALL_SIMPLE_READER(Attribute, documentation);
+ INSTALL_SIMPLE_READER(Attribute, insertion_order);
/* predicates */
INSTALL_SIMPLE_PREDICATE_WITH_KEY(Attribute, has_accessor, accessor);
/* taken from Class::MOP::Attribute::new */
- if(!SvOK(name)){
- mouse_throw_error(klass, NULL,
- "You must provide a name for the attribute");
- }
+ must_defined(name, "an attribute name");
svp = hv_fetchs(args, "init_arg", FALSE);
if(!svp){
svp = hv_fetchs(args, "builder", FALSE);
if(svp){
if(!SvOK(*svp)){
- mouse_throw_error(klass, NULL,
+ mouse_throw_error(klass, *svp,
"builder must be a defined scalar value which is a method name");
}
can_be_required = TRUE;
}
else if((svp = hv_fetchs(args, "default", FALSE))){
if(SvROK(*svp) && SvTYPE(SvRV(*svp)) != SVt_PVCV) {
- mouse_throw_error(klass, NULL,
+ mouse_throw_error(klass, *svp,
"References are not allowed as default values, you must "
"wrap the default of '%"SVf"' in a CODE reference "
"(ex: sub { [] } and not [])", name);
tc = newSVsv(POPs);
PUTBACK;
}
- else if((svp = hv_fetchs(args, "does", FALSE))){
- SPAGAIN;
- PUSHMARK(SP);
- XPUSHs(*svp);
- PUTBACK;
- call_pv("Mouse::Util::TypeConstraints::find_or_create_does_type_constraint",
- G_SCALAR);
- SPAGAIN;
- tc = newSVsv(POPs);
- PUTBACK;
+ if((svp = hv_fetchs(args, "does", FALSE))){
+ /* check 'isa' does 'does' */
+ if(tc){
+ mouse_check_isa_does_does(aTHX_ klass, name, tc, *svp);
+ /* nothing to do */
+ }
+ else{
+ SPAGAIN;
+ PUSHMARK(SP);
+ XPUSHs(*svp);
+ PUTBACK;
+
+ call_pv("Mouse::Util::TypeConstraints::find_or_create_does_type_constraint",
+ G_SCALAR);
+ SPAGAIN;
+ tc = newSVsv(POPs);
+ PUTBACK;
+ }
}
if(tc){
(void)hv_stores(args, "type_constraint", tc);