#include "mouse.h"
-#define CHECK_INSTANCE(instance) STMT_START{ \
- if(!(SvROK(instance) && SvTYPE(SvRV(instance)) == SVt_PVHV)){ \
- croak("Invalid object instance"); \
- } \
+#define CHECK_INSTANCE(instance) STMT_START{ \
+ if(!(SvROK(instance) && SvTYPE(SvRV(instance)) == SVt_PVHV)){ \
+ croak("Invalid object instance"); \
+ } \
} STMT_END
PUSHs(svp ? *svp : &PL_sv_undef);
}
}
- else if(flags & MOUSEf_TC_IS_HASHREF){
+ else{
HV* hv;
HE* he;
+ assert(flags & MOUSEf_TC_IS_HASHREF);
+
if(!IsHashRef(value)){
croak("Mouse-panic: Not a HASH reference");
}
value = mouse_xa_apply_type_constraint(aTHX_ MOUSE_mg_xa(mg), value, flags);
}
- set_slot(self, slot, value);
+ value = set_slot(self, slot, value);
if(flags & MOUSEf_ATTR_IS_WEAK_REF){
weaken_slot(self, slot);
SV* const trigger = mcall0s(MOUSE_mg_attribute(mg), "trigger");
dSP;
+ /* NOTE: triggers can remove value, so
+ value must be copied here,
+ revealed by Net::Google::DataAPI (DANJOU).
+ */
+ value = sv_mortalcopy(value);
+
PUSHMARK(SP);
EXTEND(SP, 2);
PUSHs(self);
PUSHs(value);
PUTBACK;
- call_sv(trigger, G_VOID | G_DISCARD);
+ call_sv_safe(trigger, G_VOID | G_DISCARD);
/* need not SPAGAIN */
+
+ assert(SvTYPE(value) != SVTYPEMASK);
}
PUSH_VALUE(value, flags);
return xsub;
}
-XS(XS_Mouse_simple_accessor)
-{
- dVAR; dXSARGS;
- dMOUSE_self;
- MAGIC* const mg = (MAGIC*)XSANY.any_ptr;
- SV* value;
-
- if(items == 1){ /* reader */
- value = get_slot(self, MOUSE_mg_slot(mg));
- if(!value) {
- if(MOUSE_mg_ptr(mg)){
- /* the default value must be a SV */
- assert(MOUSE_mg_len(mg) == HEf_SVKEY);
- value = (SV*)MOUSE_mg_ptr(mg);
- }
- else{
- value = &PL_sv_undef;
- }
- }
- }
- else if(items == 2){ /* writer */
- value = set_slot(self, MOUSE_mg_slot(mg), ST(1));
- }
- else {
- croak("Expected exactly one or two argument for an accessor for '%"SVf"'", MOUSE_mg_slot(mg));
- }
-
- ST(0) = value;
- XSRETURN(1);
-}
-
XS(XS_Mouse_simple_reader)
{
dVAR; dXSARGS;
}
value = get_slot(self, MOUSE_mg_slot(mg));
- ST(0) = value ? value : &PL_sv_undef;
+ if(!value) {
+ if(MOUSE_mg_ptr(mg)){
+ /* the default value must be a SV */
+ assert(MOUSE_mg_len(mg) == HEf_SVKEY);
+ value = (SV*)MOUSE_mg_ptr(mg);
+ }
+ else{
+ value = &PL_sv_undef;
+ }
+ }
+
+ ST(0) = value;
XSRETURN(1);
}
CHECK_INSTANCE(instance);
he = hv_fetch_ent((HV*)SvRV(instance), slot, TRUE, 0U);
sv = HeVAL(he);
- sv_setsv_mg(sv, value);
+ sv_setsv(sv, value);
+ SvSETMAGIC(sv);
return sv;
}
sv_rvweaken(HeVAL(he));
}
}
-\r
+
MODULE = Mouse::Meta::Method::Accessor::XS PACKAGE = Mouse::Meta::Method::Accessor::XS
PROTOTYPES: DISABLE
_generate_clearer(klass, SV* attr, metaclass)
CODE:
{
- SV* const slot = mcall0s(attr, "name");
+ SV* const slot = mcall0(attr, mouse_name);
STRLEN len;
const char* const pv = SvPV_const(slot, len);
RETVAL = mouse_simple_accessor_generate(aTHX_ NULL, pv, len, XS_Mouse_simple_clearer, NULL, 0);
_generate_predicate(klass, SV* attr, metaclass)
CODE:
{
- SV* const slot = mcall0s(attr, "name");
+ SV* const slot = mcall0(attr, mouse_name);
STRLEN len;
const char* const pv = SvPV_const(slot, len);
RETVAL = mouse_simple_accessor_generate(aTHX_ NULL, pv, len, XS_Mouse_simple_predicate, NULL, 0);